You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/06/04 23:02:05 UTC
[GitHub] incubator-guacamole-manual pull request #48: GUACAMOLE-292: Document new use...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-manual/pull/48
GUACAMOLE-292: Document new user profile columns of guacamole_user.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-manual user-profile-schema
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-manual/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit bde9e092711c4537e84d914016ad956ed7b5d6e8
Author: Michael Jumper <mj...@apache.org>
Date: 2017-06-04T22:47:34Z
GUACAMOLE-292: Document new user profile columns of guacamole_user.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #48: GUACAMOLE-292: Document new use...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-manual/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #48: GUACAMOLE-292: Document new use...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/48#discussion_r120526769
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -805,6 +805,48 @@ postgresql-user-required: true</programlisting>
zones.</para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><property>full_name</property></term>
+ <listitem>
+ <para>The user's full name. Unlike the username, this name need not be
--- End diff --
Not that I think it's super needed, but why does this paragraph not have a thing about setting the column to NULL like the others?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #48: GUACAMOLE-292: Document new use...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/48#discussion_r120528922
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -805,6 +805,48 @@ postgresql-user-required: true</programlisting>
zones.</para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><property>full_name</property></term>
+ <listitem>
+ <para>The user's full name. Unlike the username, this name need not be
--- End diff --
There - hopefully that adds some clarity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #48: GUACAMOLE-292: Document new use...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/48#discussion_r120528446
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -805,6 +805,48 @@ postgresql-user-required: true</programlisting>
zones.</para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><property>full_name</property></term>
+ <listitem>
+ <para>The user's full name. Unlike the username, this name need not be
--- End diff --
I'll add a thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #48: GUACAMOLE-292: Document new use...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/48#discussion_r120529367
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -805,6 +805,48 @@ postgresql-user-required: true</programlisting>
zones.</para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term><property>full_name</property></term>
+ <listitem>
+ <para>The user's full name. Unlike the username, this name need not be
--- End diff --
#CONSISTENCY
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---