You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2016/12/05 18:08:21 UTC
Review Request 54384: Host-Ordered: Empty groups are returned for
Downgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54384/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Duc Le.
Bugs: AMBARI-19074
https://issues.apache.org/jira/browse/AMBARI-19074
Repository: ambari
Description
-------
The downgrade orchestration for HOU was failing as the if-check was only checking for Rolling/Express.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java aa97fa3
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 6b4b85a
Diff: https://reviews.apache.org/r/54384/diff/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 54384: Host-Ordered: Empty groups are returned for
Downgrade
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54384/#review158042
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java (line 298)
<https://reviews.apache.org/r/54384/#comment228713>
Should we throw exceptions on default? Some would argue yes :)
Maybe even a System.exit(-1) :)
- Jonathan Hurley
On Dec. 5, 2016, 1:08 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54384/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 1:08 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Duc Le.
>
>
> Bugs: AMBARI-19074
> https://issues.apache.org/jira/browse/AMBARI-19074
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The downgrade orchestration for HOU was failing as the if-check was only checking for Rolling/Express.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java aa97fa3
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 6b4b85a
>
> Diff: https://reviews.apache.org/r/54384/diff/
>
>
> Testing
> -------
>
> Manual. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 54384: Host-Ordered: Empty groups are returned for
Downgrade
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54384/
-----------------------------------------------------------
(Updated Dec. 5, 2016, 3:26 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Duc Le.
Changes
-------
Test results for completeness. Thanks for the reviews!
Bugs: AMBARI-19074
https://issues.apache.org/jira/browse/AMBARI-19074
Repository: ambari
Description
-------
The downgrade orchestration for HOU was failing as the if-check was only checking for Rolling/Express.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java aa97fa3
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 6b4b85a
Diff: https://reviews.apache.org/r/54384/diff/
Testing (updated)
-------
Manual. Automated:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 37:26.668s
[INFO] Finished at: Mon Dec 05 13:41:39 EST 2016
[INFO] Final Memory: 40M/616M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 54384: Host-Ordered: Empty groups are returned for
Downgrade
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54384/#review158040
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 5, 2016, 6:08 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54384/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 6:08 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Duc Le.
>
>
> Bugs: AMBARI-19074
> https://issues.apache.org/jira/browse/AMBARI-19074
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The downgrade orchestration for HOU was failing as the if-check was only checking for Rolling/Express.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java aa97fa3
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 6b4b85a
>
> Diff: https://reviews.apache.org/r/54384/diff/
>
>
> Testing
> -------
>
> Manual. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 54384: Host-Ordered: Empty groups are returned for
Downgrade
Posted by Duc Le <du...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54384/#review158023
-----------------------------------------------------------
Ship it!
Ship It!
- Duc Le
On Dec. 5, 2016, 6:08 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54384/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 6:08 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Duc Le.
>
>
> Bugs: AMBARI-19074
> https://issues.apache.org/jira/browse/AMBARI-19074
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The downgrade orchestration for HOU was failing as the if-check was only checking for Rolling/Express.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java aa97fa3
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 6b4b85a
>
> Diff: https://reviews.apache.org/r/54384/diff/
>
>
> Testing
> -------
>
> Manual. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>