[GitHub] [kafka] chia7712 commented on a change in pull request #10943: Fix verification of version probing

[GitBox <gi...@apache.org>]

chia7712 commented on a change in pull request #10943:
URL: https://github.com/apache/kafka/pull/10943#discussion_r665323302



##########
File path: tests/kafkatest/tests/streams/streams_upgrade_test.py
##########
@@ -474,8 +474,9 @@ def do_rolling_bounce(self, processor, counter, current_generation):
                     monitors[first_other_processor] = first_other_monitor
                     monitors[second_other_processor] = second_other_monitor
 
-                    version_probing_message = "Sent a version 10 subscription and got version 10 assignment back (successful version probing). Downgrade subscription metadata to commonly supported version 10 and trigger new rebalance.",
-                    end_of_upgrade_message = "Sent a version 10 subscription and group.s latest commonly supported version is 11 (successful version probing and end of rolling upgrade). Upgrading subscription metadata version to 11 for next rebalance."
+                    highest_version = 10

Review comment:
       Could you add comments about why/when we need to bump this value? That can helps us from debugging this issue (again) in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org