You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/18 18:25:11 UTC

[GitHub] [incubator-pinot] mqliang opened a new pull request #6695: Extends StreamingSelectionOnlyCombineOperator from BaseCombineOperator

mqliang opened a new pull request #6695:
URL: https://github.com/apache/incubator-pinot/pull/6695


   ## Description
   This PR refactor StreamingSelectionOnlyCombineOperator to make it extends from BaseCombineOperator. Since https://github.com/apache/incubator-pinot/pull/6680 has instrumented BaseCombineOperator query execution code with thread cpu time, with this refactoring, StreamingSelectionOnlyCombineOperator will also get instrumented. 
   
   ## Upgrade Notes
   Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
   * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
   
   Does this PR fix a zero-downtime upgrade introduced earlier?
   * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
   
   Does this PR otherwise need attention when creating release notes? Things to consider:
   - New configuration options
   - Deprecation of configurations
   - Signature changes to public methods/interfaces
   - New plugins added or old plugins removed
   * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
   ## Release Notes
   If you have tagged this as either backward-incompat or release-notes,
   you MUST add text here that you would like to see appear in release notes of the
   next release.
   
   If you have a series of commits adding or enabling a feature, then
   add this section only in final commit that marks the feature completed.
   Refer to earlier release notes to see examples of text
   
   ## Documentation
   If you have introduced a new feature or configuration, please add it to the documentation as well.
   See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6695: Extends StreamingSelectionOnlyCombineOperator from BaseCombineOperator

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on pull request #6695:
URL: https://github.com/apache/incubator-pinot/pull/6695#issuecomment-802378978


   @mqliang @siddharthteotia Please take a look at #6696 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mqliang commented on pull request #6695: Extends StreamingSelectionOnlyCombineOperator from BaseCombineOperator

Posted by GitBox <gi...@apache.org>.
mqliang commented on pull request #6695:
URL: https://github.com/apache/incubator-pinot/pull/6695#issuecomment-802184620


   @siddharthteotia 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mqliang closed pull request #6695: Extends StreamingSelectionOnlyCombineOperator from BaseCombineOperator

Posted by GitBox <gi...@apache.org>.
mqliang closed pull request #6695:
URL: https://github.com/apache/incubator-pinot/pull/6695


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mqliang commented on pull request #6695: Extends StreamingSelectionOnlyCombineOperator from BaseCombineOperator

Posted by GitBox <gi...@apache.org>.
mqliang commented on pull request #6695:
URL: https://github.com/apache/incubator-pinot/pull/6695#issuecomment-802382120


   close this in favor of https://github.com/apache/incubator-pinot/pull/6696


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org