You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/04/08 17:58:03 UTC
[GitHub] [maven-jarsigner] elharo opened a new pull request, #2: Update parent POM to 39
elharo opened a new pull request, #2:
URL: https://github.com/apache/maven-jarsigner/pull/2
This project had gotten quite far behind so this ended up pulling in a lot of other upgrades too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] michael-o commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1561831751
Should we delete the branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jarsigner] elharo commented on a diff in pull request #2: Update parent POM to 39
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#discussion_r1161161880
##########
pom.xml:
##########
@@ -56,21 +56,21 @@
<properties>
<surefire.version>2.21.0</surefire.version>
- <mavenVersion>3.0</mavenVersion>
- <javaVersion>7</javaVersion>
+ <mavenVersion>3.2.5</mavenVersion>
Review Comment:
I can expand the issue, but it's not really possible. Changing the parent pom required changing a bunch of other things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] elharo commented on pull request #2: [MJARSIGNER-65] Update parent POM to 39
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1500988444
I can file another issue but it has to be one PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] slachiewicz commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1562353752
i'll leave this to @elharo maybe he wants to pickup something more from his branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jarsigner] slachiewicz commented on pull request #2: Update parent POM to 39
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1500957550
missing jira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] elharo commented on pull request #2: [MJARSIGNER-65] Update parent POM to 39
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1500983712
JIRA added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] elharo commented on a diff in pull request #2: Update parent POM to 39
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#discussion_r1161162052
##########
src/main/java/org/apache/maven/shared/jarsigner/JarSignerUtil.java:
##########
@@ -200,37 +174,32 @@ public static boolean isArchiveSigned( final File jarFile )
* @param entryName The name of the JAR file entry to check, must not be <code>null</code>.
* @return <code>true</code> if the entry is related to a signature, <code>false</code> otherwise.
*/
- protected static boolean isSignatureFile( String entryName )
- {
- if ( entryName.regionMatches( true, 0, "META-INF", 0, 8 ) )
- {
- entryName = entryName.replace( '\\', '/' );
-
- if ( entryName.indexOf( '/' ) == 8 && entryName.lastIndexOf( '/' ) == 8 )
- {
- return endsWithIgnoreCase( entryName, ".SF" ) || endsWithIgnoreCase( entryName, ".DSA" )
- || endsWithIgnoreCase( entryName, ".RSA" ) || endsWithIgnoreCase( entryName, ".EC" );
+ protected static boolean isSignatureFile(String entryName) {
+ if (entryName.regionMatches(true, 0, "META-INF", 0, 8)) {
+ entryName = entryName.replace('\\', '/');
+
+ if (entryName.indexOf('/') == 8 && entryName.lastIndexOf('/') == 8) {
+ return endsWithIgnoreCase(entryName, ".SF")
+ || endsWithIgnoreCase(entryName, ".DSA")
+ || endsWithIgnoreCase(entryName, ".RSA")
+ || endsWithIgnoreCase(entryName, ".EC");
}
}
return false;
}
- protected static boolean isManifestFile( String entryName )
- {
- if ( entryName.regionMatches( true, 0, "META-INF", 0, 8 ) )
- {
- entryName = entryName.replace( '\\', '/' );
+ protected static boolean isManifestFile(String entryName) {
+ if (entryName.regionMatches(true, 0, "META-INF", 0, 8)) {
+ entryName = entryName.replace('\\', '/');
Review Comment:
ditto
##########
src/main/java/org/apache/maven/shared/jarsigner/JarSignerUtil.java:
##########
@@ -200,37 +174,32 @@ public static boolean isArchiveSigned( final File jarFile )
* @param entryName The name of the JAR file entry to check, must not be <code>null</code>.
* @return <code>true</code> if the entry is related to a signature, <code>false</code> otherwise.
*/
- protected static boolean isSignatureFile( String entryName )
- {
- if ( entryName.regionMatches( true, 0, "META-INF", 0, 8 ) )
- {
- entryName = entryName.replace( '\\', '/' );
-
- if ( entryName.indexOf( '/' ) == 8 && entryName.lastIndexOf( '/' ) == 8 )
- {
- return endsWithIgnoreCase( entryName, ".SF" ) || endsWithIgnoreCase( entryName, ".DSA" )
- || endsWithIgnoreCase( entryName, ".RSA" ) || endsWithIgnoreCase( entryName, ".EC" );
+ protected static boolean isSignatureFile(String entryName) {
+ if (entryName.regionMatches(true, 0, "META-INF", 0, 8)) {
+ entryName = entryName.replace('\\', '/');
Review Comment:
Please file an issue for that. These lines are changing only because parent pom 39 requires reformatting. Byte code should be identical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] slawekjaranowski commented on a diff in pull request #2: Update parent POM to 39
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#discussion_r1161157749
##########
pom.xml:
##########
@@ -56,21 +56,21 @@
<properties>
<surefire.version>2.21.0</surefire.version>
- <mavenVersion>3.0</mavenVersion>
- <javaVersion>7</javaVersion>
+ <mavenVersion>3.2.5</mavenVersion>
Review Comment:
In will be good to have changing Maven version and JDK requirement in separate change with separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] slachiewicz closed pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
URL: https://github.com/apache/maven-jarsigner/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jarsigner] slachiewicz commented on a diff in pull request #2: [MJARSIGNER-65] Update parent POM to 39
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#discussion_r1161163090
##########
pom.xml:
##########
@@ -56,21 +56,21 @@
<properties>
<surefire.version>2.21.0</surefire.version>
- <mavenVersion>3.0</mavenVersion>
- <javaVersion>7</javaVersion>
+ <mavenVersion>3.2.5</mavenVersion>
Review Comment:
java version upgrade must be separate issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] slachiewicz commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1501129583
About Java 8 upgrade - also separate from parent upgrade to avoid user confusion - agreed long time ago with Robert and followed in other repos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] slachiewicz commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1501128571
we have different practice in other our repos. First commit with parent update - usualy also cleanup to plugins, remove redundant after upgrade entries.
Then Fix commit with reformat only
then 3th commit to ignore above commit for git blame
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] slachiewicz commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1501129794
Or if @michael-o says that this PR is ok - ok, no need to correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] elharo commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1501151024
Maybe that would work. I'm not sure. My general approach is that anything that gets pulled in as a requirement of whatever I'm trying to do (upgrade to 39) is fine as part of that upgrade. I have limited appetite for a combinatorial explosion of all possible orders of individual changes, and I do think we need to pay attention to the amount of time we're burning on super strict commit processes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] michael-o commented on a diff in pull request #2: Update parent POM to 39
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#discussion_r1161147129
##########
src/main/java/org/apache/maven/shared/jarsigner/JarSignerUtil.java:
##########
@@ -200,37 +174,32 @@ public static boolean isArchiveSigned( final File jarFile )
* @param entryName The name of the JAR file entry to check, must not be <code>null</code>.
* @return <code>true</code> if the entry is related to a signature, <code>false</code> otherwise.
*/
- protected static boolean isSignatureFile( String entryName )
- {
- if ( entryName.regionMatches( true, 0, "META-INF", 0, 8 ) )
- {
- entryName = entryName.replace( '\\', '/' );
-
- if ( entryName.indexOf( '/' ) == 8 && entryName.lastIndexOf( '/' ) == 8 )
- {
- return endsWithIgnoreCase( entryName, ".SF" ) || endsWithIgnoreCase( entryName, ".DSA" )
- || endsWithIgnoreCase( entryName, ".RSA" ) || endsWithIgnoreCase( entryName, ".EC" );
+ protected static boolean isSignatureFile(String entryName) {
+ if (entryName.regionMatches(true, 0, "META-INF", 0, 8)) {
+ entryName = entryName.replace('\\', '/');
Review Comment:
This replacement is invalid, it should be dropped.
##########
src/main/java/org/apache/maven/shared/jarsigner/JarSignerUtil.java:
##########
@@ -200,37 +174,32 @@ public static boolean isArchiveSigned( final File jarFile )
* @param entryName The name of the JAR file entry to check, must not be <code>null</code>.
* @return <code>true</code> if the entry is related to a signature, <code>false</code> otherwise.
*/
- protected static boolean isSignatureFile( String entryName )
- {
- if ( entryName.regionMatches( true, 0, "META-INF", 0, 8 ) )
- {
- entryName = entryName.replace( '\\', '/' );
-
- if ( entryName.indexOf( '/' ) == 8 && entryName.lastIndexOf( '/' ) == 8 )
- {
- return endsWithIgnoreCase( entryName, ".SF" ) || endsWithIgnoreCase( entryName, ".DSA" )
- || endsWithIgnoreCase( entryName, ".RSA" ) || endsWithIgnoreCase( entryName, ".EC" );
+ protected static boolean isSignatureFile(String entryName) {
+ if (entryName.regionMatches(true, 0, "META-INF", 0, 8)) {
+ entryName = entryName.replace('\\', '/');
+
+ if (entryName.indexOf('/') == 8 && entryName.lastIndexOf('/') == 8) {
+ return endsWithIgnoreCase(entryName, ".SF")
+ || endsWithIgnoreCase(entryName, ".DSA")
+ || endsWithIgnoreCase(entryName, ".RSA")
+ || endsWithIgnoreCase(entryName, ".EC");
}
}
return false;
}
- protected static boolean isManifestFile( String entryName )
- {
- if ( entryName.regionMatches( true, 0, "META-INF", 0, 8 ) )
- {
- entryName = entryName.replace( '\\', '/' );
+ protected static boolean isManifestFile(String entryName) {
+ if (entryName.regionMatches(true, 0, "META-INF", 0, 8)) {
+ entryName = entryName.replace('\\', '/');
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] slachiewicz commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1501066045
Missing Jira in commit message - not only in PR header. We add one commit to change pom, one another to reformat and then another to ignore formatting.
Squash will merge all commits i to one and You will not be able to distinguish planned changes to formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] elharo commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1501114911
Reformatting is, perhaps unfortunately, a fundamental and unavoidable part of the upgrade to parent pom 39 due to the way the new parent pom is configured. Without the reformat the build is broken. Now that I think about it, splitting this into separate commits as I have done in some of these upgrade PRs means that the build is broken at commit that changes the parent pom version. That's going to make `git bisect` unreliable if we ever need to use it, and I shouldn't have done that. A single commit per project is what we need for these upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] slachiewicz commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1501129108
<img width="1034" alt="image" src="https://user-images.githubusercontent.com/6705942/230775330-98df7425-e0f7-4448-b94d-7be22aff0d20.png">
and 3th commit: https://github.com/apache/maven/commit/19c897de6fea72e023a504ad4d5928e066ab7c52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-jarsigner] slachiewicz commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #2:
URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1561819188
Replaced by #5 #6 #7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org