[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20850: feat: Reuse Dashboard redux data in Explore

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #20850:
URL: https://github.com/apache/superset/pull/20850#discussion_r929071798


##########
superset/charts/schemas.py:
##########
@@ -165,6 +170,11 @@ class ChartEntityResponseSchema(Schema):
     slice_url = fields.String(description=slice_url_description)
     certified_by = fields.String(description=certified_by_description)
     certification_details = fields.String(description=certification_details_description)
+    is_managed_externally = fields.Boolean(
+        description=is_managed_externally_description
+    )
+    owners = fields.List(fields.Nested(UserSchema))

Review Comment:
   a minor suggestion from recent fixing. the `owners` fields suggest that align with [Dashboard](https://github.com/apache/superset/pull/20826/files#) field to `owners = fields.List(fields.Dict())`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org