You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Paul McMahan <pa...@gmail.com> on 2007/05/31 00:10:03 UTC
intentional change to ErrorReportValve?
A recent change to ErrorReportValve is causing a problem with TCK.
From the commit log it seems that the change was not supposed to
introduce any new behavior:
http://svn.apache.org/viewvc?view=rev&revision=535915
But the valve's behavior was changed because the check for
response.isCommitted() was replaced with response.isAppCommitted().
Was that change intentional or should it be reverted?
Best wishes,
Paul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: intentional change to ErrorReportValve?
Posted by Remy Maucherat <re...@apache.org>.
Paul McMahan wrote:
> Yoav, Thanks for following up. Yesterday rev 543307 fixed the problem
> in tc6.0.x/trunk. But the problem still remains in trunk. Not sure if
> there are plans to apply BZ 42559 there as well.
Trunk does not have any official existence as a release branch, so it's
not really important at this point. The change will be applied there
eventually, of course.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: intentional change to ErrorReportValve?
Posted by Paul McMahan <pa...@gmail.com>.
Yoav, Thanks for following up. Yesterday rev 543307 fixed the
problem in tc6.0.x/trunk. But the problem still remains in trunk.
Not sure if there are plans to apply BZ 42559 there as well.
Best wishes,
Paul
On Jun 1, 2007, at 9:49 AM, Yoav Shapira wrote:
> Hi,.
>
> On 5/30/07, Paul McMahan <pa...@gmail.com> wrote:
>> A recent change to ErrorReportValve is causing a problem with TCK.
>> From the commit log it seems that the change was not supposed to
>> introduce any new behavior:
>> http://svn.apache.org/viewvc?view=rev&revision=535915
>>
>> But the valve's behavior was changed because the check for
>> response.isCommitted() was replaced with response.isAppCommitted().
>> Was that change intentional or should it be reverted?
>
> Paul, did you ever hear back on this? I'd be concerned with a TCK
> failure in this area.
>
> Yoav
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: intentional change to ErrorReportValve?
Posted by Yoav Shapira <yo...@apache.org>.
Hi,.
On 5/30/07, Paul McMahan <pa...@gmail.com> wrote:
> A recent change to ErrorReportValve is causing a problem with TCK.
> From the commit log it seems that the change was not supposed to
> introduce any new behavior:
> http://svn.apache.org/viewvc?view=rev&revision=535915
>
> But the valve's behavior was changed because the check for
> response.isCommitted() was replaced with response.isAppCommitted().
> Was that change intentional or should it be reverted?
Paul, did you ever hear back on this? I'd be concerned with a TCK
failure in this area.
Yoav
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org