You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/13 09:05:19 UTC
[GitHub] [flink] dmvk opened a new pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
dmvk opened a new pull request #16807:
URL: https://github.com/apache/flink/pull/16807
https://issues.apache.org/jira/browse/FLINK-21867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nicoweidner commented on a change in pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #16807:
URL: https://github.com/apache/flink/pull/16807#discussion_r689498602
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.html
##########
@@ -40,23 +40,25 @@
<ng-container *ngFor="let exception of listOfException;trackBy:trackExceptionBy;">
<tr>
<td nzShowExpand [(nzExpand)]="exception.expand"></td>
- <td>{{exception.timestamp | date:'yyyy-MM-dd HH:mm:ss'}}</td>
- <td><div class="name">{{exception.exceptionName}}</div></td>
+ <td>{{exception.selected.timestamp | date:'yyyy-MM-dd HH:mm:ss'}}</td>
+ <td><div class="name">{{exception.selected.exceptionName}}</div></td>
<td>
- <div class="name">
- {{exception.taskName || "(global failure)"}}
- </div>
+ <nz-select style="width: 300px;" [nzDisabled]="exception.values.length == 1" nzShowSearch [(ngModel)]="exception.selected">
Review comment:
I have a slight preference to just not disable it in the case of a single option, but it's fine either way!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
}, {
"hash" : "161a8355344db790c99236586fa243d7ea41bb1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128",
"triggerID" : "161a8355344db790c99236586fa243d7ea41bb1f",
"triggerType" : "PUSH"
}, {
"hash" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22256",
"triggerID" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"triggerType" : "PUSH"
}, {
"hash" : "d8a71a9a7918e6eb4fa6292d3f28b554edab0b66",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22295",
"triggerID" : "d8a71a9a7918e6eb4fa6292d3f28b554edab0b66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8a71a9a7918e6eb4fa6292d3f28b554edab0b66 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22295)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
dmvk commented on a change in pull request #16807:
URL: https://github.com/apache/flink/pull/16807#discussion_r689270235
##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-exception.ts
##########
@@ -46,3 +46,7 @@ export interface ExceptionInfoInterface {
taskName: string;
location: string;
}
+
+export interface RootExceptionInfoInterface extends ExceptionInfoInterface {
Review comment:
I think this one should be exported (all interfaces in this module are and these are used from different module). What am I missing here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
}, {
"hash" : "161a8355344db790c99236586fa243d7ea41bb1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128",
"triggerID" : "161a8355344db790c99236586fa243d7ea41bb1f",
"triggerType" : "PUSH"
}, {
"hash" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22256",
"triggerID" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"triggerType" : "PUSH"
}, {
"hash" : "d8a71a9a7918e6eb4fa6292d3f28b554edab0b66",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22295",
"triggerID" : "d8a71a9a7918e6eb4fa6292d3f28b554edab0b66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f14de3c2fc1ead874f9054886fe95e0a38d95104 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22256)
* d8a71a9a7918e6eb4fa6292d3f28b554edab0b66 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22295)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
}, {
"hash" : "161a8355344db790c99236586fa243d7ea41bb1f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128",
"triggerID" : "161a8355344db790c99236586fa243d7ea41bb1f",
"triggerType" : "PUSH"
}, {
"hash" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22256",
"triggerID" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 161a8355344db790c99236586fa243d7ea41bb1f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128)
* f14de3c2fc1ead874f9054886fe95e0a38d95104 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22256)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nicoweidner commented on a change in pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #16807:
URL: https://github.com/apache/flink/pull/16807#discussion_r688618451
##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-exception.ts
##########
@@ -46,3 +46,7 @@ export interface ExceptionInfoInterface {
taskName: string;
location: string;
}
+
+export interface RootExceptionInfoInterface extends ExceptionInfoInterface {
Review comment:
export seems unnecessary
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.ts
##########
@@ -22,6 +22,12 @@ import { ExceptionInfoInterface } from 'interfaces';
import { distinctUntilChanged, flatMap, tap } from 'rxjs/operators';
import { JobService } from 'services';
+export interface ExceptionInfoInterfaceWrapper {
Review comment:
export seems unnecessary.
nit: What do you think of `ConcurrentExceptions`?
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.ts
##########
@@ -61,7 +67,22 @@ export class JobExceptionsComponent implements OnInit {
this.rootException = 'No Root Exception';
}
this.truncated = exceptionHistory.truncated;
- this.listOfException = exceptionHistory.entries;
+ this.listOfException = exceptionHistory.entries.map(entry => {
+ const values: ExceptionInfoInterface[] = [];
+ values.push(entry);
+ entry.concurrentExceptions.forEach(ex => values.push(ex));
Review comment:
nit: `values = values.concat(concurrentExceptions).map(markGlobalFailure)`
where
```
function markGlobalFailure(exception: ExceptionInfoInterface) {
if (exception.taskName == null) {
exception.taskName = '(global failure)';
}
return exception;
}
```
This is all subjective style, but I find it easier to read...
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.ts
##########
@@ -61,7 +67,22 @@ export class JobExceptionsComponent implements OnInit {
this.rootException = 'No Root Exception';
}
this.truncated = exceptionHistory.truncated;
- this.listOfException = exceptionHistory.entries;
+ this.listOfException = exceptionHistory.entries.map(entry => {
+ const values: ExceptionInfoInterface[] = [];
+ values.push(entry);
Review comment:
I think this will add all concurrent exceptions to this entry as well, which will be unnecessary clutter (have yet to find out how I can produce nice exceptions to test...)
We can use something like this to extract the main exception:
```
function extractMainException(rootException: RootExceptionInfoInterface) {
const {concurrentExceptions, ...mainException} = rootException;
return mainException;
}
```
I first wanted to use lodash fp `omit`, but it only gives `Partial` return types, which is annoying
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.ts
##########
@@ -22,6 +22,12 @@ import { ExceptionInfoInterface } from 'interfaces';
import { distinctUntilChanged, flatMap, tap } from 'rxjs/operators';
import { JobService } from 'services';
+export interface ExceptionInfoInterfaceWrapper {
+ selected: ExceptionInfoInterface;
+ values: ExceptionInfoInterface[];
Review comment:
nit/suggestion:
```suggestion
exceptions: ExceptionInfoInterface[];
```
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.ts
##########
@@ -30,7 +36,7 @@ import { JobService } from 'services';
})
export class JobExceptionsComponent implements OnInit {
rootException = '';
- listOfException: ExceptionInfoInterface[] = [];
+ listOfException: ExceptionInfoInterfaceWrapper[] = [];
Review comment:
```suggestion
listOfExceptions: ExceptionInfoInterfaceWrapper[] = [];
```
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.ts
##########
@@ -22,6 +22,12 @@ import { ExceptionInfoInterface } from 'interfaces';
import { distinctUntilChanged, flatMap, tap } from 'rxjs/operators';
import { JobService } from 'services';
+export interface ExceptionInfoInterfaceWrapper {
+ selected: ExceptionInfoInterface;
+ values: ExceptionInfoInterface[];
Review comment:
(renaming here would also require renaming some of the variables in the html template)
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.html
##########
@@ -40,23 +40,25 @@
<ng-container *ngFor="let exception of listOfException;trackBy:trackExceptionBy;">
<tr>
<td nzShowExpand [(nzExpand)]="exception.expand"></td>
- <td>{{exception.timestamp | date:'yyyy-MM-dd HH:mm:ss'}}</td>
- <td><div class="name">{{exception.exceptionName}}</div></td>
+ <td>{{exception.selected.timestamp | date:'yyyy-MM-dd HH:mm:ss'}}</td>
+ <td><div class="name">{{exception.selected.exceptionName}}</div></td>
<td>
- <div class="name">
- {{exception.taskName || "(global failure)"}}
- </div>
+ <nz-select style="width: 300px;" [nzDisabled]="exception.values.length == 1" nzShowSearch [(ngModel)]="exception.selected">
Review comment:
I am a bit skeptical of using `nzDisabled` in the case of a single exception, but I will have to try and see if I have another suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nicoweidner commented on a change in pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #16807:
URL: https://github.com/apache/flink/pull/16807#discussion_r689498602
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.html
##########
@@ -40,23 +40,25 @@
<ng-container *ngFor="let exception of listOfException;trackBy:trackExceptionBy;">
<tr>
<td nzShowExpand [(nzExpand)]="exception.expand"></td>
- <td>{{exception.timestamp | date:'yyyy-MM-dd HH:mm:ss'}}</td>
- <td><div class="name">{{exception.exceptionName}}</div></td>
+ <td>{{exception.selected.timestamp | date:'yyyy-MM-dd HH:mm:ss'}}</td>
+ <td><div class="name">{{exception.selected.exceptionName}}</div></td>
<td>
- <div class="name">
- {{exception.taskName || "(global failure)"}}
- </div>
+ <nz-select style="width: 300px;" [nzDisabled]="exception.values.length == 1" nzShowSearch [(ngModel)]="exception.selected">
Review comment:
I have a slight preference to just not disable it in the case of a single option, but it's fine either way!
edit: I was hoping for some option of nz-select to just disable the dropdown arrow, but that doesn't seem to exist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
}, {
"hash" : "161a8355344db790c99236586fa243d7ea41bb1f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128",
"triggerID" : "161a8355344db790c99236586fa243d7ea41bb1f",
"triggerType" : "PUSH"
}, {
"hash" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 161a8355344db790c99236586fa243d7ea41bb1f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128)
* f14de3c2fc1ead874f9054886fe95e0a38d95104 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
}, {
"hash" : "161a8355344db790c99236586fa243d7ea41bb1f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "161a8355344db790c99236586fa243d7ea41bb1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7d2890cfde8e0f051c8aceac177c520bbf7b2c4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078)
* 161a8355344db790c99236586fa243d7ea41bb1f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898305649
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c7d2890cfde8e0f051c8aceac177c520bbf7b2c4 (Fri Aug 13 09:07:57 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
dmvk commented on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-899275917
@nicoweidner Thanks for the review! I've addressed your comments, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nicoweidner commented on a change in pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
nicoweidner commented on a change in pull request #16807:
URL: https://github.com/apache/flink/pull/16807#discussion_r689337722
##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-exception.ts
##########
@@ -46,3 +46,7 @@ export interface ExceptionInfoInterface {
taskName: string;
location: string;
}
+
+export interface RootExceptionInfoInterface extends ExceptionInfoInterface {
Review comment:
Since there is no outside usage, it seemed unnecessary to export, that's all... But it's fine to export, it might see some future use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7d2890cfde8e0f051c8aceac177c520bbf7b2c4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #16807:
URL: https://github.com/apache/flink/pull/16807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
}, {
"hash" : "161a8355344db790c99236586fa243d7ea41bb1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128",
"triggerID" : "161a8355344db790c99236586fa243d7ea41bb1f",
"triggerType" : "PUSH"
}, {
"hash" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22256",
"triggerID" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f14de3c2fc1ead874f9054886fe95e0a38d95104 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22256)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
}, {
"hash" : "161a8355344db790c99236586fa243d7ea41bb1f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128",
"triggerID" : "161a8355344db790c99236586fa243d7ea41bb1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7d2890cfde8e0f051c8aceac177c520bbf7b2c4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078)
* 161a8355344db790c99236586fa243d7ea41bb1f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7d2890cfde8e0f051c8aceac177c520bbf7b2c4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
}, {
"hash" : "161a8355344db790c99236586fa243d7ea41bb1f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128",
"triggerID" : "161a8355344db790c99236586fa243d7ea41bb1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 161a8355344db790c99236586fa243d7ea41bb1f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22078",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
}, {
"hash" : "161a8355344db790c99236586fa243d7ea41bb1f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22128",
"triggerID" : "161a8355344db790c99236586fa243d7ea41bb1f",
"triggerType" : "PUSH"
}, {
"hash" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22256",
"triggerID" : "f14de3c2fc1ead874f9054886fe95e0a38d95104",
"triggerType" : "PUSH"
}, {
"hash" : "d8a71a9a7918e6eb4fa6292d3f28b554edab0b66",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d8a71a9a7918e6eb4fa6292d3f28b554edab0b66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f14de3c2fc1ead874f9054886fe95e0a38d95104 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22256)
* d8a71a9a7918e6eb4fa6292d3f28b554edab0b66 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16807: [FLINK-21867][runtime-web] Expose concurrent exceptions in Web UI.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16807:
URL: https://github.com/apache/flink/pull/16807#issuecomment-898327352
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c7d2890cfde8e0f051c8aceac177c520bbf7b2c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7d2890cfde8e0f051c8aceac177c520bbf7b2c4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org