You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/28 07:30:20 UTC
[GitHub] [doris] liaoxin01 opened a new pull request, #11289: [feature-wip](unique-key-merge-on-write) update bitmap after compaction, DSIP-018
liaoxin01 opened a new pull request, #11289:
URL: https://github.com/apache/doris/pull/11289
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
see DISP-018: https://cwiki.apache.org/confluence/display/DORIS/DSIP-018%3A+Support+Merge-On-Write+implementation+for+UNIQUE+KEY+data+model
This patch is for step 4-2
## Checklist(Required)
1. Type of your changes:
- [ ] Improvement
- [ ] Fix
- [ ] Feature-WIP
- [ ] Feature
- [ ] Doc
- [ ] Refator
- [ ] Others:
2. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11289: [feature-wip](unique-key-merge-on-write) update bitmap after compaction, DSIP-018
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11289:
URL: https://github.com/apache/doris/pull/11289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liaoxin01 commented on a diff in pull request #11289: [feature-wip](unique-key-merge-on-write) update bitmap after compaction, DSIP-018
Posted by GitBox <gi...@apache.org>.
liaoxin01 commented on code in PR #11289:
URL: https://github.com/apache/doris/pull/11289#discussion_r932187033
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -734,6 +734,45 @@ Status TabletMeta::set_partition_id(int64_t partition_id) {
return Status::OK();
}
+// update dst rowset delete bitmap for unique key merge on write table.
+// we take a delete bitmap's snapshot of origin rowset, but the
Review Comment:
fixed
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -734,6 +734,45 @@ Status TabletMeta::set_partition_id(int64_t partition_id) {
return Status::OK();
}
+// update dst rowset delete bitmap for unique key merge on write table.
+// we take a delete bitmap's snapshot of origin rowset, but the
+// detele bitmap of origin rowset may update when compaction.
+// some key deleted on compaction will exist in dst rowset.
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #11289: [feature-wip](unique-key-merge-on-write) update bitmap after compaction, DSIP-018
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #11289:
URL: https://github.com/apache/doris/pull/11289#discussion_r932206948
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -734,6 +736,46 @@ Status TabletMeta::set_partition_id(int64_t partition_id) {
return Status::OK();
}
+// update dst rowset delete bitmap for unique key merge on write table.
+// we take a delete bitmap's snapshot of origin rowset at the beginning
Review Comment:
改完后又看了一遍，有点啰嗦，精简了一下😂
We take a delete bitmap's snapshot of origin rowset at the beginning of compaction, some keys of origin rowsets might be deleted during compaction, but exist in dest rowset. so we need to update the bitmap of dest rowset after compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] liaoxin01 commented on a diff in pull request #11289: [feature-wip](unique-key-merge-on-write) update bitmap after compaction, DSIP-018
Posted by GitBox <gi...@apache.org>.
liaoxin01 commented on code in PR #11289:
URL: https://github.com/apache/doris/pull/11289#discussion_r932217125
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -734,6 +736,46 @@ Status TabletMeta::set_partition_id(int64_t partition_id) {
return Status::OK();
}
+// update dst rowset delete bitmap for unique key merge on write table.
+// we take a delete bitmap's snapshot of origin rowset at the beginning
Review Comment:
Good suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11289: [feature-wip](unique-key-merge-on-write) update bitmap after compaction, DSIP-018
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11289:
URL: https://github.com/apache/doris/pull/11289#issuecomment-1197964878
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #11289: [feature-wip](unique-key-merge-on-write) update bitmap after compaction, DSIP-018
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #11289:
URL: https://github.com/apache/doris/pull/11289#discussion_r932107099
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -734,6 +734,45 @@ Status TabletMeta::set_partition_id(int64_t partition_id) {
return Status::OK();
}
+// update dst rowset delete bitmap for unique key merge on write table.
+// we take a delete bitmap's snapshot of origin rowset, but the
Review Comment:
we take a delete bitmap's snapshot of origin rowset at the beginning of compaction
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -734,6 +734,45 @@ Status TabletMeta::set_partition_id(int64_t partition_id) {
return Status::OK();
}
+// update dst rowset delete bitmap for unique key merge on write table.
+// we take a delete bitmap's snapshot of origin rowset, but the
+// detele bitmap of origin rowset may update when compaction.
+// some key deleted on compaction will exist in dst rowset.
Review Comment:
some key might be deleted during compaction, which would exist in dst rowset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11289: [feature-wip](unique-key-merge-on-write) update bitmap after compaction, DSIP-018
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11289:
URL: https://github.com/apache/doris/pull/11289#issuecomment-1200073139
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11289: [feature-wip](unique-key-merge-on-write) update bitmap after compaction, DSIP-018
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11289:
URL: https://github.com/apache/doris/pull/11289#issuecomment-1197964964
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org