You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "TaoZex (via GitHub)" <gi...@apache.org> on 2023/06/03 15:33:00 UTC
[GitHub] [iceberg] TaoZex opened a new pull request, #7761: Docs: Fix URL link in flink-getting-started
TaoZex opened a new pull request, #7761:
URL: https://github.com/apache/iceberg/pull/7761
Fix URL link in flink-getting-started
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] TaoZex commented on pull request #7761: Docs: Fix flink docs format
Posted by "TaoZex (via GitHub)" <gi...@apache.org>.
TaoZex commented on PR #7761:
URL: https://github.com/apache/iceberg/pull/7761#issuecomment-1587194702
@hililiwei @stevenzwu @Fokko @nastra @rdblue Hello, I am a contributor to iceberg for the first time. Could you please help me review it? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra merged pull request #7761: Docs: Fix SQL formatting in Flink docs
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #7761:
URL: https://github.com/apache/iceberg/pull/7761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] TaoZex commented on a diff in pull request #7761: Docs: Fix flink docs format
Posted by "TaoZex (via GitHub)" <gi...@apache.org>.
TaoZex commented on code in PR #7761:
URL: https://github.com/apache/iceberg/pull/7761#discussion_r1228324407
##########
docs/flink-getting-started.md:
##########
@@ -399,4 +399,4 @@ There are some features that are do not yet supported in the current Flink Icebe
* Don't support creating iceberg table with computed column.
* Don't support creating iceberg table with watermark.
* Don't support adding columns, removing columns, renaming columns, changing columns. [FLINK-19062](https://issues.apache.org/jira/browse/FLINK-19062) is tracking this.
-*
\ No newline at end of file
+*
Review Comment:
Thanks for your suggestion, I have revert that file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #7761: Docs: Fix SQL formatting in Flink docs
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #7761:
URL: https://github.com/apache/iceberg/pull/7761#issuecomment-1589651373
thanks @TaoZex for your contribution and welcome to the Iceberg community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #7761: Docs: Fix flink docs format
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #7761:
URL: https://github.com/apache/iceberg/pull/7761#discussion_r1227639868
##########
docs/flink-getting-started.md:
##########
@@ -399,4 +399,4 @@ There are some features that are do not yet supported in the current Flink Icebe
* Don't support creating iceberg table with computed column.
* Don't support creating iceberg table with watermark.
* Don't support adding columns, removing columns, renaming columns, changing columns. [FLINK-19062](https://issues.apache.org/jira/browse/FLINK-19062) is tracking this.
-*
\ No newline at end of file
+*
Review Comment:
nit: probably better to revert changes to this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] TaoZex commented on pull request #7761: Docs: Fix flink docs format
Posted by "TaoZex (via GitHub)" <gi...@apache.org>.
TaoZex commented on PR #7761:
URL: https://github.com/apache/iceberg/pull/7761#issuecomment-1576567395
@stevenzwu @hililiwei Hello, I am a contributor to iceberg for the first time. Could you please help me review the code? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #7761: Docs: Fix flink docs format
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #7761:
URL: https://github.com/apache/iceberg/pull/7761#discussion_r1226871773
##########
docs/flink-getting-started.md:
##########
@@ -77,7 +77,7 @@ export HADOOP_CLASSPATH=`$HADOOP_HOME/bin/hadoop classpath`
./bin/start-cluster.sh
```
-Start the Flink SQL client. There is a separate `flink-runtime` module in the Iceberg project to generate a bundled jar, which could be loaded by Flink SQL client directly. To build the `flink-runtime` bundled jar manually, build the `iceberg` project, and it will generate the jar under `<iceberg-root-dir>/flink-runtime/build/libs`. Or download the `flink-runtime` jar from the [Apache repository](https://repo.maven.apache.org/maven2/org/apache/iceberg/iceberg-flink-runtime-1.16/{{% icebergVersion %}}/).
+Start the Flink SQL client. There is a separate `flink-runtime` module in the Iceberg project to generate a bundled jar, which could be loaded by Flink SQL client directly. To build the `flink-runtime` bundled jar manually, build the `iceberg` project, and it will generate the jar under `<iceberg-root-dir>/flink-runtime/build/libs`. Or download the `flink-runtime` jar from the [Apache repository] (https://repo.maven.apache.org/maven2/org/apache/iceberg/iceberg-flink-runtime-1.16/{{%icebergVersion%}}/).
Review Comment:
The link in https://iceberg.apache.org/docs/latest/flink/ works fine for me. Note that the markdown files are being served by [Hugo](https://gohugo.io/) so the original link here was correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org