[jira] Closed: (STR-2554) Collection of fixes to address Checkstyle complaints

["Henri Yandell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/struts/browse/STR-2554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed STR-2554.
------------------------------

    Resolution: Fixed

This looks dated and closeable now. Some improvement was made, but I imagine more could be made.

As a side opinion, Checkstyle patches tend to touch a lot of the source and quickly go out of date. 

> Collection of fixes to address Checkstyle complaints
> ----------------------------------------------------
>
>                 Key: STR-2554
>                 URL: https://issues.apache.org/struts/browse/STR-2554
>             Project: Struts 1
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: 1.3.0
>         Environment: Operating System: All
> Platform: All
>            Reporter: Frank W. Zammetti
>            Priority: Minor
>         Attachments: csfixes1.patch, package_html files.zip, ValidWhenParserTokenTypes.diff
>
>
> This deasl only with core...
> Attached is a rather large patch to resolve a good number of Checkstyle 
> complaints (1,462 resolved).  Also attached is a zip archive containing the 
> source directory structure with just package.html files... I couldn't figure 
> out how to make the patch include new files, and I also frankly didn't recall 
> which files I added, so the existing ones are simply overwritten, they are 
> identical though.
> Here is a rundown of what was resolved... note that no functional code changes 
> were made, and the only actual code that was changed was to resolve some of 
> the lines that were longer than 80 characters...
> Based on TRUNK source code as of 12:00pm EST on 8/22/2005:
> Total Checkstyle complaints (using existing ruleset): 4,760
> * Added package.html to packages that were missing them.  I tried to write
>   a small yet reasonable description in each, but I'd appreciate anyone
>   that can checking them and/or expanding on them as appropriate.
>   Complaints resolved: 12.
>   
> * Converted tabs to spaces in all source files where that applied.  
>   Complaints resolved: 1054.
> * Added a newline at the end of all source files that didn't have one.
>   This required converting a number of files from Unix/MAC format to DOS 
>   since Checkstyle apparently didn't recognize the newline for those files.
>   Only a couple, and I believe they were all in the chain package or
>   sub-package thereof.
>   Complaints resolved: 17.
>   
> * Removed unused imports.
>   Complaints resolved: 15.
>  
> * Moved brackets to resolve "Array brackets at illegal position"
>   complaints.
>   Complaints resolved: 46.
>   
> * Fixed all "Unclosed HTML tag found" complaints.
>   Complaints resolved: 11.
>   
> * Fixed all "; is not followed by whitespace" complaints.
>   Complaints resolved: 62.
>   
> * Fixed all "- is not preceded with whitespace".
>   Complaints resolved: 18.
>   
> * Fixed all "== is not preceded with whitespace".
>   Complaints resolved: 49.
> * Line lengths greater than 80 characters.  These were the only actual
>   code changes, and it was just breaking lines up, no code was
>   FUNCTIONALLY changed, by this bullet point or any other.  There was a
>   total of 671 of these, 493 remain.
>   Complaints resolved: 178.
> Checkstyle complaints remaining after above patches applied: 3,298.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.