You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/03/20 21:00:38 UTC

Review Request 32328: Unit test failure in test_daemonize_and_stop

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32328/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-10148
    https://issues.apache.org/jira/browse/AMBARI-10148


Repository: ambari


Description
-------

Fixed Agent code. Fixed mocks in TestMain.py.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/main.py 23f575b6d68f0998d020c47480156fd82e636f11 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 23d532ab783eef344fc31f8592685f813c1d3d5f 

Diff: https://reviews.apache.org/r/32328/diff/


Testing
-------

mvn clean test

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ........................................ SUCCESS [  4.935 s]
[INFO] Apache Ambari Project POM .......................... SUCCESS [  0.063 s]
[INFO] Ambari Web ......................................... SUCCESS [ 36.025 s]
[INFO] Ambari Views ....................................... SUCCESS [  2.403 s]
[INFO] Ambari Admin View .................................. SUCCESS [ 10.285 s]
[INFO] Ambari Metrics Common .............................. SUCCESS [  1.747 s]
[INFO] Ambari Server ...................................... SUCCESS [01:47 min]
[INFO] Ambari Agent ....................................... SUCCESS [ 21.046 s]
[INFO] Ambari Client ...................................... SUCCESS [  0.054 s]
[INFO] Ambari Python Client ............................... SUCCESS [  1.454 s]
[INFO] Ambari Groovy Client ............................... SUCCESS [  9.403 s]
[INFO] Ambari Shell ....................................... SUCCESS [  0.041 s]
[INFO] Ambari Python Shell ................................ SUCCESS [  0.854 s]
[INFO] Ambari Groovy Shell ................................ SUCCESS [  7.466 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:23 min
[INFO] Finished at: 2015-03-20T12:53:31-07:00
[INFO] Final Memory: 69M/430M
[INFO] ------------------------------------------------------------------------


Ambari Agent:
----------------------------------------------------------------------
Ran 293 tests in 15.810s

OK


Thanks,

Florian Barca


Re: Review Request 32328: Unit test failure in test_daemonize_and_stop

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32328/#review77263
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On March 20, 2015, 8 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32328/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 8 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-10148
>     https://issues.apache.org/jira/browse/AMBARI-10148
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed Agent code. Fixed mocks in TestMain.py.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/main.py 23f575b6d68f0998d020c47480156fd82e636f11 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 23d532ab783eef344fc31f8592685f813c1d3d5f 
> 
> Diff: https://reviews.apache.org/r/32328/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [  4.935 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [  0.063 s]
> [INFO] Ambari Web ......................................... SUCCESS [ 36.025 s]
> [INFO] Ambari Views ....................................... SUCCESS [  2.403 s]
> [INFO] Ambari Admin View .................................. SUCCESS [ 10.285 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [  1.747 s]
> [INFO] Ambari Server ...................................... SUCCESS [01:47 min]
> [INFO] Ambari Agent ....................................... SUCCESS [ 21.046 s]
> [INFO] Ambari Client ...................................... SUCCESS [  0.054 s]
> [INFO] Ambari Python Client ............................... SUCCESS [  1.454 s]
> [INFO] Ambari Groovy Client ............................... SUCCESS [  9.403 s]
> [INFO] Ambari Shell ....................................... SUCCESS [  0.041 s]
> [INFO] Ambari Python Shell ................................ SUCCESS [  0.854 s]
> [INFO] Ambari Groovy Shell ................................ SUCCESS [  7.466 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:23 min
> [INFO] Finished at: 2015-03-20T12:53:31-07:00
> [INFO] Final Memory: 69M/430M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Ambari Agent:
> ----------------------------------------------------------------------
> Ran 293 tests in 15.810s
> 
> OK
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 32328: Unit test failure in test_daemonize_and_stop

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32328/#review77264
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On March 20, 2015, 4 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32328/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 4 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-10148
>     https://issues.apache.org/jira/browse/AMBARI-10148
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed Agent code. Fixed mocks in TestMain.py.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/main.py 23f575b6d68f0998d020c47480156fd82e636f11 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 23d532ab783eef344fc31f8592685f813c1d3d5f 
> 
> Diff: https://reviews.apache.org/r/32328/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [  4.935 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [  0.063 s]
> [INFO] Ambari Web ......................................... SUCCESS [ 36.025 s]
> [INFO] Ambari Views ....................................... SUCCESS [  2.403 s]
> [INFO] Ambari Admin View .................................. SUCCESS [ 10.285 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [  1.747 s]
> [INFO] Ambari Server ...................................... SUCCESS [01:47 min]
> [INFO] Ambari Agent ....................................... SUCCESS [ 21.046 s]
> [INFO] Ambari Client ...................................... SUCCESS [  0.054 s]
> [INFO] Ambari Python Client ............................... SUCCESS [  1.454 s]
> [INFO] Ambari Groovy Client ............................... SUCCESS [  9.403 s]
> [INFO] Ambari Shell ....................................... SUCCESS [  0.041 s]
> [INFO] Ambari Python Shell ................................ SUCCESS [  0.854 s]
> [INFO] Ambari Groovy Shell ................................ SUCCESS [  7.466 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:23 min
> [INFO] Finished at: 2015-03-20T12:53:31-07:00
> [INFO] Final Memory: 69M/430M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Ambari Agent:
> ----------------------------------------------------------------------
> Ran 293 tests in 15.810s
> 
> OK
> 
> 
> Thanks,
> 
> Florian Barca
> 
>