You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "liukun4515 (via GitHub)" <gi...@apache.org> on 2023/02/15 00:40:31 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #5241: Update to arrow `33.0.0`

liukun4515 commented on code in PR #5241:
URL: https://github.com/apache/arrow-datafusion/pull/5241#discussion_r1106532690


##########
datafusion/core/tests/sql/functions.rs:
##########
@@ -67,8 +67,8 @@ async fn csv_query_cast_literal() -> Result<()> {
         "+--------------------+----------+",
         "| c12                | Int64(1) |",
         "+--------------------+----------+",
-        "| 0.9294097332465232 | 1        |",
-        "| 0.3114712539863804 | 1        |",
+        "| 0.9294097332465232 | 1.0      |",

Review Comment:
   I am confused about this changes?
   cc @alamb @tustvold 
   As you said in https://github.com/apache/arrow-datafusion/pull/5241/files#r1106342898.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org