You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Tim Armstrong (Jira)" <ji...@apache.org> on 2019/09/17 00:16:00 UTC
[jira] [Resolved] (IMPALA-2119) Clean up destructors and the
fragment/query Close() path
[ https://issues.apache.org/jira/browse/IMPALA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong resolved IMPALA-2119.
-----------------------------------
Resolution: Fixed
I think this cleanup has largely been completed.
> Clean up destructors and the fragment/query Close() path
> --------------------------------------------------------
>
> Key: IMPALA-2119
> URL: https://issues.apache.org/jira/browse/IMPALA-2119
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 2.2
> Reporter: Matthew Jacobs
> Assignee: Marcel Kornacker
> Priority: Minor
> Labels: query-lifecycle
>
> We need to make sure that there is a sane query and fragment Close() path on the query and fragments, i.e. we shouldn't be relying on destructors, shared/scoped_ptrs. The worst offenders are the coordinator and fragment management classes, e.g. PlanFragmentExecutor, FragmentExecState, QueryExecState, Coordinator. At the same time, we should make sure that all ExecNodes, sinks, and other backend classes used for query execution have all cleanup logic in Close() methods. In some cases, Close() methods will need to be added.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org