[GitHub] [hbase] anoopsjohn commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend

[GitBox <gi...@apache.org>]

anoopsjohn commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#discussion_r309034191
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKeyImpl.java
 ##########
 @@ -195,6 +195,42 @@ public WALKeyImpl(final byte[] encodedRegionName,
         mvcc, null, null);
   }
 
+  /**
+   * Copy constructor that takes in an existing WALKeyImpl plus some extended attributes.
+   * Intended for coprocessors to add annotations to a system-generated WALKey
+   * for persistence to the WAL.
+   * @param key
+   * @param extendedAttributes
+   */
+  public WALKeyImpl(WALKeyImpl key,
 
 Review comment:
   Instead of CP creating a new WALKey object, we can give API to add the ext attributes? It allows to add any custom key value pair so that later CPs or Replication EPs an make use.  So we might not even allow the CP to return a brand new WALKey object. (?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services