You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/11 05:50:53 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2314: [KYUUBI #2289] Use unique tag to kill applications

pan3793 commented on code in PR #2314:
URL: https://github.com/apache/incubator-kyuubi/pull/2314#discussion_r846965876


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala:
##########
@@ -185,6 +186,12 @@ trait ProcBuilder {
     process
   }
 
+  def killApplicationWrap(engineRefId: String): String =

Review Comment:
   I have an alternative idea for it, change the method signature to `def killApplication(clue: Either[String, String]): String`, WDYT @Nick-0723 @yaooqinn?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org