You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/24 18:09:25 UTC
[GitHub] [arrow] lidavidm opened a new pull request #10597: ARROW-13157: [C++][Python] Implement ignore_case for find_substring
lidavidm opened a new pull request #10597:
URL: https://github.com/apache/arrow/pull/10597
RE2 only returns the match position if you have a capture group. Hence we have to modify the supplied regex. For literal patterns, we have to use RE2::QuoteMeta instead of setting the literal flag on the regex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10597: ARROW-13157: [C++][Python] Implement ignore_case for find_substring
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10597:
URL: https://github.com/apache/arrow/pull/10597#issuecomment-867849615
https://issues.apache.org/jira/browse/ARROW-13157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10597: ARROW-13157: [C++][Python] Implement ignore_case for find_substring
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10597:
URL: https://github.com/apache/arrow/pull/10597#issuecomment-869014034
Please go ahead! Sorry, once I added ignore_case using RE2, I figured a find_substring_regex was basically no additional effort, but I should've updated the JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #10597: ARROW-13157: [C++][Python] Implement ignore_case for find_substring
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #10597:
URL: https://github.com/apache/arrow/pull/10597#issuecomment-869013891
So this implements a `find_substring_regex` kernel too? Nice. You mind if I adjust the titles and descriptions to make that clear? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #10597: ARROW-13157: [C++][Python] Add find_substring_regex kernel and implement ignore_case for find_substring
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #10597:
URL: https://github.com/apache/arrow/pull/10597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #10597: ARROW-13157: [C++][Python] Add find_substring_regex kernel and implement ignore_case for find_substring
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #10597:
URL: https://github.com/apache/arrow/pull/10597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org