[GitHub] [cxf] reta commented on a diff in pull request #978: Fix Content ID and attachment ID equality check

[GitBox <gi...@apache.org>]

reta commented on code in PR #978:
URL: https://github.com/apache/cxf/pull/978#discussion_r955474748


##########
core/src/main/java/org/apache/cxf/attachment/LazyDataSource.java:
##########
@@ -47,7 +50,13 @@ public LazyDataSource(String id, Collection<Attachment> attachments) {
     private synchronized void load() {
         if (dataSource == null) {
             for (Attachment a : attachments) {
-                if (a.getId().equals(id)) {
+                String attachmentId = a.getId();

Review Comment:
   @atnyxp thanks for highlighting the issue, I think we should not pursue this route and fix the encoding issue (so `attachmentId` would match `id`), I will be looking into it shortly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org