You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by slachiewicz <gi...@git.apache.org> on 2015/10/31 08:45:05 UTC
[GitHub] spark pull request: Update Netty's call to PooledByteBufAllocator
GitHub user slachiewicz opened a pull request:
https://github.com/apache/spark/pull/9389
Update Netty's call to PooledByteBufAllocator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/slachiewicz/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9389.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9389
----
commit f120f538e31759e2ada2eeb12a3f5163b0380344
Author: Sylwester Lachiewicz <sl...@gmail.com>
Date: 2015-10-31T07:44:01Z
Update Netty's call to PooledByteBufAllocator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Update Netty's call to PooledByteBufAllocator
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9389#issuecomment-152722064
Yeah, that doesn't even compile. Do you mind closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Update Netty's call to PooledByteBufAllocator
Posted by slachiewicz <gi...@git.apache.org>.
Github user slachiewicz closed the pull request at:
https://github.com/apache/spark/pull/9389
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Update Netty's call to PooledByteBufAllocator
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9389#issuecomment-153208265
Ping @slachiewicz, do you mind either addressing Sean's comments or closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Update Netty's call to PooledByteBufAllocator
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9389#issuecomment-152721806
@slachiewicz this isn't quite how you propose changes; see https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
It also calls into question compatibility? does this require a certain version of netty?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Update Netty's call to PooledByteBufAllocator
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9389#issuecomment-152721990
**[Test build #1965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1965/consoleFull)** for PR 9389 at commit [`f120f53`](https://github.com/apache/spark/commit/f120f538e31759e2ada2eeb12a3f5163b0380344).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Update Netty's call to PooledByteBufAllocator
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9389#issuecomment-152709038
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Update Netty's call to PooledByteBufAllocator
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9389#issuecomment-152721877
**[Test build #1965 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1965/consoleFull)** for PR 9389 at commit [`f120f53`](https://github.com/apache/spark/commit/f120f538e31759e2ada2eeb12a3f5163b0380344).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org