You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by se...@apache.org on 2018/09/24 21:56:53 UTC
[flink] 05/05: [hotfix] [runtime] Clean up some checkstyle
violations
This is an automated email from the ASF dual-hosted git repository.
sewen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit e0ab834ddf15a564034f3ecc6f981b29089b5ee4
Author: Stephan Ewen <se...@apache.org>
AuthorDate: Mon Sep 24 20:52:50 2018 +0200
[hotfix] [runtime] Clean up some checkstyle violations
---
.../state/filesystem/FsCheckpointStreamFactory.java | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java b/flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java
index 665e7b3..8253606 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java
@@ -66,13 +66,13 @@ public class FsCheckpointStreamFactory implements CheckpointStreamFactory {
private static final Logger LOG = LoggerFactory.getLogger(FsCheckpointStreamFactory.class);
- /** Maximum size of state that is stored with the metadata, rather than in files */
+ /** Maximum size of state that is stored with the metadata, rather than in files. */
public static final int MAX_FILE_STATE_THRESHOLD = 1024 * 1024;
- /** Default size for the write buffer */
+ /** Default size for the write buffer. */
public static final int DEFAULT_WRITE_BUFFER_SIZE = 4096;
- /** State below this size will be stored as part of the metadata, rather than in files */
+ /** State below this size will be stored as part of the metadata, rather than in files. */
private final int fileStateThreshold;
/** The directory for checkpoint exclusive state data. */
@@ -121,9 +121,7 @@ public class FsCheckpointStreamFactory implements CheckpointStreamFactory {
@Override
public FsCheckpointStateOutputStream createCheckpointStateOutputStream(CheckpointedStateScope scope) throws IOException {
-
-
- Path target = scope == CheckpointedStateScope.EXCLUSIVE ?checkpointDirectory: sharedStateDirectory;
+ Path target = scope == CheckpointedStateScope.EXCLUSIVE ? checkpointDirectory : sharedStateDirectory;
int bufferSize = Math.max(DEFAULT_WRITE_BUFFER_SIZE, fileStateThreshold);
return new FsCheckpointStateOutputStream(target, filesystem, bufferSize, fileStateThreshold);
@@ -154,7 +152,7 @@ public class FsCheckpointStreamFactory implements CheckpointStreamFactory {
private int pos;
private FSDataOutputStream outStream;
-
+
private final int localStateThreshold;
private final Path basePath;
@@ -167,8 +165,8 @@ public class FsCheckpointStreamFactory implements CheckpointStreamFactory {
public FsCheckpointStateOutputStream(
Path basePath, FileSystem fs,
- int bufferSize, int localStateThreshold)
- {
+ int bufferSize, int localStateThreshold) {
+
if (bufferSize < localStateThreshold) {
throw new IllegalArgumentException();
}
@@ -202,7 +200,7 @@ public class FsCheckpointStreamFactory implements CheckpointStreamFactory {
// flush the write buffer to make it clear again
flush();
}
-
+
// copy what is in the buffer
System.arraycopy(b, off, writeBuffer, pos, len);
pos += len;
@@ -303,7 +301,7 @@ public class FsCheckpointStreamFactory implements CheckpointStreamFactory {
flush();
pos = writeBuffer.length;
-
+
long size = -1L;
// make a best effort attempt to figure out the size