[GitHub] [guacamole-client] knacktim commented on a change in pull request #346: GUACAMOLE-680: Rearrange logout handling

[GitBox <gi...@apache.org>]

knacktim commented on a change in pull request #346:
URL: https://github.com/apache/guacamole-client/pull/346#discussion_r517596633



##########
File path: guacamole/src/main/webapp/app/auth/service/authenticationService.js
##########
@@ -290,13 +290,20 @@ angular.module('auth').factory('authenticationService', ['$injector',
         var token = service.getCurrentToken();
         clearAuthenticationResult();
 
-        // Notify listeners that a token is being destroyed
-        $rootScope.$broadcast('guacLogout', token);
+        // Notify listeners that a token is about to be destroyed
+        $rootScope.$broadcast('beforeGuacLogout', token);

Review comment:
       Is there an alternative solution where we have an angular service that components can 'register' handlers in the service.  When someone fires an event through the service it can return a promise that only fires after each handler has been called.
   
   I have been searching for any AngularJS mechanism built in that would accomplish basically 'guaranteed delivery' and I can't find one.  Should be very minimalistic for me to cook this service up if the idea has merit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org