You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/12/10 21:44:57 UTC

[GitHub] [mynewt-core] kasjer commented on a change in pull request #2106: PR for 3 changes : NDEBUG build, fix SPI on STM32, bitbang uart tx only

kasjer commented on a change in pull request #2106: PR for 3 changes : NDEBUG build, fix SPI on STM32, bitbang uart tx only
URL: https://github.com/apache/mynewt-core/pull/2106#discussion_r356281677
 
 

 ##########
 File path: hw/mcu/stm/stm32_common/src/hal_spi.c
 ##########
 @@ -172,6 +172,7 @@ stm32_resolve_spi_irq(SPI_HandleTypeDef *hspi)
 #endif
     default:
         assert(0);
+        return 0;
 
 Review comment:
   returning 0 here, would lead to unpredictable behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services