You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by GitBox <gi...@apache.org> on 2022/01/13 16:26:45 UTC
[GitHub] [struts] yasserzamani commented on a change in pull request #525: [WW-5117] Evaluates dynamic attributes - cherrypick
yasserzamani commented on a change in pull request #525:
URL: https://github.com/apache/struts/pull/525#discussion_r784120966
##########
File path: core/src/test/java/org/apache/struts2/views/jsp/ui/TextfieldTest.java
##########
@@ -372,7 +372,7 @@ public void testSimple_recursionTest_clearTagStateSet() throws Exception {
tag.setName("myname");
tag.setValue("%{foo}");
tag.setSize("10");
- tag.setDynamicAttribute(null, "anotherAttr", "%{foo}");
+ tag.setDynamicAttribute(null, "anotherAttr", "another_%{foo}");
Review comment:
(same here)
##########
File path: core/src/test/resources/org/apache/struts2/views/jsp/ui/Textfield-5.txt
##########
@@ -1,4 +1,4 @@
<tr>
<td class="tdLabel"><label for="myname" class="label">mylabel:</label></td>
- <td class="tdInput"><input type="text" name="myname" size="10" value="%{1+1}" id="myname" anotherAttr="%{1+1}"/></td>
+ <td class="tdInput"><input type="text" name="myname" size="10" value="%{1+1}" id="myname" anotherAttr="another_%{1+1}"/></td>
Review comment:
(same here)
##########
File path: core/src/test/java/org/apache/struts2/views/jsp/ui/TextfieldTest.java
##########
@@ -346,7 +346,7 @@ public void testSimple_recursionTest() throws Exception {
tag.setName("myname");
tag.setValue("%{foo}");
tag.setSize("10");
- tag.setDynamicAttribute(null, "anotherAttr", "%{foo}");
+ tag.setDynamicAttribute(null, "anotherAttr", "another_%{foo}");
Review comment:
That's intentional by me to start value with %{ to always have a monitor and test for double evaluation. This change eliminate that I think. Why had you to change it? to pass that test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org