You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2023/01/09 17:19:20 UTC

[GitHub] [opennlp] atarora commented on a diff in pull request #485: OPENNLP-1135 : Removed support for OSGi

atarora commented on code in PR #485:
URL: https://github.com/apache/opennlp/pull/485#discussion_r1064885393


##########
opennlp-tools/src/main/java/opennlp/tools/util/ext/ExtensionServiceKeys.java:
##########
@@ -17,11 +17,11 @@
 
 package opennlp.tools.util.ext;
 
-public final class ExtensionServiceKeys {
+public class ExtensionServiceKeys {

Review Comment:
   Thank you for review and comments!
   It looks like the 'final' was part of recent change which is honestly missed as part of merge (not intentional).
   I can happily add it back in :) if required , although as per my previous comment I wasn't even too sure if this class is needed anymore.
   Commit to follow!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org