You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/12/10 07:27:03 UTC
[jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Originally reported at:
http://stackoverflow.com/questions/20485579/expiring-swift-objects-with-jclouds
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds swift-expires
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/227
-- Commit Summary --
* Map BlobBuilder.expires to Swift X-Delete-At
-- File Changes --
M apis/swift/src/main/java/org/jclouds/openstack/swift/binders/BindSwiftObjectMetadataToRequest.java (9)
M apis/swift/src/test/java/org/jclouds/openstack/swift/binders/BindSwiftObjectMetadataToRequestTest.java (4)
M apis/swift/src/test/java/org/jclouds/openstack/swift/blobstore/SwiftBlobSignerExpectTest.java (4)
M apis/swift/src/test/java/org/jclouds/openstack/swift/blobstore/SwiftKeystoneBlobSignerExpectTest.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/227.patch
https://github.com/jclouds/jclouds/pull/227.diff
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #682](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/682/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30204464
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #927](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/927/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30373191
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by Andrew Phillips <no...@github.com>.
+1 - looks good to me. Thanks, @andrewgaul!
Has this been run against any live cloud so far, by the way?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30367992
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #465](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/465/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30372602
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #453](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/453/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30208031
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by Andrew Phillips <no...@github.com>.
> @@ -72,6 +73,14 @@ public BindSwiftObjectMetadataToRequest(ObjectToBlob object2Blob, BindUserMetada
> .build();
> }
>
> + Date expires = object.getPayload().getContentMetadata().getExpires();
> + if (expires != null) {
> + // Swizzle Expires to X-Delete-At
> + request = (R) request.toBuilder()
> + .addHeader("X-Delete-At", String.valueOf(expires.getTime() / 1000))
It may be a little slower, but would [`MILLISECONDS.toSeconds(expires.getTime())`](http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/TimeUnit.html) read slightly more clearly here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227/files#r8275008
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by Andrew Phillips <no...@github.com>.
> @@ -67,6 +70,7 @@ public void testExtendedPropertiesBind() {
> BindSwiftObjectMetadataToRequest binder = injector.getInstance(BindSwiftObjectMetadataToRequest.class);
>
> assertEquals(binder.bindToRequest(request, object), HttpRequest.builder().method("PUT")
> + .addHeader("X-Delete-At", String.valueOf(expiresMillis / 1000))
See above comment
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227/files#r8275055
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #452](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/452/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30204816
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by Andrew Phillips <no...@github.com>.
JIRA issue for this? And will close'n'reopen to see what the PR builders say this time...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30343973
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #915](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/915/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30207846
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by Andrew Gaul <no...@github.com>.
Integration tests pass against cloudfiles-us. We probably need a higher-level expiry live test although this will require some more investigation to see where other providers are at. Pushed to master.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30370370
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #926](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/926/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30350394
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by Andrew Gaul <no...@github.com>.
> @@ -67,6 +70,7 @@ public void testExtendedPropertiesBind() {
> BindSwiftObjectMetadataToRequest binder = injector.getInstance(BindSwiftObjectMetadataToRequest.class);
>
> assertEquals(binder.bindToRequest(request, object), HttpRequest.builder().method("PUT")
> + .addHeader("X-Delete-At", String.valueOf(expiresMillis / 1000))
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227/files#r8282727
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by Andrew Gaul <no...@github.com>.
> @@ -72,6 +73,14 @@ public BindSwiftObjectMetadataToRequest(ObjectToBlob object2Blob, BindUserMetada
> .build();
> }
>
> + Date expires = object.getPayload().getContentMetadata().getExpires();
> + if (expires != null) {
> + // Swizzle Expires to X-Delete-At
> + request = (R) request.toBuilder()
> + .addHeader("X-Delete-At", String.valueOf(expires.getTime() / 1000))
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227/files#r8282725
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #914](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/914/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30204939
Re: [jclouds] Map BlobBuilder.expires to Swift X-Delete-At (#227)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #464](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/464/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/227#issuecomment-30349749