[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5417: Updated https status code when updating CDN for a DS

[GitBox <gi...@apache.org>]

mitchell852 commented on a change in pull request #5417:
URL: https://github.com/apache/trafficcontrol/pull/5417#discussion_r556057684



##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
##########
@@ -1018,7 +1018,7 @@ func updateV31(w http.ResponseWriter, r *http.Request, inf *api.APIInfo, dsV31 *
 	}
 
 	if newDSType.HasSSLKeys() && (oldHostName != newHostName || oldCDNName != newCDNName || oldRoutingName != *ds.RoutingName) {
-		return nil, http.StatusForbidden, nil, errors.New("delivery service has ssl keys that cannot be automatically changed")
+		return nil, http.StatusBadRequest, errors.New("delivery service CDN is immutable"), errors.New("delivery service has ssl keys that cannot be automatically changed")

Review comment:
       is this supposed to return 2 errors? because i'm only seeing one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org