You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by xu...@apache.org on 2011/07/08 15:24:13 UTC

svn commit: r1144307 [1/3] - in /geronimo/server/trunk: framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/ framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/uti...

Author: xuhaihong
Date: Fri Jul  8 13:24:09 2011
New Revision: 1144307

URL: http://svn.apache.org/viewvc?rev=1144307&view=rev
Log:
GERONIMO-6058 Replace StringBuffer usage with StringBuilder

Modified:
    geronimo/server/trunk/framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/DisplayManifestMojo.java
    geronimo/server/trunk/framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/utils/BundleResolver.java
    geronimo/server/trunk/framework/buildsupport/geronimo-property-plugin/src/main/java/org/apache/geronimo/mavenplugins/property/SetPropertyMojo.java
    geronimo/server/trunk/framework/buildsupport/testsuite-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/testsuite/report/ReportTestSuite.java
    geronimo/server/trunk/framework/buildsupport/testsuite-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/testsuite/report/SurefireReportGenerator.java
    geronimo/server/trunk/framework/modules/geronimo-bundle-recorder/src/main/java/org/apache/geronimo/system/bundle/BundleRecorderGBean.java
    geronimo/server/trunk/framework/modules/geronimo-cli/src/main/java/org/apache/geronimo/cli/PrintHelper.java
    geronimo/server/trunk/framework/modules/geronimo-common/src/main/java/org/apache/geronimo/common/UnresolvedEJBRefException.java
    geronimo/server/trunk/framework/modules/geronimo-common/src/main/java/org/apache/geronimo/common/propertyeditor/ArrayPropertyEditorAdapter.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/CertificateUtil.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERBitString.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERObjectIdentifier.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERUniversalString.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/util/ASN1Dump.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/x509/X509Name.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/x509/X509NameTokenizer.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JCERSAPrivateCrtKey.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JCERSAPublicKey.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JDKDSAPublicKey.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/X509CRLEntryObject.java
    geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/X509CertificateObject.java
    geronimo/server/trunk/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/local/CommandSupport.java
    geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
    geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/ClassPathUtils.java
    geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/DeploymentContext.java
    geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/util/XMLUtil.java
    geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/xml/LocalEntityResolver.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/AbstractName.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/AbstractNameQuery.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/BasicGBeanInfoFactory.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/GBeanInfo.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/GOperationSignature.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/ClassLoading.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/ConfigurationUtil.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/RecordingLifecycleMonitor.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/Artifact.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/MissingDependencyException.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/Version.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/util/JarUtils.java
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/util/SelectorUtils.java
    geronimo/server/trunk/framework/modules/geronimo-main/src/main/java/org/apache/geronimo/main/FrameworkLauncher.java
    geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java
    geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/naming/reference/AbstractEntryFactory.java
    geronimo/server/trunk/framework/modules/geronimo-obr/src/main/java/org/apache/geronimo/obr/ResourceBuilder.java
    geronimo/server/trunk/framework/modules/geronimo-pax-logging/src/main/java/org/apache/geronimo/logging/impl/Log4jService.java
    geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java
    geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/ReferenceServerInstanceData.java
    geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/RemoteSourceRepository.java
    geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/ServerInstanceData.java
    geronimo/server/trunk/framework/modules/geronimo-rmi-loader/src/main/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImpl.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/DomainPrincipal.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/IdentificationPrincipal.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/RealmPrincipal.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/SubjectId.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/deploy/MapOfSets.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/keystore/FileKeystoreInstance.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainCallbackHandler.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/GenericHttpHeaderLdapLoginModule.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SpnegoLoginModule.java
    geronimo/server/trunk/framework/modules/geronimo-service-builder/src/main/java/org/apache/geronimo/deployment/dconfigbean/DConfigBeanSupport.java
    geronimo/server/trunk/framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/BaseCommandSupport.java
    geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/GBeanOverride.java
    geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
    geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/jmx/KernelDelegate.java
    geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/ProgressBarStartupMonitor.java
    geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/StartupMonitorUtil.java
    geronimo/server/trunk/framework/modules/testsupport-common/src/main/java/org/apache/geronimo/testsupport/HttpUtils.java
    geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/activemqCF/ActiveMQConnectorHelper.java
    geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/wizard/JMSProviderData.java
    geronimo/server/trunk/plugins/axis/geronimo-axis-builder/src/main/java/org/apache/geronimo/axis/builder/AxisBuilder.java
    geronimo/server/trunk/plugins/axis/geronimo-axis/src/main/java/org/apache/geronimo/axis/server/AxisWebServiceContainer.java
    geronimo/server/trunk/plugins/axis2/geronimo-axis2/src/test/java/org/apache/geronimo/axis2/Axis2WebServiceContainerTest.java
    geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-1_6/src/main/java/org/apache/geronimo/connector/wrapper/DatabaseInitializationGBean.java
    geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/AdminObjectRefBuilder.java
    geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java
    geronimo/server/trunk/plugins/console/console-base-portlets/src/main/java/org/apache/geronimo/console/jsr77/DynamicServerInfo.java
    geronimo/server/trunk/plugins/console/console-core/src/main/java/org/apache/geronimo/console/core/keystore/KeyStoreGBean.java
    geronimo/server/trunk/plugins/console/console-core/src/main/java/org/apache/geronimo/console/util/StringUtils.java
    geronimo/server/trunk/plugins/console/console-filter/src/main/java/org/apache/geronimo/console/filter/XSRFHandler.java
    geronimo/server/trunk/plugins/console/console-portal-driver/src/main/java/org/apache/geronimo/console/navigation/NavigationJsonGenerator.java
    geronimo/server/trunk/plugins/console/geronimo-converter/src/main/java/org/apache/geronimo/converter/DOMUtils.java
    geronimo/server/trunk/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/car/ExportConfigHandler.java
    geronimo/server/trunk/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/car/GeronimoAsMavenServlet.java
    geronimo/server/trunk/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/car/ViewPluginDownloadHandler.java
    geronimo/server/trunk/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/securitymanager/realm/SecurityRealmPortlet.java
    geronimo/server/trunk/plugins/cxf/geronimo-cxf/src/main/java/org/apache/geronimo/cxf/GeronimoDestination.java
    geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/main/java/org/apache/geronimo/console/ldapmanager/LDAPManagerHelper.java
    geronimo/server/trunk/plugins/jaxws/geronimo-jaxws-sun-tools/src/main/java/org/apache/geronimo/jaxws/sun/tools/JAXWSTools.java
    geronimo/server/trunk/plugins/jaxws/geronimo-jaxws/src/main/java/org/apache/geronimo/jaxws/JAXWSUtils.java
    geronimo/server/trunk/plugins/openejb/openejb-portlets/src/main/java/org/apache/geronimo/console/ejbserver/EjbHelper.java
    geronimo/server/trunk/plugins/openjpa2/geronimo-aries-jpa/src/main/java/org/apache/geronimo/aries/jpa/PersistenceBundleHelper.java
    geronimo/server/trunk/plugins/plancreator/plancreator-portlets/src/main/java/org/apache/geronimo/console/configcreator/configData/EARHelper.java
    geronimo/server/trunk/plugins/plancreator/plancreator-portlets/src/main/java/org/apache/geronimo/console/configcreator/configData/EnvironmentConfigData.java
    geronimo/server/trunk/plugins/system-database/sysdb-portlets/src/main/java/org/apache/geronimo/console/databasemanager/wizard/DatabasePoolPortlet.java
    geronimo/server/trunk/plugins/system-database/sysdb-portlets/src/main/java/org/apache/geronimo/console/internaldb/InternalDBHelper.java
    geronimo/server/trunk/plugins/tomcat/geronimo-tomcat7/src/main/java/org/apache/geronimo/tomcat/security/authentication/BasicAuthenticator.java
    geronimo/server/trunk/plugins/uddi/uddi-war-repackage/src/main/java/org/apache/juddi/query/FindEntityByNamesQuery.java
    geronimo/server/trunk/plugins/webservices/geronimo-webservices-builder/src/main/java/org/apache/geronimo/webservices/builder/SchemaTypeKey.java
    geronimo/server/trunk/plugins/webservices/geronimo-webservices-builder/src/main/java/org/apache/geronimo/webservices/builder/WSDescriptorParser.java
    geronimo/server/trunk/testsuite/enterprise-testsuite/appname-tests/appname-client/src/test/java/org/apache/geronimo/testsuite/appname/ClientTest.java
    geronimo/server/trunk/testsuite/enterprise-testsuite/bundle-inject-test/src/main/java/org/apache/geronimo/test/bundleinject/TestBean.java
    geronimo/server/trunk/testsuite/enterprise-testsuite/bundle-inject-test/src/main/java/org/apache/geronimo/test/bundleinject/TestServlet.java
    geronimo/server/trunk/testsuite/enterprise-testsuite/ejb-tests/ejb-ear/src/test/java/org/apache/geronimo/testsuite/enterprise/ejb/EJBTest.java
    geronimo/server/trunk/testsuite/enterprise-testsuite/sec-client-tests/src/test/java/org/apache/geronimo/testsuite/testset/ClientTest.java
    geronimo/server/trunk/testsuite/enterprise-testsuite/sec-tests/sec-ear/src/test/java/org/apache/geronimo/testsuite/security/ClientTest.java
    geronimo/server/trunk/testsuite/javaee6-testsuite/servlet3.0-test/servlet3.0-test-war/src/main/java/org/apache/geronimo/testsuite/servlet3/app/CviewerFilter.java
    geronimo/server/trunk/testsuite/javaee6-testsuite/servlet3.0-test/servlet3.0-test-war/src/main/java/org/apache/geronimo/testsuite/servlet3/app/FileMessageFilter.java
    geronimo/server/trunk/testsuite/security-testsuite/test-security-basic-authentication/src/test/java/org/apache/geronimo/testsuite/security/basic/BasicAuthenticationTest.java
    geronimo/server/trunk/testsuite/web-testsuite/test-jetty/src/test/java/org/apache/geronimo/testsuite/jetty/TestJetty.java
    geronimo/server/trunk/testsuite/web-testsuite/test-tomcat/src/test/java/org/apache/geronimo/testsuite/tomcat/TestTomcat.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxrpc-jaxws-tests/jaxrpc-jaxws-war/src/test/java/org/apache/geronimo/testsuite/testset/WSTest.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxws-catalog-tests/catalog-ear/src/test/java/org/apache/geronimo/jaxws/catalog/WebCatalogTest.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxws-mtom-tests/mtom-ear/src/test/java/org/apache/geronimo/jaxws/mtom/MTOMTest.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxws-provider-tests/provider-ear/src/test/java/org/apache/geronimo/jaxws/provider/ProviderTest.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxws-tests/jaxws-ejb-sec/src/test/java/org/apache/geronimo/testsuite/testset/TestUtils.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxws-tests/jaxws-ejb/src/test/java/org/apache/geronimo/testsuite/testset/JaxWSTest.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxws-tests/jaxws-partial/src/test/java/org/apache/geronimo/testsuite/testset/JaxWSTest.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxws-tests/jaxws-rest-war/src/test/java/org/apache/geronimo/testsuite/testset/JaxWSRestTest.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxws-tests/jaxws-war-sec/src/test/java/org/apache/geronimo/testsuite/testset/TestUtils.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxws-tests/jaxws-war/src/test/java/org/apache/geronimo/testsuite/testset/JaxWSTest.java
    geronimo/server/trunk/testsuite/webservices-testsuite/jaxws-wsa-tests/wsa-ear/src/test/java/org/apache/geronimo/jaxws/wsa/WSATest.java

Modified: geronimo/server/trunk/framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/DisplayManifestMojo.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/DisplayManifestMojo.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/DisplayManifestMojo.java (original)
+++ geronimo/server/trunk/framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/DisplayManifestMojo.java Fri Jul  8 13:24:09 2011
@@ -105,7 +105,7 @@ public class DisplayManifestMojo extends
         if (exportPackages != null && exportPackages.length > 0) {
             System.out.println("Exports:");
             for (ExportPackageDescription exportPackage : exportPackages) {
-                StringBuffer buf = new StringBuffer();
+                StringBuilder buf = new StringBuilder();
                 buf.append(TAB + exportPackage);
                 
                 Map attributes = exportPackage.getAttributes();
@@ -141,7 +141,7 @@ public class DisplayManifestMojo extends
         if (!imports.isEmpty()) {
             System.out.println(header);
             for (ImportPackageSpecification importPackage : imports) {
-                StringBuffer buf = new StringBuffer();
+                StringBuilder buf = new StringBuilder();
                 buf.append(TAB + importPackage);
                 
                 Map attributes = importPackage.getAttributes();

Modified: geronimo/server/trunk/framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/utils/BundleResolver.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/utils/BundleResolver.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/utils/BundleResolver.java (original)
+++ geronimo/server/trunk/framework/buildsupport/geronimo-osgi-plugin/src/main/java/org/apache/geronimo/mavenplugins/osgi/utils/BundleResolver.java Fri Jul  8 13:24:09 2011
@@ -253,7 +253,7 @@ public class BundleResolver {
     }
 
     private void logError(BundleDescription bundle, int level, Object object) {
-        StringBuffer msg = new StringBuffer();
+        StringBuilder msg = new StringBuilder();
         for (int i = 0; i < level; i++) {
             msg.append("--");
         }
@@ -452,7 +452,7 @@ public class BundleResolver {
     }
 
     public String reportErrors(BundleDescription desc) {
-        StringBuffer msg = new StringBuffer();
+        StringBuilder msg = new StringBuilder();
         msg.append("Bundle ").append(desc.getSymbolicName()).append(" cannot be resolved: \n");
         BundleDescription[] bundles = state.getBundles();
         int index = 0;

Modified: geronimo/server/trunk/framework/buildsupport/geronimo-property-plugin/src/main/java/org/apache/geronimo/mavenplugins/property/SetPropertyMojo.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/buildsupport/geronimo-property-plugin/src/main/java/org/apache/geronimo/mavenplugins/property/SetPropertyMojo.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/buildsupport/geronimo-property-plugin/src/main/java/org/apache/geronimo/mavenplugins/property/SetPropertyMojo.java (original)
+++ geronimo/server/trunk/framework/buildsupport/geronimo-property-plugin/src/main/java/org/apache/geronimo/mavenplugins/property/SetPropertyMojo.java Fri Jul  8 13:24:09 2011
@@ -89,7 +89,7 @@ public class SetPropertyMojo extends Abs
     private ArtifactFactory artifactFactory;
         
     public void execute() throws MojoExecutionException, MojoFailureException {
-        StringBuffer buffer = new StringBuffer();
+        StringBuilder buffer = new StringBuilder();
         
         if (classpath != null && classpath.length > 0) {
             if (propertyValuePrefix != null) {

Modified: geronimo/server/trunk/framework/buildsupport/testsuite-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/testsuite/report/ReportTestSuite.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/buildsupport/testsuite-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/testsuite/report/ReportTestSuite.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/buildsupport/testsuite-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/testsuite/report/ReportTestSuite.java (original)
+++ geronimo/server/trunk/framework/buildsupport/testsuite-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/testsuite/report/ReportTestSuite.java Fri Jul  8 13:24:09 2011
@@ -58,9 +58,9 @@ public class ReportTestSuite
     private NumberFormat numberFormat = NumberFormat.getInstance();
 
     /**
-     * @noinspection StringBufferField
+     * @noinspection StringBuilderField
      */
-    private StringBuffer currentElement;
+    private StringBuilder currentElement;
 
     private ReportTestCase testCase;
 
@@ -133,7 +133,7 @@ public class ReportTestSuite
             }
             else if ( "testcase".equals( qName ) )
             {
-                currentElement = new StringBuffer();
+                currentElement = new StringBuilder();
 
                 testCase = new ReportTestCase();
 

Modified: geronimo/server/trunk/framework/buildsupport/testsuite-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/testsuite/report/SurefireReportGenerator.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/buildsupport/testsuite-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/testsuite/report/SurefireReportGenerator.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/buildsupport/testsuite-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/testsuite/report/SurefireReportGenerator.java (original)
+++ geronimo/server/trunk/framework/buildsupport/testsuite-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/testsuite/report/SurefireReportGenerator.java Fri Jul  8 13:24:09 2011
@@ -58,7 +58,7 @@ public class SurefireReportGenerator
 
         sink.text( bundle.getString( "report.surefire.description" ) );
 
-        StringBuffer str = new StringBuffer();
+        StringBuilder str = new StringBuilder();
         str.append( "<script type=\"text/javascript\">\n" );
         str.append( "function toggleDisplay(elementId) {\n" );
         str.append( " var elm = document.getElementById(elementId + 'error');\n" );
@@ -529,7 +529,7 @@ public class SurefireReportGenerator
 
                 sinkCell( sink, "" );
 
-                StringBuffer sb = new StringBuffer();
+                StringBuilder sb = new StringBuilder();
                 sb.append( type );
 
                 if ( message != null )

Modified: geronimo/server/trunk/framework/modules/geronimo-bundle-recorder/src/main/java/org/apache/geronimo/system/bundle/BundleRecorderGBean.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-bundle-recorder/src/main/java/org/apache/geronimo/system/bundle/BundleRecorderGBean.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-bundle-recorder/src/main/java/org/apache/geronimo/system/bundle/BundleRecorderGBean.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-bundle-recorder/src/main/java/org/apache/geronimo/system/bundle/BundleRecorderGBean.java Fri Jul  8 13:24:09 2011
@@ -216,7 +216,7 @@ public class BundleRecorderGBean impleme
     private String getMvnLocationFromArtifact(Artifact artifact){
         if (artifact == null) return null;
         
-        StringBuffer bundleLocation = new StringBuffer();
+        StringBuilder bundleLocation = new StringBuilder();
         bundleLocation.append("mvn:");
         bundleLocation.append(artifact.getGroupId()).append('/').append(artifact.getArtifactId()).append('/').append(artifact.getVersion());
         
@@ -243,7 +243,7 @@ public class BundleRecorderGBean impleme
     private String getRecordKey(Artifact artifact) {
         if (artifact == null) return null;
         
-        StringBuffer recordKey = new StringBuffer();
+        StringBuilder recordKey = new StringBuilder();
         recordKey.append(artifact.getGroupId().replace(".", "/")).append('/').append(artifact.getArtifactId()).append('/').append(artifact.getVersion());
         recordKey.append("/");
         recordKey.append(artifact.getArtifactId() + "-" + artifact.getVersion() + "." + artifact.getType());

Modified: geronimo/server/trunk/framework/modules/geronimo-cli/src/main/java/org/apache/geronimo/cli/PrintHelper.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-cli/src/main/java/org/apache/geronimo/cli/PrintHelper.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-cli/src/main/java/org/apache/geronimo/cli/PrintHelper.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-cli/src/main/java/org/apache/geronimo/cli/PrintHelper.java Fri Jul  8 13:24:09 2011
@@ -50,7 +50,7 @@ public class PrintHelper {
             throw new IllegalArgumentException("Need at least 10 spaces for " +
                 "printing, but indent=" + indent + " and endCol=" + endCol);
         }
-        StringBuffer buf = new StringBuffer((int)(source.length()*1.1));
+        StringBuilder buf = new StringBuilder((int)(source.length()*1.1));
         String prefix = indent == 0 ? "" : buildIndent(indent);
         try {
             BufferedReader in = new BufferedReader(new StringReader(source));
@@ -89,7 +89,7 @@ public class PrintHelper {
     }
 
     private static String buildIndent(int indent) {
-        StringBuffer buf = new StringBuffer(indent);
+        StringBuilder buf = new StringBuilder(indent);
         for(int i=0; i<indent; i++) {
             buf.append(' ');
         }
@@ -177,7 +177,7 @@ public class PrintHelper {
         // create a list for processed option groups
         ArrayList list = new ArrayList();
 
-        StringBuffer optionsBuff = new StringBuffer();
+        StringBuilder optionsBuff = new StringBuilder();
         
         // temp variable
         Option option;
@@ -252,19 +252,19 @@ public class PrintHelper {
     }
 
     public void printOptions(PrintWriter pw, int width, Options options, int leftPad, int descPad) {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         renderOptions(sb, width, options, leftPad, descPad, true);
         pw.println(sb.toString());
     }
     
     public void printOptions(PrintWriter pw, Options options) {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         renderOptions(sb, defaultWidth, options, defaultLeftPad, defaultDescPad, true);
         pw.println(sb.toString());
     }
     
     public void printOptionsNoDesc(PrintWriter pw, Options options) {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         renderOptions(sb, defaultWidth, options, defaultLeftPad, defaultDescPad, false);
         pw.println(sb.toString());
     }
@@ -274,12 +274,12 @@ public class PrintHelper {
     }
 
     public void printWrapped(PrintWriter pw, int width, int nextLineTabStop, String text) {
-        StringBuffer sb = new StringBuffer(text.length());
+        StringBuilder sb = new StringBuilder(text.length());
         renderWrappedText(sb, width, nextLineTabStop, text);
         pw.println(sb.toString());
     }
 
-    protected StringBuffer renderOptions(StringBuffer sb, int width, Options options, int leftPad, int descPad, boolean displayDesc) {
+    protected StringBuilder renderOptions(StringBuilder sb, int width, Options options, int leftPad, int descPad, boolean displayDesc) {
         final String lpad = createPadding(leftPad);
         final String dpad = createPadding(descPad);
 
@@ -287,14 +287,14 @@ public class PrintHelper {
         //long opt; in parallel look for the longest opt string
         //this list will be then used to sort options ascending
         int max = 0;
-        StringBuffer optBuf;
+        StringBuilder optBuf;
         List prefixList = new ArrayList();
         Option option;
         List optList = new ArrayList(options.getOptions());
-        Collections.sort(optList, new StringBufferComparator());
+        Collections.sort(optList, new StringBuilderComparator());
         for (Iterator i = optList.iterator(); i.hasNext();) {
             option = (Option) i.next();
-            optBuf = new StringBuffer(8);
+            optBuf = new StringBuilder(8);
 
             if (option.getOpt().equals(" ")) {
                 optBuf.append(lpad).append("   " + defaultLongOptPrefix).append(option.getLongOpt());
@@ -320,7 +320,7 @@ public class PrintHelper {
         int x = 0;
         for (Iterator i = optList.iterator(); i.hasNext();) {
             option = (Option) i.next();
-            optBuf = new StringBuffer(prefixList.get(x++).toString());
+            optBuf = new StringBuilder(prefixList.get(x++).toString());
 
             if (optBuf.length() < max) {
                 optBuf.append(createPadding(max - optBuf.length()));
@@ -343,7 +343,7 @@ public class PrintHelper {
         return sb;
     }
 
-    protected StringBuffer renderWrappedText(StringBuffer sb, int width, int nextLineTabStop, String text) {
+    protected StringBuilder renderWrappedText(StringBuilder sb, int width, int nextLineTabStop, String text) {
         int pos = findWrapPos(text, width, 0);
         if (pos == -1) {
             sb.append(rtrim(text));
@@ -398,7 +398,7 @@ public class PrintHelper {
     }
 
     protected String createPadding(int len) {
-        StringBuffer sb = new StringBuffer(len);
+        StringBuilder sb = new StringBuilder(len);
         for (int i = 0; i < len; ++i) {
             sb.append(' ');
         }
@@ -417,7 +417,7 @@ public class PrintHelper {
         return s.substring(0, pos);
     }
 
-    private static class StringBufferComparator implements Comparator {
+    private static class StringBuilderComparator implements Comparator {
 
         public int compare(Object o1, Object o2) {
             String str1 = stripPrefix(o1.toString());

Modified: geronimo/server/trunk/framework/modules/geronimo-common/src/main/java/org/apache/geronimo/common/UnresolvedEJBRefException.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-common/src/main/java/org/apache/geronimo/common/UnresolvedEJBRefException.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-common/src/main/java/org/apache/geronimo/common/UnresolvedEJBRefException.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-common/src/main/java/org/apache/geronimo/common/UnresolvedEJBRefException.java Fri Jul  8 13:24:09 2011
@@ -60,7 +60,7 @@ public class UnresolvedEJBRefException e
 
     private static String createMessage(String refName, boolean local, boolean session, String homeInterface,
                                      String beanInterface, boolean foundMultiple) {
-        StringBuffer msg = new StringBuffer();
+        StringBuilder msg = new StringBuilder();
         if (foundMultiple) {
             msg.append("Two or more EJBs were found");
         } else {

Modified: geronimo/server/trunk/framework/modules/geronimo-common/src/main/java/org/apache/geronimo/common/propertyeditor/ArrayPropertyEditorAdapter.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-common/src/main/java/org/apache/geronimo/common/propertyeditor/ArrayPropertyEditorAdapter.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-common/src/main/java/org/apache/geronimo/common/propertyeditor/ArrayPropertyEditorAdapter.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-common/src/main/java/org/apache/geronimo/common/propertyeditor/ArrayPropertyEditorAdapter.java Fri Jul  8 13:24:09 2011
@@ -72,7 +72,7 @@ public final class ArrayPropertyEditorAd
             return null;
         }
 
-        StringBuffer result = new StringBuffer(String.valueOf(objects[0]));
+        StringBuilder result = new StringBuilder(String.valueOf(objects[0]));
         for (int i = 1; i < objects.length; i++) {
             result.append(",").append(objects[i]);
         }

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/CertificateUtil.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/CertificateUtil.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/CertificateUtil.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/CertificateUtil.java Fri Jul  8 13:24:09 2011
@@ -40,7 +40,7 @@ public class CertificateUtil {
         new HexEncoder().encode(digest, 0, digest.length, out);
         String all = new String(out.toByteArray(), "US-ASCII").toUpperCase();
         Matcher matcher = Pattern.compile("..").matcher(all);
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         while(matcher.find()) {
             if(buf.length() > 0) {
                 buf.append(":");

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERBitString.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERBitString.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERBitString.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERBitString.java Fri Jul  8 13:24:09 2011
@@ -275,7 +275,7 @@ public class DERBitString
 
     public String getString()
     {
-        StringBuffer          buf = new StringBuffer("#");
+        StringBuilder          buf = new StringBuilder("#");
         ByteArrayOutputStream bOut = new ByteArrayOutputStream();
         ASN1OutputStream      aOut = new ASN1OutputStream(bOut);
 

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERObjectIdentifier.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERObjectIdentifier.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERObjectIdentifier.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERObjectIdentifier.java Fri Jul  8 13:24:09 2011
@@ -72,7 +72,7 @@ public class DERObjectIdentifier
     DERObjectIdentifier(
         byte[]  bytes)
     {
-        StringBuffer    objId = new StringBuffer();
+        StringBuilder    objId = new StringBuilder();
         long            value = 0;
         boolean         first = true;
 

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERUniversalString.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERUniversalString.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERUniversalString.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/DERUniversalString.java Fri Jul  8 13:24:09 2011
@@ -78,7 +78,7 @@ public class DERUniversalString
 
     public String getString()
     {
-        StringBuffer    buf = new StringBuffer("#");
+        StringBuilder    buf = new StringBuilder("#");
         ByteArrayOutputStream    bOut = new ByteArrayOutputStream();
         ASN1OutputStream            aOut = new ASN1OutputStream(bOut);
 

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/util/ASN1Dump.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/util/ASN1Dump.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/util/ASN1Dump.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/util/ASN1Dump.java Fri Jul  8 13:24:09 2011
@@ -37,7 +37,7 @@ public class ASN1Dump
     {
         if (obj instanceof ASN1Sequence)
         {
-            StringBuffer    buf = new StringBuffer();
+            StringBuilder    buf = new StringBuilder();
             Enumeration     e = ((ASN1Sequence)obj).getObjects();
             String          tab = indent + TAB;
 
@@ -88,7 +88,7 @@ public class ASN1Dump
         }
         else if (obj instanceof DERTaggedObject)
         {
-            StringBuffer    buf = new StringBuffer();
+            StringBuilder    buf = new StringBuilder();
             String          tab = indent + TAB;
 
             buf.append(indent);
@@ -128,7 +128,7 @@ public class ASN1Dump
         }
         else if (obj instanceof DERConstructedSet)
         {
-            StringBuffer    buf = new StringBuffer();
+            StringBuilder    buf = new StringBuilder();
             Enumeration     e = ((ASN1Set)obj).getObjects();
             String          tab = indent + TAB;
 
@@ -159,7 +159,7 @@ public class ASN1Dump
         }
         else if (obj instanceof BERSet)
         {
-            StringBuffer    buf = new StringBuffer();
+            StringBuilder    buf = new StringBuilder();
             Enumeration     e = ((ASN1Set)obj).getObjects();
             String          tab = indent + TAB;
 
@@ -190,7 +190,7 @@ public class ASN1Dump
         }
         else if (obj instanceof DERSet)
         {
-            StringBuffer    buf = new StringBuffer();
+            StringBuilder    buf = new StringBuilder();
             Enumeration     e = ((ASN1Set)obj).getObjects();
             String          tab = indent + TAB;
 

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/x509/X509Name.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/x509/X509Name.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/x509/X509Name.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/x509/X509Name.java Fri Jul  8 13:24:09 2011
@@ -683,8 +683,8 @@ public class X509Name
                 }
                 else
                 {
-                    StringBuffer    v1 = new StringBuffer();
-                    StringBuffer    v2 = new StringBuffer();
+                    StringBuilder    v1 = new StringBuilder();
+                    StringBuilder    v2 = new StringBuilder();
 
                     if (_val.length() != 0)
                     {
@@ -794,8 +794,8 @@ public class X509Name
                     }
                     else
                     {
-                        StringBuffer    v1 = new StringBuffer();
-                        StringBuffer    v2 = new StringBuffer();
+                        StringBuilder    v1 = new StringBuilder();
+                        StringBuilder    v2 = new StringBuilder();
 
                         if (_val.length() != 0)
                         {
@@ -865,7 +865,7 @@ public class X509Name
     }
 
     private void appendValue(
-        StringBuffer        buf,
+        StringBuilder        buf,
         Hashtable           oidSymbols,
         DERObjectIdentifier oid,
         String              value)
@@ -924,7 +924,7 @@ public class X509Name
         boolean     reverse,
         Hashtable   oidSymbols)
     {
-        StringBuffer            buf = new StringBuffer();
+        StringBuilder            buf = new StringBuilder();
         boolean                 first = true;
 
         if (reverse)

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/x509/X509NameTokenizer.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/x509/X509NameTokenizer.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/x509/X509NameTokenizer.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/asn1/x509/X509NameTokenizer.java Fri Jul  8 13:24:09 2011
@@ -28,7 +28,7 @@ public class X509NameTokenizer
     private String          value;
     private int             index;
     private char            seperator;
-    private StringBuffer    buf = new StringBuffer();
+    private StringBuilder    buf = new StringBuilder();
 
     public X509NameTokenizer(
         String  oid)

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JCERSAPrivateCrtKey.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JCERSAPrivateCrtKey.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JCERSAPrivateCrtKey.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JCERSAPrivateCrtKey.java Fri Jul  8 13:24:09 2011
@@ -246,7 +246,7 @@ public class JCERSAPrivateCrtKey
 
     public String toString()
     {
-        StringBuffer    buf = new StringBuffer();
+        StringBuilder    buf = new StringBuilder();
         String          nl = System.getProperty("line.separator");
 
         buf.append("RSA Private CRT Key" + nl);

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JCERSAPublicKey.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JCERSAPublicKey.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JCERSAPublicKey.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JCERSAPublicKey.java Fri Jul  8 13:24:09 2011
@@ -145,7 +145,7 @@ public class JCERSAPublicKey
 
     public String toString()
     {
-        StringBuffer    buf = new StringBuffer();
+        StringBuilder    buf = new StringBuilder();
         String          nl = System.getProperty("line.separator");
 
         buf.append("RSA Public Key" + nl);

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JDKDSAPublicKey.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JDKDSAPublicKey.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JDKDSAPublicKey.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/JDKDSAPublicKey.java Fri Jul  8 13:24:09 2011
@@ -130,7 +130,7 @@ public class JDKDSAPublicKey
 
     public String toString()
     {
-        StringBuffer    buf = new StringBuffer();
+        StringBuilder    buf = new StringBuilder();
         String          nl = System.getProperty("line.separator");
 
         buf.append("DSA Public Key" + nl);

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/X509CRLEntryObject.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/X509CRLEntryObject.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/X509CRLEntryObject.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/X509CRLEntryObject.java Fri Jul  8 13:24:09 2011
@@ -162,7 +162,7 @@ public class X509CRLEntryObject extends 
 
     public String toString()
     {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         String nl = System.getProperty("line.separator");
 
         buf.append("      userCertificate: " + this.getSerialNumber() + nl);

Modified: geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/X509CertificateObject.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/X509CertificateObject.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/X509CertificateObject.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-crypto/src/main/java/org/apache/geronimo/crypto/jce/provider/X509CertificateObject.java Fri Jul  8 13:24:09 2011
@@ -576,7 +576,7 @@ public class X509CertificateObject
 
     public String toString()
     {
-        StringBuffer    buf = new StringBuffer();
+        StringBuilder    buf = new StringBuilder();
         String          nl = System.getProperty("line.separator");
 
         buf.append("  [0]         Version: " + this.getVersion() + nl);

Modified: geronimo/server/trunk/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/local/CommandSupport.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/local/CommandSupport.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/local/CommandSupport.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/local/CommandSupport.java Fri Jul  8 13:24:09 2011
@@ -226,7 +226,7 @@ public abstract class CommandSupport imp
         }
 
         public String toString() {
-            StringBuffer buf = new StringBuffer();
+            StringBuilder buf = new StringBuilder();
             buf.append("DeploymentStatus[").append(command).append(',');
             buf.append(action).append(',');
             buf.append(state);

Modified: geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java Fri Jul  8 13:24:09 2011
@@ -77,7 +77,7 @@ public class DeployUtils extends ConfigI
             throw new IllegalArgumentException("Need at least 10 spaces for " +
                 "printing, but indent=" + indent + " and endCol=" + endCol);
         }
-        StringBuffer buf = new StringBuffer((int) (source.length() * 1.1));
+        StringBuilder buf = new StringBuilder((int) (source.length() * 1.1));
         String prefix = indent == 0 ? "" : buildIndent(indent);
         try {
             BufferedReader in = new BufferedReader(new StringReader(source));
@@ -136,7 +136,7 @@ public class DeployUtils extends ConfigI
     }
 
     private static String buildIndent(int indent) {
-        StringBuffer buf = new StringBuffer(indent);
+        StringBuilder buf = new StringBuilder(indent);
         for (int i = 0; i < indent; i++) {
             buf.append(' ');
         }

Modified: geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/ClassPathUtils.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/ClassPathUtils.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/ClassPathUtils.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/ClassPathUtils.java Fri Jul  8 13:24:09 2011
@@ -336,7 +336,7 @@ public class ClassPathUtils {
     }
 
     private static String printInfo(String message, URI moduleBaseUri, Collection<String> classpath, Collection<String> exclusions) {
-        StringBuffer buf = new StringBuffer(message).append("\n");
+        StringBuilder buf = new StringBuilder(message).append("\n");
         buf.append("    looking at: ").append(moduleBaseUri);
         buf.append("    current classpath: ").append(classpath);
         buf.append("    ignoring modules: ").append(exclusions);

Modified: geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/DeploymentContext.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/DeploymentContext.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/DeploymentContext.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/DeploymentContext.java Fri Jul  8 13:24:09 2011
@@ -542,7 +542,7 @@ public class DeploymentContext {
     public ConfigurationData getConfigurationData() throws DeploymentException {
         List<String> failures = verify(configuration);
         if (!failures.isEmpty()) {
-            StringBuffer message = new StringBuffer();
+            StringBuilder message = new StringBuilder();
             for (String failure : failures) {
                 if (message.length() > 0) message.append("\n");
                 message.append(failure);

Modified: geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/util/XMLUtil.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/util/XMLUtil.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/util/XMLUtil.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/util/XMLUtil.java Fri Jul  8 13:24:09 2011
@@ -29,7 +29,7 @@ import org.w3c.dom.NodeList;
 public class XMLUtil {
     public static Object getContent(Element element) {
         NodeList nl = element.getChildNodes();
-        StringBuffer content = new StringBuffer();
+        StringBuilder content = new StringBuilder();
         for (int i = 0; i < nl.getLength(); i++) {
             Node node = nl.item(i);
             switch (node.getNodeType()) {

Modified: geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/xml/LocalEntityResolver.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/xml/LocalEntityResolver.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/xml/LocalEntityResolver.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/xml/LocalEntityResolver.java Fri Jul  8 13:24:09 2011
@@ -354,7 +354,7 @@ public class LocalEntityResolver impleme
             final String publicId,
             final String systemId) {
 
-        StringBuffer buffer = new StringBuffer("entity with publicId '");
+        StringBuilder buffer = new StringBuilder("entity with publicId '");
         buffer.append(publicId);
         buffer.append("' and systemId '");
         buffer.append(systemId);

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/AbstractName.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/AbstractName.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/AbstractName.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/AbstractName.java Fri Jul  8 13:24:09 2011
@@ -152,7 +152,7 @@ public class AbstractName implements Ser
     }
 
     private static URI createURI(Artifact artifact, Map name) {
-        StringBuffer queryString = new StringBuffer();
+        StringBuilder queryString = new StringBuilder();
         TreeMap treeMap = new TreeMap(name);
         for (Iterator iterator = treeMap.entrySet().iterator(); iterator.hasNext();) {
             Map.Entry entry = (Map.Entry) iterator.next();

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/AbstractNameQuery.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/AbstractNameQuery.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/AbstractNameQuery.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/AbstractNameQuery.java Fri Jul  8 13:24:09 2011
@@ -151,7 +151,7 @@ public class AbstractNameQuery implement
     }
 
     private static URI createURI(Artifact artifact, Map name, Set interfaceTypes) {
-        StringBuffer queryString = new StringBuffer();
+        StringBuilder queryString = new StringBuilder();
         TreeMap treeMap = new TreeMap(name);
         for (Iterator iterator = treeMap.entrySet().iterator(); iterator.hasNext();) {
             Map.Entry entry = (Map.Entry) iterator.next();
@@ -162,7 +162,7 @@ public class AbstractNameQuery implement
                 queryString.append(',');
             }
         }
-        StringBuffer fragmentString = new StringBuffer();
+        StringBuilder fragmentString = new StringBuilder();
         TreeSet treeSet = new TreeSet(interfaceTypes);
         for (Iterator iterator = treeSet.iterator(); iterator.hasNext();) {
             String interfaceType = (String) iterator.next();

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/BasicGBeanInfoFactory.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/BasicGBeanInfoFactory.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/BasicGBeanInfoFactory.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/BasicGBeanInfoFactory.java Fri Jul  8 13:24:09 2011
@@ -50,7 +50,7 @@ public class BasicGBeanInfoFactory imple
             }
         } catch (NoClassDefFoundError e) {
             String message = e.getMessage();
-            StringBuffer buf = new StringBuffer("Could not load gbean class ").append(clazz.getName()).append(" due to NoClassDefFoundError\n");
+            StringBuilder buf = new StringBuilder("Could not load gbean class ").append(clazz.getName()).append(" due to NoClassDefFoundError\n");
             if (message != null) {
                 message = message.replace('/', '.');
                 buf.append("    problematic class ").append(message);
@@ -95,7 +95,7 @@ public class BasicGBeanInfoFactory imple
             }
         } catch (NoClassDefFoundError e) {
             String message = e.getMessage();
-            StringBuffer buf = new StringBuffer("Could not load gbean class ").append(className).append(" due to NoClassDefFoundError\n");
+            StringBuilder buf = new StringBuilder("Could not load gbean class ").append(className).append(" due to NoClassDefFoundError\n");
             if (message != null) {
                 message = message.replace('/', '.');
                 buf.append("    problematic class ").append(message);

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/GBeanInfo.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/GBeanInfo.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/GBeanInfo.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/GBeanInfo.java Fri Jul  8 13:24:09 2011
@@ -287,7 +287,7 @@ public final class GBeanInfo implements 
 //    }
 
     public String toString() {
-        StringBuffer result = new StringBuffer("[GBeanInfo:");
+        StringBuilder result = new StringBuilder("[GBeanInfo:");
         result.append(" id=").append(super.toString());
         result.append(" sourceClass=").append(sourceClass);
         result.append(" name=").append(name);

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/GOperationSignature.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/GOperationSignature.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/GOperationSignature.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/gbean/GOperationSignature.java Fri Jul  8 13:24:09 2011
@@ -96,7 +96,7 @@ public final class GOperationSignature {
     }
 
     public String toString() {
-        StringBuffer buffer = new StringBuffer(name).append("(");
+        StringBuilder buffer = new StringBuilder(name).append("(");
         for (int i = 0; i < argumentTypes.length; i++) {
             if (i > 0) {
                 buffer.append(", ");

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/ClassLoading.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/ClassLoading.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/ClassLoading.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/ClassLoading.java Fri Jul  8 13:24:09 2011
@@ -335,7 +335,7 @@ public class ClassLoading {
      *         format.
      */
     public static String getClassName(Class type) {
-        StringBuffer name = new StringBuffer();
+        StringBuilder name = new StringBuilder();
 
         // we test these in reverse order from the resolution steps,
         // first handling arrays, then primitive types, and finally

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/ConfigurationUtil.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/ConfigurationUtil.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/ConfigurationUtil.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/ConfigurationUtil.java Fri Jul  8 13:24:09 2011
@@ -481,7 +481,7 @@ public final class ConfigurationUtil {
                     }
                 }
                 if (!unstarted.isEmpty()) {
-                    StringBuffer message = new StringBuffer();
+                    StringBuilder message = new StringBuilder();
                     message.append("Configuration ").append(configuration.getId()).append(" failed to start due to the following reasons:\n");
                     for (String reason : unstarted) {
                         message.append("  ").append(reason).append("\n");

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/RecordingLifecycleMonitor.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/RecordingLifecycleMonitor.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/RecordingLifecycleMonitor.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/config/RecordingLifecycleMonitor.java Fri Jul  8 13:24:09 2011
@@ -78,7 +78,7 @@ public class RecordingLifecycleMonitor i
 
     @Override
     public String toString() {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         for (Event event: events) {
             buf.append(event.toString()).append("\n");
         }

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/Artifact.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/Artifact.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/Artifact.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/Artifact.java Fri Jul  8 13:24:09 2011
@@ -148,7 +148,7 @@ public class Artifact implements Compara
     }
 
     public String toString() {
-        StringBuffer buffer = new StringBuffer();
+        StringBuilder buffer = new StringBuilder();
 
         if (groupId != null) {
             buffer.append(groupId);

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/MissingDependencyException.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/MissingDependencyException.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/MissingDependencyException.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/MissingDependencyException.java Fri Jul  8 13:24:09 2011
@@ -67,7 +67,7 @@ public class MissingDependencyException 
 
     public String getMessage() {
         String s = super.getMessage();
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         if (s != null) {
             sb.append(s).append("\n");
         }

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/Version.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/Version.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/Version.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/repository/Version.java Fri Jul  8 13:24:09 2011
@@ -188,7 +188,7 @@ public class Version implements Comparab
     }
 
     public String toString() {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         if (majorVersion != null) {
             buf.append(majorVersion);
         }

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/util/JarUtils.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/util/JarUtils.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/util/JarUtils.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/util/JarUtils.java Fri Jul  8 13:24:09 2011
@@ -126,7 +126,7 @@ public final class JarUtils {
                 reader = new InputStreamReader(url.openStream());
             }
             char[] buffer = new char[4000];
-            StringBuffer out = new StringBuffer();
+            StringBuilder out = new StringBuilder();
             for (int count = reader.read(buffer); count >= 0; count = reader.read(buffer)) {
                 out.append(buffer, 0, count);
             }

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/util/SelectorUtils.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/util/SelectorUtils.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/util/SelectorUtils.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/util/SelectorUtils.java Fri Jul  8 13:24:09 2011
@@ -542,7 +542,7 @@ public final class SelectorUtils {
             //remove the initial separator; the root has it.
             next = (ca[next] == sep) ? next + 1 : next;
 
-            StringBuffer sbPath = new StringBuffer();
+            StringBuilder sbPath = new StringBuilder();
             // Eliminate consecutive slashes after the drive spec:
             for (int i = next; i < ca.length; i++) {
                 if (ca[i] != sep || ca[i - 1] != sep) {
@@ -676,7 +676,7 @@ public final class SelectorUtils {
      * @return a String that has had all whitespace removed.
      */
     public static String removeWhitespace(String input) {
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
         if (input != null) {
             StringTokenizer st = new StringTokenizer(input);
             while (st.hasMoreTokens()) {
@@ -702,7 +702,7 @@ public final class SelectorUtils {
      */
     public static String rtrimWildcardTokens(String input) {
         Vector v = tokenizePath(input, File.separator);
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         for (int counter = 0; counter < v.size(); counter++) {
             if (hasWildcards((String) v.elementAt(counter))) {
                 break;

Modified: geronimo/server/trunk/framework/modules/geronimo-main/src/main/java/org/apache/geronimo/main/FrameworkLauncher.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-main/src/main/java/org/apache/geronimo/main/FrameworkLauncher.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-main/src/main/java/org/apache/geronimo/main/FrameworkLauncher.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-main/src/main/java/org/apache/geronimo/main/FrameworkLauncher.java Fri Jul  8 13:24:09 2011
@@ -448,7 +448,7 @@ public class FrameworkLauncher {
             String classifier;
             String type;
             String artifactIdVersion = artifactId + "-" + version;
-            StringBuffer sb = new StringBuffer();
+            StringBuilder sb = new StringBuilder();
             if (p[p.length-1].charAt(artifactIdVersion.length()) == '-') {
                 classifier = p[p.length-1].substring(artifactIdVersion.length() + 1, p[p.length-1].lastIndexOf('.'));
             } else {

Modified: geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java Fri Jul  8 13:24:09 2011
@@ -32,19 +32,14 @@ import org.apache.geronimo.kernel.reposi
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import javax.naming.Context;
 import javax.naming.Name;
 import javax.naming.NamingException;
-import javax.naming.spi.ObjectFactory;
-
 import java.util.HashMap;
 import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 import org.osgi.framework.BundleContext;
-import org.osgi.framework.InvalidSyntaxException;
-import org.osgi.framework.ServiceReference;
 
 /**
  * @version $Rev$ $Date$
@@ -88,9 +83,9 @@ public class GBeanFormatBinding extends 
         map.put("version", artifact.getVersion().toString());
         map.put("type", artifact.getType());
         String fullName = format(format, map);
-        
+
         Name parsedName = getContext().getNameParser("").parse(getNameInNamespace()+"/" + fullName);
-    
+
         // create intermediate contexts
         for (int i = 1; i < parsedName.size(); i++) {
             Name contextName = parsedName.getPrefix(i);

Modified: geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/naming/reference/AbstractEntryFactory.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/naming/reference/AbstractEntryFactory.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/naming/reference/AbstractEntryFactory.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/naming/reference/AbstractEntryFactory.java Fri Jul  8 13:24:09 2011
@@ -84,7 +84,7 @@ public abstract class AbstractEntryFacto
         if (!clazz.isAssignableFrom(proxy.getClass())) {
             Class proxyClass = proxy.getClass();
             Class[] interfaces = proxyClass.getInterfaces();
-            StringBuffer message = new StringBuffer();
+            StringBuilder message = new StringBuilder();
             boolean namesMatch = false;
             for (Class anInterface : interfaces) {
                 if (clazz.getName().equals(anInterface.getName())) {

Modified: geronimo/server/trunk/framework/modules/geronimo-obr/src/main/java/org/apache/geronimo/obr/ResourceBuilder.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-obr/src/main/java/org/apache/geronimo/obr/ResourceBuilder.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-obr/src/main/java/org/apache/geronimo/obr/ResourceBuilder.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-obr/src/main/java/org/apache/geronimo/obr/ResourceBuilder.java Fri Jul  8 13:24:09 2011
@@ -129,7 +129,7 @@ public class ResourceBuilder {
         if (requiredEnvironments != null) {
             String[] envs = requiredEnvironments.split(",");
             if (envs.length > 0) {
-                StringBuffer sb = new StringBuffer();
+                StringBuilder sb = new StringBuilder();
                 sb.append("(|");
                 for (String env : envs) {
                     sb.append("(ee=");

Modified: geronimo/server/trunk/framework/modules/geronimo-pax-logging/src/main/java/org/apache/geronimo/logging/impl/Log4jService.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-pax-logging/src/main/java/org/apache/geronimo/logging/impl/Log4jService.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-pax-logging/src/main/java/org/apache/geronimo/logging/impl/Log4jService.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-pax-logging/src/main/java/org/apache/geronimo/logging/impl/Log4jService.java Fri Jul  8 13:24:09 2011
@@ -273,7 +273,7 @@ public abstract class Log4jService imple
         }
         Reader in = null;
         try {
-            StringBuffer configuration = new StringBuffer();
+            StringBuilder configuration = new StringBuilder();
             in = new InputStreamReader(new FileInputStream(file));
             char[] buffer = new char[4096];
             for (int size = in.read(buffer); size >= 0; size = in.read(buffer)) {
@@ -422,7 +422,7 @@ public abstract class Log4jService imple
     }
 
     private static String substituteSystemProps(String source) {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         int last = 0;
         Matcher m = VARIABLE_PATTERN.matcher(source);
         while(m.find()) {

Modified: geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java Fri Jul  8 13:24:09 2011
@@ -1119,7 +1119,7 @@ public class PluginInstallerGBean implem
         if (!missingPrereqs.isEmpty()) {
             PluginArtifactType metadata = plugin.getPluginArtifact().get(0);
             Artifact moduleId = toArtifact(metadata.getModuleId());
-            StringBuffer buf = new StringBuffer();
+            StringBuilder buf = new StringBuilder();
             buf.append(moduleId.toString()).append(" requires ");
             Iterator<Dependency> iter = missingPrereqs.iterator();
             while (iter.hasNext()) {

Modified: geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/ReferenceServerInstanceData.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/ReferenceServerInstanceData.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/ReferenceServerInstanceData.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/ReferenceServerInstanceData.java Fri Jul  8 13:24:09 2011
@@ -81,7 +81,7 @@ public class ReferenceServerInstanceData
 
     @Override
      public String toString() {
-         StringBuffer buf = new StringBuffer();
+         StringBuilder buf = new StringBuilder();
          buf.append("ReferenceServerInstanceData:\n");
          buf.append("  Name: ").append(getName()).append("\n");
          buf.append("  ConfigFile: ").append(getConfigFile()).append("\n");

Modified: geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/RemoteSourceRepository.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/RemoteSourceRepository.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/RemoteSourceRepository.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/RemoteSourceRepository.java Fri Jul  8 13:24:09 2011
@@ -265,12 +265,12 @@ public class RemoteSourceRepository impl
      */
     private static String getText(Node target) {
         NodeList nodes = target.getChildNodes();
-        StringBuffer buf = null;
+        StringBuilder buf = null;
         for (int j = 0; j < nodes.getLength(); j++) {
             Node node = nodes.item(j);
             if (node.getNodeType() == Node.TEXT_NODE) {
                 if (buf == null) {
-                    buf = new StringBuffer();
+                    buf = new StringBuilder();
                 }
                 buf.append(node.getNodeValue());
             }
@@ -293,12 +293,12 @@ public class RemoteSourceRepository impl
             Node check = children.item(i);
             if (check.getNodeType() == Node.ELEMENT_NODE && check.getNodeName().equals(property)) {
                 NodeList nodes = check.getChildNodes();
-                StringBuffer buf = null;
+                StringBuilder buf = null;
                 for (int j = 0; j < nodes.getLength(); j++) {
                     Node node = nodes.item(j);
                     if (node.getNodeType() == Node.TEXT_NODE) {
                         if (buf == null) {
-                            buf = new StringBuffer();
+                            buf = new StringBuilder();
                         }
                         buf.append(node.getNodeValue());
                     }

Modified: geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/ServerInstanceData.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/ServerInstanceData.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/ServerInstanceData.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/ServerInstanceData.java Fri Jul  8 13:24:09 2011
@@ -132,7 +132,7 @@ public class ServerInstanceData {
 
     @Override
     public String toString() {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         buf.append("ServerInstanceData:\n");
         buf.append("  Name: ").append(getName()).append("\n");
         buf.append("  AttributeManagerFrom: ").append(getAttributeManagerFrom()).append("\n");

Modified: geronimo/server/trunk/framework/modules/geronimo-rmi-loader/src/main/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImpl.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-rmi-loader/src/main/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImpl.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-rmi-loader/src/main/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImpl.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-rmi-loader/src/main/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImpl.java Fri Jul  8 13:24:09 2011
@@ -81,7 +81,7 @@ public class RMIClassLoaderSpiImpl
             if (null == urls) {
                 return delegate.getClassAnnotation(type);
             }
-            StringBuffer codebase = new StringBuffer();
+            StringBuilder codebase = new StringBuilder();
             for (int i = 0; i < urls.length; i++) {
                 URL url = normalizeURL(urls[i]);
                 if (codebase.length() != 0) {
@@ -133,8 +133,8 @@ public class RMIClassLoaderSpiImpl
     {
         assert input != null;
 
-        StringBuffer codebase = new StringBuffer();
-        StringBuffer working = new StringBuffer();
+        StringBuilder codebase = new StringBuilder();
+        StringBuilder working = new StringBuilder();
         StringTokenizer stok = new StringTokenizer(input, " \t\n\r\f", true);
         
         while (stok.hasMoreTokens()) {
@@ -168,7 +168,7 @@ public class RMIClassLoaderSpiImpl
         return codebase.toString();
     }
     
-    private static void updateCodebase(final StringBuffer working, final StringBuffer codebase)
+    private static void updateCodebase(final StringBuilder working, final StringBuilder codebase)
         throws MalformedURLException
     {
         if (working.length() != 0) {

Modified: geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/DomainPrincipal.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/DomainPrincipal.java?rev=1144307&r1=1144306&r2=1144307&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/DomainPrincipal.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/DomainPrincipal.java Fri Jul  8 13:24:09 2011
@@ -79,7 +79,7 @@ public class DomainPrincipal implements 
     public String getName() {
         if (name == null) {
 
-            StringBuffer buffer = new StringBuffer("");
+            StringBuilder buffer = new StringBuilder("");
             buffer.append(domain);
             buffer.append("::");
             buffer.append(principal.getClass().getName());