You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "nada-attia (via GitHub)" <gi...@apache.org> on 2026/02/23 15:41:12 UTC
[PR] feat(client): Add pre-write validator framework [hudi]
nada-attia opened a new pull request, #18239:
URL: https://github.com/apache/hudi/pull/18239
### Describe the issue this Pull Request addresses
This PR introduces a pluggable pre-write validation framework that allows custom validators to run before write operations begin. This enables validation of conditions like schema compatibility, permissions, resource availability, and service onboarding status before proceeding with writes.
Currently, Hudi only supports pre-commit validators that run after data has been written but before commit. This PR adds an earlier validation hook at the pre-write stage, allowing failures to be detected before any write work begins.
### Summary and Changelog
**Summary**: Users can now configure custom validators that run before write operations via the `hoodie.prewrite.validators` configuration property.
**Changelog**:
- Added `PreWriteValidator` interface for implementing custom pre-write validators
- Added `PreWriteValidatorUtils` utility class to load and run configured validators
- Added `HoodiePreWriteValidatorConfig` configuration class with `hoodie.prewrite.validators` property
- Modified `BaseHoodieWriteClient.preWrite()` to invoke configured validators
- Added `getPreWriteValidators()` method to `HoodieWriteConfig`
- Added unit tests for `PreWriteValidatorUtils`
### Impact
- **New public API**: `PreWriteValidator` interface that users can implement for custom validators
- **New configuration**: `hoodie.prewrite.validators` - comma-separated list of validator class names
- No breaking changes to existing functionality
- No performance impact when no validators are configured
### Risk Level
low - This is an additive feature with no changes to existing write paths when no validators are configured. The feature is opt-in via configuration.
### Documentation Update
The following documentation updates are needed:
- Config description for `hoodie.prewrite.validators` is included in the code
- Website documentation for the new pre-write validator feature should be added
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Enough context is provided in the sections above
- [x] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3995501764
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999091217
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.97468%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.44%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (990a8ab). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (990a8ab) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.25% 43.44% -13.81%
+ Complexity 18601 13868 -4733
=============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
=============================================
- Hits 61084 46379 -14705
- Misses 39846 55056 +15210
+ Partials 5760 5318 -442
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <29.11%> (-14.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <29.11%> (-12.41%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.91% <100.00%> (-7.29%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `78.25% <100.00%> (-6.78%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `72.92% <88.88%> (-16.58%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [783 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3945962959
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de4c43deae07c04d1635447dcfa7823d638f7b77 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222)
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 88754a67734d498abaa36942688248a88f99d0f7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3994652844
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3991798110
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238)
* c48fe470e4d8346fa2a20a4f865bc7ef5bc62015 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992067028
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238)
* c48fe470e4d8346fa2a20a4f865bc7ef5bc62015 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3998938913
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `31.42857%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.19%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (990a8ab). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (990a8ab) |
>|------|------|------|
>|spark-scala-tests|6|0|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.25% 45.19% -12.07%
+ Complexity 18601 8388 -10213
=============================================
Files 1948 1183 -765
Lines 106690 60724 -45966
Branches 13196 6478 -6718
=============================================
- Hits 61084 27442 -33642
+ Misses 39846 30304 -9542
+ Partials 5760 2978 -2782
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `50.09% <100.00%> (-23.10%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `74.47% <100.00%> (-10.55%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [1383 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3995759333
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3994842513
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999203171
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `39.24051%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18606 +5
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
+ Hits 61084 61101 +17
- Misses 39846 39890 +44
- Partials 5760 5762 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.36% <31.64%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3945565817
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de4c43deae07c04d1635447dcfa7823d638f7b77 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3948101174
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992012561
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.44%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (c48fe47). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (c48fe47) |
>|------|------|------|
>|spark-scala-tests|6|1|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.28% 40.44% -16.84%
+ Complexity 18532 12273 -6259
=============================================
Files 1944 1917 -27
Lines 106132 102000 -4132
Branches 13118 12100 -1018
=============================================
- Hits 60797 41254 -19543
- Misses 39612 55902 +16290
+ Partials 5723 4844 -879
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.60% <28.57%> (-11.91%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `54.61% <100.00%> (-18.48%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `77.41% <0.00%> (-7.60%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `67.40% <88.88%> (-22.10%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [893 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3945832083
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de4c43deae07c04d1635447dcfa7823d638f7b77 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222)
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 88754a67734d498abaa36942688248a88f99d0f7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993032242
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.34%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 55.34% -1.91%
+ Complexity 18601 17928 -673
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
- Hits 61084 59085 -1999
- Misses 39846 41823 +1977
- Partials 5760 5843 +83
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.27% <31.16%> (-4.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <29.87%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.51%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <100.00%> (-2.23%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [263 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999129730
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.97468%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.38%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 55.38% -1.88%
+ Complexity 18601 17939 -662
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
- Hits 61084 59123 -1961
- Misses 39846 41790 +1944
- Partials 5760 5840 +80
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.32% <30.37%> (-4.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <29.11%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.51%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <100.00%> (-2.23%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [255 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999350490
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `39.24051%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18607 +6
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
+ Hits 61084 61102 +18
- Misses 39846 39889 +43
- Partials 5760 5762 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <31.64%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992250064
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.22%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.28% 57.22% -0.06%
- Complexity 18532 18603 +71
============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
============================================
+ Hits 60797 61091 +294
- Misses 39612 39900 +288
- Partials 5723 5760 +37
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <31.16%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <28.57%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.35%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <0.00%> (+0.03%)` | :arrow_up: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [61 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999261485
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
}, {
"hash" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12397",
"triggerID" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"triggerType" : "PUSH"
}, {
"hash" : "990a8abaf6ee3e71fc517f846fec8727e3a33ea2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12418",
"triggerID" : "990a8abaf6ee3e71fc517f846fec8727e3a33ea2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 990a8abaf6ee3e71fc517f846fec8727e3a33ea2 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12418)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992111334
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 51.67%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (c48fe47). Click for more details.
>
> <details><summary>HEAD has 8 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (c48fe47) |
>|------|------|------|
>|spark-scala-tests|6|4|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.28% 51.67% -5.61%
+ Complexity 18532 16596 -1936
============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
============================================
- Hits 60797 55166 -5631
- Misses 39612 45628 +6016
- Partials 5723 5957 +234
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <28.57%> (-14.27%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <28.57%> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `70.24% <100.00%> (-2.85%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `79.44% <0.00%> (-5.57%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `76.79% <88.88%> (-12.71%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [547 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992050646
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.42%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (c48fe47). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (c48fe47) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.28% 43.42% -13.87%
+ Complexity 18532 13860 -4672
=============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
=============================================
- Hits 60797 46353 -14444
- Misses 39612 55082 +15470
+ Partials 5723 5316 -407
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <28.57%> (-14.27%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <28.57%> (-12.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.91% <100.00%> (-7.18%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `78.25% <0.00%> (-6.76%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `72.92% <88.88%> (-16.58%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [793 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992037001
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.33%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (c48fe47). Click for more details.
>
> <details><summary>HEAD has 11 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (c48fe47) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.28% 43.33% -13.95%
+ Complexity 18532 13835 -4697
=============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
=============================================
- Hits 60797 46263 -14534
- Misses 39612 55154 +15542
+ Partials 5723 5334 -389
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.94% <28.57%> (-13.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <28.57%> (-12.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.91% <100.00%> (-7.18%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `78.25% <0.00%> (-6.76%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `72.92% <88.88%> (-16.58%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [794 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3991868783
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `30.88235%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.23%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (c48fe47). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (c48fe47) |
>|------|------|------|
>|spark-scala-tests|6|0|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.28% 45.23% -12.05%
+ Complexity 18532 8402 -10130
=============================================
Files 1944 1183 -761
Lines 106132 60722 -45410
Branches 13118 6478 -6640
=============================================
- Hits 60797 27470 -33327
+ Misses 39612 30270 -9342
+ Partials 5723 2982 -2741
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `50.09% <100.00%> (-23.00%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `74.47% <0.00%> (-10.53%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [1388 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "nada-attia (via GitHub)" <gi...@apache.org>.
nada-attia commented on code in PR #18239:
URL: https://github.com/apache/hudi/pull/18239#discussion_r2878978311
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -555,6 +558,18 @@ public abstract O bulkInsertPreppedRecords(I preppedRecords, final String instan
*/
public void preWrite(String instantTime, WriteOperationType writeOperationType,
HoodieTableMetaClient metaClient) {
+ preWrite(instantTime, writeOperationType, metaClient, null);
+ }
+
+ /**
+ * Common method containing steps to be performed before write (upsert/insert/...) with records.
+ * @param instantTime
+ * @param writeOperationType
+ * @param metaClient
+ * @param records HoodieData of records to be written, may be null
+ */
+ public void preWrite(String instantTime, WriteOperationType writeOperationType,
+ HoodieTableMetaClient metaClient, HoodieData<HoodieRecord<T>> records) {
Review Comment:
done
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/PreWriteValidatorUtils.java:
##########
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client.utils;
+
+import org.apache.hudi.client.validator.PreWriteValidator;
+import org.apache.hudi.common.data.HoodieData;
+import org.apache.hudi.common.engine.HoodieEngineContext;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.model.WriteOperationType;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.util.HoodieTimer;
+import org.apache.hudi.common.util.ReflectionUtils;
+import org.apache.hudi.common.util.StringUtils;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.exception.HoodieValidationException;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * Utility class for running pre-write validators.
+ */
+public class PreWriteValidatorUtils {
+ private static final Logger LOG = LoggerFactory.getLogger(PreWriteValidatorUtils.class);
+
+ /**
+ * Run all configured pre-write validators.
+ * Validators are run sequentially, and if any validator fails,
+ * a HoodieValidationException is thrown.
+ *
+ * @param config The write configuration
+ * @param instantTime The instant time for the write operation
+ * @param writeOperationType The type of write operation
+ * @param metaClient The HoodieTableMetaClient
+ * @param engineContext The Hoodie engine context
+ * @param records HoodieData of records to be written, may be null
+ * @param <T> The payload type of the records
+ * @throws HoodieValidationException if any validation fails
+ */
+ public static <T> void runValidators(HoodieWriteConfig config,
+ String instantTime,
+ WriteOperationType writeOperationType,
+ HoodieTableMetaClient metaClient,
+ HoodieEngineContext engineContext,
+ HoodieData<HoodieRecord<T>> records) {
+ String validatorClassNames = config.getPreWriteValidators();
+
+ if (StringUtils.isNullOrEmpty(validatorClassNames)) {
+ LOG.debug("No pre-write validators configured.");
+ return;
+ }
+
+ HoodieTimer timer = HoodieTimer.start();
+ List<PreWriteValidator> validators = Arrays.stream(validatorClassNames.split(","))
+ .map(String::trim)
+ .filter(className -> !className.isEmpty())
+ .map(className -> (PreWriteValidator) ReflectionUtils.loadClass(className))
+ .collect(Collectors.toList());
+
+ LOG.info("Running {} pre-write validators for instant {}", validators.size(), instantTime);
+
+ List<String> failedValidators = validators.stream()
+ .filter(validator -> !runValidator(validator, instantTime, writeOperationType, metaClient, config, engineContext, records))
+ .map(PreWriteValidator::getName)
+ .collect(Collectors.toList());
+
+ long duration = timer.endTimer();
+ LOG.info("Pre-write validation completed in {} ms", duration);
+
+ if (!failedValidators.isEmpty()) {
+ String failedMessage = String.join(", ", failedValidators);
+ throw new HoodieValidationException(
+ "Pre-write validation failed for validators: " + failedMessage);
+ }
+ }
+
+ /**
+ * Run a single validator.
+ *
+ * @return true if validation passed, false if validation failed
+ */
+ private static <T> boolean runValidator(PreWriteValidator validator,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992293247
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238)
* c48fe470e4d8346fa2a20a4f865bc7ef5bc62015 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393)
* fea570e3240e57ac03bbb23d908f0e456695f245 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992140494
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.47%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.28% 55.47% -1.82%
+ Complexity 18532 17975 -557
============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
============================================
- Hits 60797 59215 -1582
- Misses 39612 41708 +2096
- Partials 5723 5828 +105
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.42% <29.87%> (-4.00%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <28.57%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.40%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <0.00%> (-2.21%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [266 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993004048
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.63%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (89c3bac). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (89c3bac) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.25% 39.63% -17.62%
+ Complexity 18601 12608 -5993
=============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
=============================================
- Hits 61084 42314 -18770
- Misses 39846 59356 +19510
+ Partials 5760 5081 -679
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <29.87%> (-12.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `54.61% <100.00%> (-18.58%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `77.41% <100.00%> (-7.62%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `67.40% <88.88%> (-22.10%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [856 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993093847
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.37% <32.46%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3996381490
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3998733695
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
}, {
"hash" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12397",
"triggerID" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"triggerType" : "PUSH"
}, {
"hash" : "990a8abaf6ee3e71fc517f846fec8727e3a33ea2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12418",
"triggerID" : "990a8abaf6ee3e71fc517f846fec8727e3a33ea2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 89c3bac7401d071b7c4ef13eed55ed947d732a2d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12397)
* 990a8abaf6ee3e71fc517f846fec8727e3a33ea2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12418)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999269512
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `39.24051%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18607 +6
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
+ Hits 61084 61102 +18
- Misses 39846 39889 +43
- Partials 5760 5762 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <31.64%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3946006628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de4c43deae07c04d1635447dcfa7823d638f7b77 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222)
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 88754a67734d498abaa36942688248a88f99d0f7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224)
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3945592517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de4c43deae07c04d1635447dcfa7823d638f7b77 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992788329
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.07%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e545b5b`](https://app.codecov.io/gh/apache/hudi/commit/e545b5bf278c4a2df62a4f2fe21227c54698b228?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (e545b5b). Click for more details.
>
> <details><summary>HEAD has 13 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (e545b5b) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.25% 40.07% -17.19%
+ Complexity 18601 12447 -6154
=============================================
Files 1948 1934 -14
Lines 106690 104416 -2274
Branches 13196 12699 -497
=============================================
- Hits 61084 41841 -19243
- Misses 39846 57627 +17781
+ Partials 5760 4948 -812
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.40% <29.87%> (-12.13%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `54.61% <100.00%> (-18.58%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `77.41% <100.00%> (-7.62%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `67.40% <88.88%> (-22.10%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [869 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992205806
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.22%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.28% 57.22% -0.07%
- Complexity 18532 18603 +71
============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
============================================
+ Hits 60797 61085 +288
- Misses 39612 39904 +292
- Partials 5723 5762 +39
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.36% <31.16%> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <28.57%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.35%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <0.00%> (+0.03%)` | :arrow_up: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [62 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992536533
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* c48fe470e4d8346fa2a20a4f865bc7ef5bc62015 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393)
* fea570e3240e57ac03bbb23d908f0e456695f245 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394)
* e545b5bf278c4a2df62a4f2fe21227c54698b228 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992024233
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (c48fe47). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (c48fe47) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.28% 39.64% -17.65%
+ Complexity 18532 12610 -5922
=============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
=============================================
- Hits 60797 42318 -18479
- Misses 39612 59354 +19742
+ Partials 5723 5079 -644
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <28.57%> (-12.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `54.61% <100.00%> (-18.48%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `77.41% <0.00%> (-7.60%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `67.40% <88.88%> (-22.10%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [865 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992427467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238)
* c48fe470e4d8346fa2a20a4f865bc7ef5bc62015 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393)
* fea570e3240e57ac03bbb23d908f0e456695f245 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999739696
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `39.24051%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18607 +6
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
+ Hits 61084 61102 +18
- Misses 39846 39889 +43
- Partials 5760 5762 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <31.64%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3996704772
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999172953
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.97468%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.49%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 55.49% -1.76%
+ Complexity 18601 17984 -617
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
- Hits 61084 59243 -1841
- Misses 39846 41681 +1835
- Partials 5760 5829 +69
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.43% <30.37%> (-3.98%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.51%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <100.00%> (-2.23%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [229 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992018001
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.00%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (c48fe47). Click for more details.
>
> <details><summary>HEAD has 13 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (c48fe47) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.28% 40.00% -17.28%
+ Complexity 18532 12438 -6094
=============================================
Files 1944 1934 -10
Lines 106132 104335 -1797
Branches 13118 12599 -519
=============================================
- Hits 60797 41739 -19058
- Misses 39612 57616 +18004
+ Partials 5723 4980 -743
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.31% <28.57%> (-12.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `54.61% <100.00%> (-18.48%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `77.41% <0.00%> (-7.60%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `67.40% <88.88%> (-22.10%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [883 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992569214
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `32.35294%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e545b5b`](https://app.codecov.io/gh/apache/hudi/commit/e545b5bf278c4a2df62a4f2fe21227c54698b228?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (e545b5b). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (e545b5b) |
>|------|------|------|
>|spark-scala-tests|6|0|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.25% 45.23% -12.03%
+ Complexity 18601 8400 -10201
=============================================
Files 1948 1183 -765
Lines 106690 60722 -45968
Branches 13196 6478 -6718
=============================================
- Hits 61084 27465 -33619
+ Misses 39846 30273 -9573
+ Partials 5760 2984 -2776
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `50.09% <100.00%> (-23.10%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `74.47% <100.00%> (-10.55%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [1383 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993034782
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.37%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 55.37% -1.89%
+ Complexity 18601 17935 -666
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
- Hits 61084 59111 -1973
- Misses 39846 41796 +1950
- Partials 5760 5844 +84
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.31% <31.16%> (-4.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <29.87%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.51%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <100.00%> (-2.23%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [259 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993089794
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.03%
- Complexity 18601 18602 +1
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61096 +12
- Misses 39846 39890 +44
- Partials 5760 5765 +5
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.33% <32.46%> (-0.08%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3997678100
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999192771
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `39.24051%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.03%
- Complexity 18601 18605 +4
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
+ Hits 61084 61097 +13
- Misses 39846 39893 +47
- Partials 5760 5763 +3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.32% <31.64%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-4000098367
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `39.24051%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18607 +6
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
+ Hits 61084 61102 +18
- Misses 39846 39889 +43
- Partials 5760 5762 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <31.64%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992128089
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.19%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.28% 55.19% -2.09%
+ Complexity 18532 17895 -637
============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
============================================
- Hits 60797 58922 -1875
- Misses 39612 42011 +2399
- Partials 5723 5818 +95
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.09% <29.87%> (-4.34%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <28.57%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.40%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <0.00%> (-2.21%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [307 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-4001189089
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `39.24051%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18607 +6
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
+ Hits 61084 61102 +18
- Misses 39846 39889 +43
- Partials 5760 5762 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <31.64%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3946277865
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de4c43deae07c04d1635447dcfa7823d638f7b77 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222)
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 88754a67734d498abaa36942688248a88f99d0f7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224)
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* b325d290adad1da82e0654c2232c75b47c9ae15b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3947550424
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* b325d290adad1da82e0654c2232c75b47c9ae15b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225)
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3994652045
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3995041135
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999125883
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.97468%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.38%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 55.38% -1.88%
+ Complexity 18601 17939 -662
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
- Hits 61084 59123 -1961
- Misses 39846 41790 +1944
- Partials 5760 5840 +80
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.32% <30.37%> (-4.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.43% <29.11%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.51%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <100.00%> (-2.23%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [255 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999277513
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `39.24051%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18607 +6
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
+ Hits 61084 61102 +18
- Misses 39846 39889 +43
- Partials 5760 5762 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <31.64%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999043533
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.97468%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.40%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (990a8ab). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (990a8ab) |
>|------|------|------|
>|spark-scala-tests|6|1|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.25% 40.40% -16.85%
+ Complexity 18601 12277 -6324
=============================================
Files 1948 1917 -31
Lines 106690 102033 -4657
Branches 13196 12109 -1087
=============================================
- Hits 61084 41226 -19858
- Misses 39846 55963 +16117
+ Partials 5760 4844 -916
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.57% <29.11%> (-11.96%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `54.61% <100.00%> (-18.58%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `77.41% <100.00%> (-7.62%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `67.40% <88.88%> (-22.10%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [885 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3998684189
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
}, {
"hash" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12397",
"triggerID" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"triggerType" : "PUSH"
}, {
"hash" : "990a8abaf6ee3e71fc517f846fec8727e3a33ea2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "990a8abaf6ee3e71fc517f846fec8727e3a33ea2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 89c3bac7401d071b7c4ef13eed55ed947d732a2d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12397)
* 990a8abaf6ee3e71fc517f846fec8727e3a33ea2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999175981
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.97468%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.49%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 55.49% -1.76%
+ Complexity 18601 17984 -617
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
- Hits 61084 59243 -1841
- Misses 39846 41681 +1835
- Partials 5760 5829 +69
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.43% <30.37%> (-3.98%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.51%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <100.00%> (-2.23%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [229 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3994842183
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992803482
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
}, {
"hash" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* fea570e3240e57ac03bbb23d908f0e456695f245 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394)
* e545b5bf278c4a2df62a4f2fe21227c54698b228 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396)
* 89c3bac7401d071b7c4ef13eed55ed947d732a2d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992048707
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.37%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (c48fe47). Click for more details.
>
> <details><summary>HEAD has 10 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (c48fe47) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.28% 43.37% -13.91%
+ Complexity 18532 13850 -4682
=============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
=============================================
- Hits 60797 46308 -14489
- Misses 39612 55114 +15502
+ Partials 5723 5329 -394
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.52% <28.57%> (-13.91%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <28.57%> (-12.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.91% <100.00%> (-7.18%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `78.25% <0.00%> (-6.76%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `72.92% <88.88%> (-16.58%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [794 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992487678
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238)
* c48fe470e4d8346fa2a20a4f865bc7ef5bc62015 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393)
* fea570e3240e57ac03bbb23d908f0e456695f245 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394)
* e545b5bf278c4a2df62a4f2fe21227c54698b228 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992761605
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* fea570e3240e57ac03bbb23d908f0e456695f245 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394)
* e545b5bf278c4a2df62a4f2fe21227c54698b228 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993874359
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3945684604
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de4c43deae07c04d1635447dcfa7823d638f7b77 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222)
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992139439
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.47%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.28% 55.47% -1.82%
+ Complexity 18532 17975 -557
============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
============================================
- Hits 60797 59215 -1582
- Misses 39612 41708 +2096
- Partials 5723 5828 +105
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.42% <29.87%> (-4.00%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <28.57%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.40%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <0.00%> (-2.21%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [266 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992117658
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.11%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.28% 55.11% -2.18%
+ Complexity 18532 17872 -660
============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
============================================
- Hits 60797 58833 -1964
- Misses 39612 42078 +2466
- Partials 5723 5840 +117
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.09% <29.87%> (-4.34%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <28.57%> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.40%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <0.00%> (-2.21%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [327 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992557196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* fea570e3240e57ac03bbb23d908f0e456695f245 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394)
* e545b5bf278c4a2df62a4f2fe21227c54698b228 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992200488
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.22%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.28% 57.22% -0.07%
- Complexity 18532 18603 +71
============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
============================================
+ Hits 60797 61085 +288
- Misses 39612 39904 +292
- Partials 5723 5762 +39
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.33% <31.16%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <28.57%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.35%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <0.00%> (+0.03%)` | :arrow_up: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [62 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993021578
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
}, {
"hash" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12397",
"triggerID" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* e545b5bf278c4a2df62a4f2fe21227c54698b228 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396)
* 89c3bac7401d071b7c4ef13eed55ed947d732a2d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12397)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993107733
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3996031101
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999117093
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.97468%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.76%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (990a8ab). Click for more details.
>
> <details><summary>HEAD has 8 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (990a8ab) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 48.76% -8.50%
+ Complexity 18601 15808 -2793
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
- Hits 61084 52053 -9031
- Misses 39846 49352 +9506
+ Partials 5760 5348 -412
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.12% <30.37%> (-4.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <29.11%> (-12.41%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `68.92% <100.00%> (-4.27%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.44% <100.00%> (-2.58%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `77.34% <88.88%> (-12.16%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [536 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3946821435
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* b325d290adad1da82e0654c2232c75b47c9ae15b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3946433850
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 88754a67734d498abaa36942688248a88f99d0f7 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224)
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* b325d290adad1da82e0654c2232c75b47c9ae15b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3947802047
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* b325d290adad1da82e0654c2232c75b47c9ae15b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225)
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3999157958
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.97468%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.49%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 55.49% -1.76%
+ Complexity 18601 17984 -617
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
- Hits 61084 59243 -1841
- Misses 39846 41681 +1835
- Partials 5760 5829 +69
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.43% <30.37%> (-3.98%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.51%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <100.00%> (-2.23%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [229 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993010154
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.44%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (89c3bac). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (89c3bac) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.25% 43.44% -13.82%
+ Complexity 18601 13868 -4733
=============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
=============================================
- Hits 61084 46373 -14711
- Misses 39846 55059 +15213
+ Partials 5760 5319 -441
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <29.87%> (-14.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <29.87%> (-12.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.91% <100.00%> (-7.29%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `78.25% <100.00%> (-6.78%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `72.92% <88.88%> (-16.58%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [783 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993008905
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.44%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (89c3bac). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (89c3bac) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.25% 43.44% -13.82%
+ Complexity 18601 13868 -4733
=============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
=============================================
- Hits 61084 46373 -14711
- Misses 39846 55059 +15213
+ Partials 5760 5319 -441
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <29.87%> (-14.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <29.87%> (-12.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.91% <100.00%> (-7.29%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `78.25% <100.00%> (-6.78%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `72.92% <88.88%> (-16.58%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [783 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993003458
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.63%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (89c3bac). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (89c3bac) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
=============================================
- Coverage 57.25% 39.63% -17.62%
+ Complexity 18601 12608 -5993
=============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
=============================================
- Hits 61084 42314 -18770
- Misses 39846 59356 +19510
+ Partials 5760 5081 -679
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <29.87%> (-12.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `54.61% <100.00%> (-18.58%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `77.41% <100.00%> (-7.62%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `67.40% <88.88%> (-22.10%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [856 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3994382274
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.25974%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18603 +2
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
+ Hits 61084 61100 +16
- Misses 39846 39887 +41
- Partials 5760 5764 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <32.46%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992138470
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `37.66234%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.44%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c48fe47`](https://app.codecov.io/gh/apache/hudi/commit/c48fe470e4d8346fa2a20a4f865bc7ef5bc62015?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 24 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.28% 55.44% -1.85%
+ Complexity 18532 17968 -564
============================================
Files 1944 1951 +7
Lines 106132 106751 +619
Branches 13118 13198 +80
============================================
- Hits 60797 59185 -1612
- Misses 39612 41736 +2124
- Partials 5723 5830 +107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <30.88%> (-0.18%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.38% <29.87%> (-4.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <28.57%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.40%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <0.00%> (-2.21%)` | :arrow_down: |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [274 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #18239:
URL: https://github.com/apache/hudi/pull/18239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993028097
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 51.69%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (43d8ed8) and HEAD (89c3bac). Click for more details.
>
> <details><summary>HEAD has 8 uploads less than BASE</summary>
>
>| Flag | BASE (43d8ed8) | HEAD (89c3bac) |
>|------|------|------|
>|spark-scala-tests|6|4|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 51.69% -5.56%
+ Complexity 18601 16603 -1998
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
- Hits 61084 55186 -5898
- Misses 39846 45605 +5759
- Partials 5760 5960 +200
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <29.87%> (-14.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <29.87%> (-0.24%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `70.24% <100.00%> (-2.95%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `79.44% <100.00%> (-5.59%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `76.79% <88.88%> (-12.71%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [528 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993042076
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.48%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 55.48% -1.77%
+ Complexity 18601 17981 -620
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
- Hits 61084 59233 -1851
- Misses 39846 41686 +1840
- Partials 5760 5832 +72
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.43% <31.16%> (-3.99%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.51%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <100.00%> (-2.23%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [232 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993038662
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.96104%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.41%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89c3bac`](https://app.codecov.io/gh/apache/hudi/commit/89c3bac7401d071b7c4ef13eed55ed947d732a2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.81% | [32 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 88.88% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 55.41% -1.84%
+ Complexity 18601 17952 -649
============================================
Files 1948 1951 +3
Lines 106690 106751 +61
Branches 13196 13198 +2
============================================
- Hits 61084 59160 -1924
- Misses 39846 41747 +1901
- Partials 5760 5844 +84
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.23% <32.35%> (+0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.31% <31.16%> (-4.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <29.87%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.69% <100.00%> (-0.51%)` | :arrow_down: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `82.79% <100.00%> (-2.23%)` | :arrow_down: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `80.11% <88.88%> (-9.40%)` | :arrow_down: |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.81% <10.81%> (ø)` | |
... and [250 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-4001190335
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `39.24051%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`43d8ed8`](https://app.codecov.io/gh/apache/hudi/commit/43d8ed83f361be870b11550c444114158e2bef29?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`990a8ab`](https://app.codecov.io/gh/apache/hudi/commit/990a8abaf6ee3e71fc517f846fec8727e3a33ea2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | 10.25% | [34 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | 29.41% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18239 +/- ##
============================================
- Coverage 57.25% 57.23% -0.02%
- Complexity 18601 18607 +6
============================================
Files 1948 1951 +3
Lines 106690 106753 +63
Branches 13196 13198 +2
============================================
+ Hits 61084 61102 +18
- Misses 39846 39889 +43
- Partials 5760 5762 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <31.42%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <31.64%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18239/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <29.11%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.44% <100.00%> (+0.25%)` | :arrow_up: |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodieWriteConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVXcml0ZUNvbmZpZy5qYXZh) | `85.03% <100.00%> (+0.01%)` | :arrow_up: |
| [.../org/apache/hudi/client/HoodieJavaWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieJavaWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9jbGllbnQvSG9vZGllSmF2YVdyaXRlQ2xpZW50LmphdmE=) | `78.16% <100.00%> (ø)` | |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | `89.50% <100.00%> (ø)` | |
| [...pache/hudi/client/validator/PreWriteValidator.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fvalidator%2FPreWriteValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC92YWxpZGF0b3IvUHJlV3JpdGVWYWxpZGF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/hudi/config/HoodiePreWriteValidatorConfig.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfig%2FHoodiePreWriteValidatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbmZpZy9Ib29kaWVQcmVXcml0ZVZhbGlkYXRvckNvbmZpZy5qYXZh) | `29.41% <29.41%> (ø)` | |
| [...ache/hudi/client/utils/PreWriteValidatorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18239?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FPreWriteValidatorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC91dGlscy9QcmVXcml0ZVZhbGlkYXRvclV0aWxzLmphdmE=) | `10.25% <10.25%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18239/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3993127091
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
}, {
"hash" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12397",
"triggerID" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 89c3bac7401d071b7c4ef13eed55ed947d732a2d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12397)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3946034710
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de4c43deae07c04d1635447dcfa7823d638f7b77 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222)
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 88754a67734d498abaa36942688248a88f99d0f7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224)
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3992890751
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12238",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
}, {
"hash" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12393",
"triggerID" : "c48fe470e4d8346fa2a20a4f865bc7ef5bc62015",
"triggerType" : "PUSH"
}, {
"hash" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12394",
"triggerID" : "fea570e3240e57ac03bbb23d908f0e456695f245",
"triggerType" : "PUSH"
}, {
"hash" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396",
"triggerID" : "e545b5bf278c4a2df62a4f2fe21227c54698b228",
"triggerType" : "PUSH"
}, {
"hash" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "89c3bac7401d071b7c4ef13eed55ed947d732a2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* e545b5bf278c4a2df62a4f2fe21227c54698b228 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12396)
* 89c3bac7401d071b7c4ef13eed55ed947d732a2d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3947740720
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
}, {
"hash" : "03caa41a992d71707673f1c297b62d5d39574f04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03caa41a992d71707673f1c297b62d5d39574f04",
"triggerType" : "PUSH"
}, {
"hash" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* b325d290adad1da82e0654c2232c75b47c9ae15b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225)
* 03caa41a992d71707673f1c297b62d5d39574f04 UNKNOWN
* 3a9f16c38e253eceb0d60e6a79c01ff1a77e89fe UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(client): Add pre-write validator framework [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18239:
URL: https://github.com/apache/hudi/pull/18239#issuecomment-3946350625
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222",
"triggerID" : "de4c43deae07c04d1635447dcfa7823d638f7b77",
"triggerType" : "PUSH"
}, {
"hash" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d670d57bae88bc4ff92779f8790d18554dac1eae",
"triggerType" : "PUSH"
}, {
"hash" : "88754a67734d498abaa36942688248a88f99d0f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224",
"triggerID" : "88754a67734d498abaa36942688248a88f99d0f7",
"triggerType" : "PUSH"
}, {
"hash" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bf58ef5e3d2e2176ce02f402aefb978adcef1cc",
"triggerType" : "PUSH"
}, {
"hash" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "582c79c2b74e6d76256b3cd5d6bf135ddce4b421",
"triggerType" : "PUSH"
}, {
"hash" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225",
"triggerID" : "b325d290adad1da82e0654c2232c75b47c9ae15b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* de4c43deae07c04d1635447dcfa7823d638f7b77 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12222)
* d670d57bae88bc4ff92779f8790d18554dac1eae UNKNOWN
* 88754a67734d498abaa36942688248a88f99d0f7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12224)
* 6bf58ef5e3d2e2176ce02f402aefb978adcef1cc UNKNOWN
* 582c79c2b74e6d76256b3cd5d6bf135ddce4b421 UNKNOWN
* b325d290adad1da82e0654c2232c75b47c9ae15b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12225)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org