You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda <kk...@cloudera.com> on 2017/04/27 18:19:30 UTC
Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
Bugs: SENTRY-1726
https://issues.apache.org/jira/browse/SENTRY-1726
Repository: sentry
Description
-------
1. Created new table to store the last notification id
2. Table is defined to store only one entry.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
Diff: https://reviews.apache.org/r/58808/diff/1/
Testing
-------
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by Na Li <li...@cloudera.com>.
> On April 27, 2017, 8:25 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/58808/diff/1/?file=1702015#file1702015line30>
> >
> > Can you explain more about why using 'signleton'and why have '15' length restriction here? And add a comment to it.
>
> kalyan kumar kalvagadda wrote:
> Idea is to restrict the the table to have only one record which has the last notification-id that sentry processed. Applicaiton should do an insert at the begining and later it should be only updates to existing record.
>
> To restrict the table to have only one record I have taken below approach
> 1. Added RESTRICTION column and made it a primary key
> 2. Have set a default value for that column.
> 3. JDO definition for this table will not have feild in the class for the column RESTRICTION, so application will just know NOTIFICATION_ID in the table.
> 4. If application tries to insert another entry into table yy mistake it will fail.
You mentioned that you had error by definning JDO for this table having no field in the class for the column RESTRICTION. Is that resolved? If not, then this approach does not work.
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173252
-----------------------------------------------------------
On May 9, 2017, 11:15 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 11:15 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table will store the notification id's of all the notifications processed by sentry server.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/2/
>
>
> Testing
> -------
>
> Tested with the databases that sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On April 27, 2017, 8:25 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/58808/diff/1/?file=1702015#file1702015line30>
> >
> > Can you explain more about why using 'signleton'and why have '15' length restriction here? And add a comment to it.
Idea is to restrict the the table to have only one record which has the last notification-id that sentry processed. Applicaiton should do an insert at the begining and later it should be only updates to existing record.
To restrict the table to have only one record I have taken below approach
1. Added RESTRICTION column and made it a primary key
2. Have set a default value for that column.
3. JDO definition for this table will not have feild in the class for the column RESTRICTION, so application will just know NOTIFICATION_ID in the table.
4. If application tries to insert another entry into table yy mistake it will fail.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173252
-----------------------------------------------------------
On April 28, 2017, 8:30 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 8:30 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table is defined to store only one entry.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/1/
>
>
> Testing
> -------
>
> tested the sql changes with the all databases sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On April 27, 2017, 8:25 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/58808/diff/1/?file=1702015#file1702015line30>
> >
> > Can you explain more about why using 'signleton'and why have '15' length restriction here? And add a comment to it.
>
> kalyan kumar kalvagadda wrote:
> Idea is to restrict the the table to have only one record which has the last notification-id that sentry processed. Applicaiton should do an insert at the begining and later it should be only updates to existing record.
>
> To restrict the table to have only one record I have taken below approach
> 1. Added RESTRICTION column and made it a primary key
> 2. Have set a default value for that column.
> 3. JDO definition for this table will not have feild in the class for the column RESTRICTION, so application will just know NOTIFICATION_ID in the table.
> 4. If application tries to insert another entry into table yy mistake it will fail.
>
> Na Li wrote:
> You mentioned that you had error by definning JDO for this table having no field in the class for the column RESTRICTION. Is that resolved? If not, then this approach does not work.
I have taken a different approach. This comment may not be valid now.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173252
-----------------------------------------------------------
On May 9, 2017, 11:15 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 11:15 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table will store the notification id's of all the notifications processed by sentry server.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/2/
>
>
> Testing
> -------
>
> Tested with the databases that sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173252
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
Lines 30 (patched)
<https://reviews.apache.org/r/58808/#comment246295>
Can you explain more about why using 'signleton'and why have '15' length restriction here? And add a comment to it.
- Hao Hao
On April 27, 2017, 6:19 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 6:19 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table is defined to store only one entry.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On May 9, 2017, 3:34 p.m., Na Li wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
> > Lines 26 (patched)
> > <https://reviews.apache.org/r/58808/diff/1/?file=1702015#file1702015line26>
> >
> > Can you add comment that this table should have only one row?
I have taken a different approach. This comment may not be valid now.
> On May 9, 2017, 3:34 p.m., Na Li wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/58808/diff/1/?file=1702015#file1702015line30>
> >
> > This link may be useful for you to limit the table with only one row. ENUM and SET columns provide an efficient way to define columns that can contain only a given set of values
> > https://dev.mysql.com/doc/refman/5.7/en/constraint-enum.html
> >
> > CREATE TABLE SENTRY_LAST_NOTIFICATION_ID (
> > `id` enum('1') NOT NULL,
> > NOTIFICATION_ID BIGINT NOT NULL,
> > PRIMARY KEY (`id`)
> > ) ENGINE=InnoDB DEFAULT CHARSET=latin1 COMMENT='The ENUM(''1'') construct as primary key is used to prevent that more than one row can be entered to the table';
I have this approach but had issues comming up with similar approach for other databases as well.
I have taken a different approach. This comment may not be valid now.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173635
-----------------------------------------------------------
On May 9, 2017, 11:15 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 11:15 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table will store the notification id's of all the notifications processed by sentry server.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/2/
>
>
> Testing
> -------
>
> Tested with the databases that sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173635
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
Lines 26 (patched)
<https://reviews.apache.org/r/58808/#comment246871>
Can you add comment that this table should have only one row?
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
Lines 30 (patched)
<https://reviews.apache.org/r/58808/#comment246637>
This link may be useful for you to limit the table with only one row. ENUM and SET columns provide an efficient way to define columns that can contain only a given set of values
https://dev.mysql.com/doc/refman/5.7/en/constraint-enum.html
CREATE TABLE SENTRY_LAST_NOTIFICATION_ID (
`id` enum('1') NOT NULL,
NOTIFICATION_ID BIGINT NOT NULL,
PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1 COMMENT='The ENUM(''1'') construct as primary key is used to prevent that more than one row can be entered to the table';
- Na Li
On April 28, 2017, 8:30 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 8:30 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table is defined to store only one entry.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/1/
>
>
> Testing
> -------
>
> tested the sql changes with the all databases sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review174325
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
Lines 34 (patched)
<https://reviews.apache.org/r/58808/#comment247458>
Can you use SQL script to insert a row into the table with a given primary key right after defining the table? And constrain the table to have the primary key value equal to that one? In this way, you can force the table having only one row.
- Na Li
On May 9, 2017, 11:15 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 11:15 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table will store the notification id's of all the notifications processed by sentry server.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/2/
>
>
> Testing
> -------
>
> Tested with the databases that sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review174750
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On May 9, 2017, 11:15 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 11:15 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table will store the notification id's of all the notifications processed by sentry server.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/2/
>
>
> Testing
> -------
>
> Tested with the databases that sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review174479
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On May 9, 2017, 11:15 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 11:15 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table will store the notification id's of all the notifications processed by sentry server.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/2/
>
>
> Testing
> -------
>
> Tested with the databases that sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On May 10, 2017, 6:19 p.m., Alexander Kolbasov wrote:
> > You have only one upgrade script updated - do you need to update other upgrade scripts or not?
I have used existing script so I need not change the upgrade sript.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review174522
-----------------------------------------------------------
On May 9, 2017, 11:15 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 11:15 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table will store the notification id's of all the notifications processed by sentry server.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/2/
>
>
> Testing
> -------
>
> Tested with the databases that sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review174522
-----------------------------------------------------------
You have only one upgrade script updated - do you need to update other upgrade scripts or not?
- Alexander Kolbasov
On May 9, 2017, 11:15 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 11:15 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table will store the notification id's of all the notifications processed by sentry server.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/2/
>
>
> Testing
> -------
>
> Tested with the databases that sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review174749
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On May 9, 2017, 11:15 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 11:15 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table will store the notification id's of all the notifications processed by sentry server.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/2/
>
>
> Testing
> -------
>
> Tested with the databases that sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/
-----------------------------------------------------------
(Updated May 9, 2017, 11:15 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
updated the testing done.
Bugs: SENTRY-1726
https://issues.apache.org/jira/browse/SENTRY-1726
Repository: sentry
Description
-------
1. Created new table to store the last notification id
2. Table will store the notification id's of all the notifications processed by sentry server.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
Diff: https://reviews.apache.org/r/58808/diff/2/
Testing (updated)
-------
Tested with the databases that sentry supports.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/
-----------------------------------------------------------
(Updated May 9, 2017, 11:14 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Changes the table defination. Description of the review is updated accordingly.
Bugs: SENTRY-1726
https://issues.apache.org/jira/browse/SENTRY-1726
Repository: sentry
Description (updated)
-------
1. Created new table to store the last notification id
2. Table will store the notification id's of all the notifications processed by sentry server.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
Diff: https://reviews.apache.org/r/58808/diff/2/
Changes: https://reviews.apache.org/r/58808/diff/1-2/
Testing
-------
tested the sql changes with the all databases sentry supports.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/
-----------------------------------------------------------
(Updated April 28, 2017, 8:30 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
updated the testing permormed.
Bugs: SENTRY-1726
https://issues.apache.org/jira/browse/SENTRY-1726
Repository: sentry
Description
-------
1. Created new table to store the last notification id
2. Table is defined to store only one entry.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
Diff: https://reviews.apache.org/r/58808/diff/1/
Testing (updated)
-------
tested the sql changes with the all databases sentry supports.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/
-----------------------------------------------------------
(Updated April 28, 2017, 8:29 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
Bugs: SENTRY-1726
https://issues.apache.org/jira/browse/SENTRY-1726
Repository: sentry
Description
-------
1. Created new table to store the last notification id
2. Table is defined to store only one entry.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
Diff: https://reviews.apache.org/r/58808/diff/1/
Testing (updated)
-------
tested the sql changes with the all databases we support.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On April 27, 2017, 8:06 p.m., Vamsee Yarlagadda wrote:
> > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
> > Lines 24-34 (patched)
> > <https://reviews.apache.org/r/58808/diff/1/?file=1702015#file1702015line24>
> >
> > Not sure what was the rule behind creating these patch files like SENTRY-1726.derby.sql for this change?
Convestion was to use the create new sql file for changes to db schema. There were comments from people when I tried similar convention with an argument, Why not bundle all the change done for HA into file file. I agree with them. Plan is to combine all the changes done for HA which are spread accross multiple sql file to one under SENTRY-872. So i did not mind creating new file for this change. Instead used the existing file.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173249
-----------------------------------------------------------
On April 27, 2017, 6:19 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 6:19 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table is defined to store only one entry.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173249
-----------------------------------------------------------
Fix it, then Ship it!
LGTM otherwise
sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql
Lines 24-34 (patched)
<https://reviews.apache.org/r/58808/#comment246292>
Not sure what was the rule behind creating these patch files like SENTRY-1726.derby.sql for this change?
- Vamsee Yarlagadda
On April 27, 2017, 6:19 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 6:19 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table is defined to store only one entry.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
> On April 27, 2017, 8:41 p.m., Alexander Kolbasov wrote:
> > It is difficult to review these changes since there is no context in the JIRA, explaining how is this supposed to work. Here were just have some tables defined.
I have the jira with more details.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173254
-----------------------------------------------------------
On April 28, 2017, 8:30 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 8:30 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table is defined to store only one entry.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/1/
>
>
> Testing
> -------
>
> tested the sql changes with the all databases sentry supports.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 58808: SENTRY-1726 sql changes to store last
notification-id processed
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58808/#review173254
-----------------------------------------------------------
It is difficult to review these changes since there is no context in the JIRA, explaining how is this supposed to work. Here were just have some tables defined.
- Alexander Kolbasov
On April 27, 2017, 6:19 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58808/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 6:19 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Na Li, Sergio Pena, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1726
> https://issues.apache.org/jira/browse/SENTRY-1726
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1. Created new table to store the last notification id
> 2. Table is defined to store only one entry.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql ba70715
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql 879e732
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql e83ab83
> sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql c28099b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql 841dcaa
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql 223835e
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql 006d57b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql 20921ea
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql 489ad66
> sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql ec50912
>
>
> Diff: https://reviews.apache.org/r/58808/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>