You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/05 13:38:46 UTC

[GitHub] [spark] LucaCanali opened a new pull request #30619: [SPARK-31711][CORE][FOLLOWUP] Move executorSourceLocalModeOnly to sparkEnv

LucaCanali opened a new pull request #30619:
URL: https://github.com/apache/spark/pull/30619


   ### What changes were proposed in this pull request?
   
   This followup of from SPARK-31711 and a recent review comment in #28528 by @zsxwing :
   ( `executorSourceLocalModeOnly` ) is never been cleaned. It would be great to avoid using a global executorSourceLocalModeOnly to save a state of a specific executor. Can we move this to SparkEnv so that a state of one test won't be leaked to other tests?
   
   ### Why are the changes needed?
   This PR moves `executorSourceLocalModeOnly` from Executor to SparkEnv
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   This is covered by existing tests + also manually tested.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] commented on pull request #30619: [SPARK-31711][CORE][FOLLOWUP] Move executorSourceLocalModeOnly to sparkEnv

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #30619:
URL: https://github.com/apache/spark/pull/30619#issuecomment-821906987


   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30619: [SPARK-31711][CORE][FOLLOWUP] Move executorSourceLocalModeOnly to sparkEnv

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30619:
URL: https://github.com/apache/spark/pull/30619#issuecomment-739252432


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LucaCanali commented on pull request #30619: [SPARK-31711][CORE][FOLLOWUP] Move executorSourceLocalModeOnly to sparkEnv

Posted by GitBox <gi...@apache.org>.
LucaCanali commented on pull request #30619:
URL: https://github.com/apache/spark/pull/30619#issuecomment-756035070


   Hi @zsxwing this PR follows up on your comment in #28528 in case you want to take a look at it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] closed pull request #30619: [SPARK-31711][CORE][FOLLOWUP] Move executorSourceLocalModeOnly to sparkEnv

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #30619:
URL: https://github.com/apache/spark/pull/30619


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org