You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Benoy Antony (JIRA)" <ji...@apache.org> on 2014/06/03 22:24:02 UTC

[jira] [Updated] (HADOOP-10659) Refactor AccessControlList to reuse utility functions and to improve performance

     [ https://issues.apache.org/jira/browse/HADOOP-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benoy Antony updated HADOOP-10659:
----------------------------------

    Attachment: HADOOP-10659.patch

Attaching the patch which does the following.

1. Use _StringUtils.getTrimmedStringCollection_  to cleanup the inputs. Removed the internal cleanup code.

2. Replaced TreeSet  with LinkedHashSet for better performance 

> Refactor AccessControlList to reuse utility functions and to improve performance
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-10659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10659
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>            Priority: Minor
>         Attachments: HADOOP-10659.patch
>
>
> Minor improvements can be done on _AccessControlList_.
> Code Reusability:
> _AccessControlList_ sanitizes the input list to remove duplicate entries, trim entries. _StringUtils.getTrimmedStringCollection_ can be used in this case.
> Performance:
> _AccessControlList_  uses TreeSet to maintain set of users and groups.
> HashSet improves the performance slightly.



--
This message was sent by Atlassian JIRA
(v6.2#6252)