[jira] [Resolved] (CALCITE-2433) SqlAdvisor.getCompletionHints is hard-coded for " quoting

["Vladimir Sitnikov (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Sitnikov resolved CALCITE-2433.
----------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.18.0

Fixed in https://git-wip-us.apache.org/repos/asf?p=calcite.git;a=commit;h=89e22e3ff8082790a3160d0a95cf3546e65a77d1

> SqlAdvisor.getCompletionHints is hard-coded for " quoting
> ---------------------------------------------------------
>
>                 Key: CALCITE-2433
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2433
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.18.0
>
>
> Relevant source:
> {code:java}
>     boolean quoted = false;
>     while (wordStart > 0
>         && Character.isJavaIdentifierPart(sql.charAt(wordStart - 1))) {
>       --wordStart;
>     }
>     if ((wordStart > 0)
>         && (sql.charAt(wordStart - 1) == '"')) { // <-- It should get quoting from the connection
>       quoted = true;
>       --wordStart;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)