[GitHub] [spark] HyukjinKwon commented on a change in pull request #25209: [SPARK-28456][SQL]Add a public API `Encoder.copyEncoder` to allow creating Encoder without touching Scala Reflection

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #25209: [SPARK-28456][SQL]Add a public API `Encoder.copyEncoder` to allow creating Encoder without touching Scala Reflection
URL: https://github.com/apache/spark/pull/25209#discussion_r305570530
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
 ##########
 @@ -452,6 +452,10 @@ class ExpressionEncoderSuite extends CodegenInterpretedPlanTest with AnalysisTes
     }
   }
 
+  encodeDecodeTest("foo" -> 1L, "copied encoder") {
 
 Review comment:
   @zsxwing, can we move this test up over `testOverflowingBigNumeric`? I think private helper method look intentionally grouped below here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org