You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Emond Papegaaij (JIRA)" <ji...@apache.org> on 2017/04/05 12:55:42 UTC
[jira] [Updated] (WICKET-6353) Proxy deserialization fails due to classloading issues

     [ https://issues.apache.org/jira/browse/WICKET-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emond Papegaaij updated WICKET-6353:
------------------------------------
    Description: 
JavaSerializer.ClassResolverObjectInputStream overrides resolveClass to resolve classes via the Wicket ClassResolvers. This does however not happen for resolveProxyClass.

An example of how this can go wrong:
* A page with a large component tree is deserialized (war).
* LinkedMap (used in MarkupContainer) is loaded in a parent ClassLoader (ear).
* Via this stack, a proxy is hit implementing Spring classes (from the war)
* Due to LinkedMap determining the latestUserDefinedLoader, the ear-loader is used for the lookup of this interface, which fails

Unfortunately, writing a testcase for this is not easy, so I only have a proposed fix: see the classloadingfix branch

  was:
JavaSerializer.ClassResolverObjectInputStream overrides resolveClass to resolve classes via the Wicket ClassResolvers. This does however not happen for resolveProxyClass.

An example of how this can go wrong:
* A page with a large component tree is deserialized (war).
* LinkedMap (used in MarkupContainer) is loaded in a parent ClassLoader (ear).
* Via this stack, a proxy is hit implementing Spring classes (from the war)
* Due to LinkedMap determining the latestUserDefinedLoader, the ear-loader is used for the lookup of this interface, which fails

Unfortunately, writing a testcase for this is not easy, so I only have a proposed fix.


> Proxy deserialization fails due to classloading issues
> ------------------------------------------------------
>
>                 Key: WICKET-6353
>                 URL: https://issues.apache.org/jira/browse/WICKET-6353
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 7.6.0
>            Reporter: Emond Papegaaij
>
> JavaSerializer.ClassResolverObjectInputStream overrides resolveClass to resolve classes via the Wicket ClassResolvers. This does however not happen for resolveProxyClass.
> An example of how this can go wrong:
> * A page with a large component tree is deserialized (war).
> * LinkedMap (used in MarkupContainer) is loaded in a parent ClassLoader (ear).
> * Via this stack, a proxy is hit implementing Spring classes (from the war)
> * Due to LinkedMap determining the latestUserDefinedLoader, the ear-loader is used for the lookup of this interface, which fails
> Unfortunately, writing a testcase for this is not easy, so I only have a proposed fix: see the classloadingfix branch



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)