You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datafu.apache.org by Joydeep Banerjee <jb...@gmail.com> on 2014/07/21 20:03:10 UTC

Review Request 23751: DATAFU-62 - Pig UDF for URL info

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.

> On July 23, 2014, 8:14 p.m., Matthew Hayes wrote:
> > Can you update the diff?  It looks like the new patch was attached to the RB instead of updating it as a patch.

Sorry about that. Just updated the diff.


- Joydeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/#review48550
-----------------------------------------------------------


On July 23, 2014, 8:38 p.m., Joydeep Banerjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23751/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 8:38 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-62 - Pig UDF for URL info
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23751/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> DATAFU-62-v2
>   https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch
> 
> 
> Thanks,
> 
> Joydeep Banerjee
> 
>

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/#review48550
-----------------------------------------------------------


Can you update the diff?  It looks like the new patch was attached to the RB instead of updating it as a patch.

- Matthew Hayes


On July 22, 2014, 11:07 p.m., Joydeep Banerjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23751/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 11:07 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-62 - Pig UDF for URL info
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23751/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> DATAFU-62-v2
>   https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch
> 
> 
> Thanks,
> 
> Joydeep Banerjee
> 
>

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.

> On July 23, 2014, 10:54 p.m., Matthew Hayes wrote:
> > It looks like the diff didn't apply cleanly.  Do you know why this is?
> > 
> > Diff currently unavailable.
> > Error: The patch to 'datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.Ns3J4X' for debugging purposes. `patch` returned: The next patch would create the file /tmp/reviewboard.Ns3J4X/tmpjP6xtp, which already exists! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored

Not sure. Tried another update. But looks like the problem remains.

Here's the commit log - 
$ git log master..
commit 8f68d4f81103b70d77b76022fefb94e62edf6810
Author: Joydeep Banerjee <jb...@gmail.com>
Date:   Wed Jul 23 15:36:30 2014 -0700

    Mods to the URLInfo class

commit a3be94de960a4eb00edb66aee4acb2fceb206cf1
Author: Joydeep Banerjee <jb...@gmail.com>
Date:   Tue Jul 22 16:02:05 2014 -0700

    Modified per review comments.

commit 6216eed8918359360112f7cd3b84cf8c71b3cfd5
Author: Joydeep Banerjee <jb...@gmail.com>
Date:   Mon Jul 21 10:51:17 2014 -0700

    Added Pig UDF for URL Info


- Joydeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/#review48564
-----------------------------------------------------------


On July 23, 2014, 11:23 p.m., Joydeep Banerjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23751/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 11:23 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-62 - Pig UDF for URL info
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23751/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> DATAFU-62-v2
>   https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch
> 
> 
> Thanks,
> 
> Joydeep Banerjee
> 
>

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/#review48564
-----------------------------------------------------------


It looks like the diff didn't apply cleanly.  Do you know why this is?

Diff currently unavailable.
Error: The patch to 'datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.Ns3J4X' for debugging purposes. `patch` returned: The next patch would create the file /tmp/reviewboard.Ns3J4X/tmpjP6xtp, which already exists! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored

- Matthew Hayes


On July 23, 2014, 10:41 p.m., Joydeep Banerjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23751/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 10:41 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-62 - Pig UDF for URL info
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23751/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> DATAFU-62-v2
>   https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch
> 
> 
> Thanks,
> 
> Joydeep Banerjee
> 
>

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/#review48583
-----------------------------------------------------------

Ship it!


Ship It!

- Matthew Hayes


On July 23, 2014, 11:38 p.m., Joydeep Banerjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23751/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 11:38 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-62 - Pig UDF for URL info
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23751/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> DATAFU-62-v2
>   https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch
> 
> 
> Thanks,
> 
> Joydeep Banerjee
> 
>

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/#review49482
-----------------------------------------------------------



datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java
<https://reviews.apache.org/r/23751/#comment86548>

    You might consider checking each case individually.  Otherwise when the data doesn't match it is hard to identify where the problem is.  For example, here is the test failure output I currently see:
    
    junit.framework.ComparisonFailure: null expected:<...tp,/eng/hello.jsp,,[[x#foo,y#bar]))
    ((world.org,hello.world.org,http,/products/data/data.html,90,))
    ((bar.com,roger.bar.com,http,/eng/hello.jsp,,[x#foo,y#bar]]))> but was:<...tp,/eng/hello.jsp,,[[y#bar,x#foo]))
    ((world.org,hello.world.org,http,/products/data/data.html,90,))
    ((bar.com,roger.bar.com,http,/eng/hello.jsp,,[y#bar,x#foo]]))>


- Matthew Hayes


On Aug. 4, 2014, 6:34 p.m., Joydeep Banerjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23751/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 6:34 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-62 - Pig UDF for URL info
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23751/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joydeep Banerjee
> 
>

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 23, 2014, 7:53 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 10, 2014, 7:04 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 10, 2014, 6:54 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 10, 2014, 6:46 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 4, 2014, 6:34 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 4, 2014, 6:34 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 4, 2014, 6:33 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


File Attachments (updated)
----------------

DATAFU-62.patch
  https://reviews.apache.org/media/uploaded/files/2014/08/04/d08d3a22-1f86-4e0b-b4ff-7454cf46f733__DATAFU-62.patch


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 4, 2014, 6:26 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 1, 2014, 10:40 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 1, 2014, 10:30 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


File Attachments
----------------

DATAFU-62-v2
  https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated Aug. 1, 2014, 10:25 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


File Attachments
----------------

DATAFU-62-v2
  https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated July 23, 2014, 11:38 p.m.)


Review request for DataFu.


Changes
-------

Added v4


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


File Attachments
----------------

DATAFU-62-v2
  https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated July 23, 2014, 11:23 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


File Attachments
----------------

DATAFU-62-v2
  https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated July 23, 2014, 10:41 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


File Attachments
----------------

DATAFU-62-v2
  https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/#review48560
-----------------------------------------------------------



datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java
<https://reviews.apache.org/r/23751/#comment85244>

    StreamingMedian isn't used



datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java
<https://reviews.apache.org/r/23751/#comment85246>

    Since Pattern is thread safe I would just create a static field to hold it so you don't have to call compile on every call.


- Matthew Hayes


On July 23, 2014, 8:38 p.m., Joydeep Banerjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23751/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 8:38 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-62 - Pig UDF for URL info
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23751/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> DATAFU-62-v2
>   https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch
> 
> 
> Thanks,
> 
> Joydeep Banerjee
> 
>

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated July 23, 2014, 8:38 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


File Attachments
----------------

DATAFU-62-v2
  https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Joydeep Banerjee <jb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/
-----------------------------------------------------------

(Updated July 22, 2014, 11:07 p.m.)


Review request for DataFu.


Repository: datafu


Description
-------

DATAFU-62 - Pig UDF for URL info


Diffs
-----

  datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
  datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/23751/diff/


Testing
-------


File Attachments (updated)
----------------

DATAFU-62-v2
  https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch


Thanks,

Joydeep Banerjee

Re: Review Request 23751: DATAFU-62 - Pig UDF for URL info

Posted by Matthew Hayes <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/#review48343
-----------------------------------------------------------



datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java
<https://reviews.apache.org/r/23751/#comment84855>

    I wonder if it is worth exposing the raw query string too.  Although it would be a strange query string and I'm not really sure what it means, the following would result in information loss:
    
    x=foo&y=bar&x=baz



datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java
<https://reviews.apache.org/r/23751/#comment84854>

    I'd prefer static helper methods to extract the portion from the URL that you are interested in, rather than fields in the class.



datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java
<https://reviews.apache.org/r/23751/#comment84856>

    File seems a bit too redundant, since it is derived from the path and query string.


- Matthew Hayes


On July 21, 2014, 6:03 p.m., Joydeep Banerjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23751/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 6:03 p.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-62 - Pig UDF for URL info
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23751/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joydeep Banerjee
> 
>