You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/19 07:34:59 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #11325: Villebro/p0 extras
villebro opened a new pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325
### SUMMARY
Adds support for `applied_filters` and `rejected_filters` to chart data endpoint + adds support for temporal extras to both `viz.py` and chart data endpoint.
Short summary of changes:
- In the legacy data `json_explore` endpoint, temporal extras (`__time_range` etc) are applied to `form_data` in `merge_extras` (see: https://github.com/apache/incubator-superset/blob/735123d1f5513d366955db1865faf6b064c9bd4a/superset/utils/core.py#L922-L953 ), information of which temporal filters have been overridden is lost. To get around this, we add the applied temporal extras in a dict called `applied_time_extras` that we can later reference to determine which of them were applied and which were not.
- since `superset-ui/core` merges temporal extras to the query object prior to sending the request, essentially performing the above operation (see: https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-core/src/query/extractExtras.ts) , we need to pass along `applied_time_extras` in the request.
### TEST PLAN
CI with updated old tests + new E2E test
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507895255
##########
File path: superset/charts/schemas.py
##########
@@ -894,6 +906,12 @@ class ChartDataResponseResult(Schema):
description="Amount of rows in result set", allow_none=False,
)
data = fields.List(fields.Dict(), description="A list with results")
+ applied_filters = fields.List(
+ fields.Dict(), description="A list with applied filters"
+ )
Review comment:
I forgot to add this, thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11325: [WIP] fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507538990
##########
File path: superset/charts/schemas.py
##########
@@ -816,6 +821,13 @@ class ChartDataQueryObjectSchema(Schema):
"as `having_druid`.",
deprecated=True,
)
+ druid_time_origin = fields.String(
+ description="Starting point for time grain counting on legacy Druid "
+ "datasources. Used to change e.g. Monday/Sunday first-day-of-week. "
+ "This field is deprecated and should be passed to `extras` "
+ "as `druid_time_origin`.",
+ allow_none=True,
+ )
Review comment:
Turns out this was missing from the chart data schema. Also added to deprecated field mapping in `query_object.py`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: [WIP] fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **decrease** coverage by `4.86%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
- Coverage 60.78% 55.92% -4.87%
=====================================================
Files 393 401 +8
Lines 24848 13410 -11438
Branches 0 3395 +3395
=====================================================
- Hits 15105 7499 -7606
+ Misses 9743 5725 -4018
- Partials 0 186 +186
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.92% <100.00%> (?)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ntend/src/dashboard/components/PublishedStatus.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy5qc3g=) | `61.90% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `91.66% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/sections.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9zZWN0aW9ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `93.93% <100.00%> (ø)` | |
| [...ns/versions/620241d1153f\_update\_time\_grain\_sqla.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy82MjAyNDFkMTE1M2ZfdXBkYXRlX3RpbWVfZ3JhaW5fc3FsYS5weQ==) | | |
| [...ersions/732f1c06bcbf\_add\_fetch\_values\_predicate.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83MzJmMWMwNmJjYmZfYWRkX2ZldGNoX3ZhbHVlc19wcmVkaWNhdGUucHk=) | | |
| [...40e8ea\_change\_table\_schema\_description\_to\_long\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84OTExNWE0MGU4ZWFfY2hhbmdlX3RhYmxlX3NjaGVtYV9kZXNjcmlwdGlvbl90b19sb25nXy5weQ==) | | |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | | |
| ... and [781 more](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1a86007](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **decrease** coverage by `0.62%`.
> The diff coverage is `80.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
- Coverage 60.78% 60.16% -0.63%
=====================================================
Files 393 393
Lines 24848 24900 +52
=====================================================
- Hits 15105 14980 -125
- Misses 9743 9920 +177
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.16% <80.70%> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.80% <100.00%> (+0.46%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.90% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <100.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.74% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1d63d1c](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **decrease** coverage by `0.69%`.
> The diff coverage is `80.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
- Coverage 60.78% 60.09% -0.70%
=====================================================
Files 393 393
Lines 24848 24900 +52
=====================================================
- Hits 15105 14964 -141
- Misses 9743 9936 +193
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.09% <80.70%> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.80% <100.00%> (+0.46%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.90% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <100.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.74% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1d63d1c](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `80.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
+ Coverage 60.78% 60.83% +0.04%
=====================================================
Files 393 393
Lines 24848 24900 +52
=====================================================
+ Hits 15105 15147 +42
- Misses 9743 9753 +10
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.83% <80.70%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.80% <100.00%> (+0.46%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.90% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <100.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.74% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `89.78% <0.00%> (+0.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1d63d1c](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `80.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
+ Coverage 60.78% 60.81% +0.02%
=====================================================
Files 393 393
Lines 24848 24900 +52
=====================================================
+ Hits 15105 15144 +39
- Misses 9743 9756 +13
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.81% <80.70%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.80% <100.00%> (+0.46%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.90% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <100.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.74% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.42% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `89.78% <0.00%> (+0.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1d63d1c](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507904317
##########
File path: superset/models/dashboard.py
##########
@@ -156,7 +156,7 @@ class Dashboard( # pylint: disable=too-many-instance-attributes
]
def __repr__(self) -> str:
- return f"Dashboard<{self.slug or self.id}>"
+ return f"Dashboard<{self.id or self.slug}>"
Review comment:
Huh. Maybe you merged master or something
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian merged pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
suddjian merged pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11325: [WIP] fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **decrease** coverage by `5.51%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
- Coverage 60.78% 55.27% -5.52%
=====================================================
Files 393 401 +8
Lines 24848 13410 -11438
Branches 0 3395 +3395
=====================================================
- Hits 15105 7412 -7693
+ Misses 9743 5804 -3939
- Partials 0 194 +194
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.27% <100.00%> (?)` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ntend/src/dashboard/components/PublishedStatus.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy5qc3g=) | `61.90% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | `91.66% <ø> (ø)` | |
| [...et-frontend/src/explore/controlPanels/sections.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9zZWN0aW9ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | `93.93% <100.00%> (ø)` | |
| [superset/migrations/versions/6414e83d82b7\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy82NDE0ZTgzZDgyYjdfLnB5) | | |
| [...et/migrations/versions/7467e77870e4\_remove\_aggs.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83NDY3ZTc3ODcwZTRfcmVtb3ZlX2FnZ3MucHk=) | | |
| [superset/migrations/versions/fee7b758c130\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mZWU3Yjc1OGMxMzBfLnB5) | | |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | | |
| [superset/migrations/versions/ef8843b41dac\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lZjg4NDNiNDFkYWNfLnB5) | | |
| [superset/migrations/versions/45e7da7cfeba\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NWU3ZGE3Y2ZlYmFfLnB5) | | |
| ... and [781 more](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1a86007](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **decrease** coverage by `0.66%`.
> The diff coverage is `80.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
- Coverage 60.78% 60.12% -0.67%
=====================================================
Files 393 393
Lines 24848 24889 +41
=====================================================
- Hits 15105 14965 -140
- Misses 9743 9924 +181
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.12% <80.70%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.80% <100.00%> (+0.46%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.90% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <100.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.74% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...77b41f6](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507897107
##########
File path: superset/models/dashboard.py
##########
@@ -156,7 +156,7 @@ class Dashboard( # pylint: disable=too-many-instance-attributes
]
def __repr__(self) -> str:
- return f"Dashboard<{self.slug or self.id}>"
+ return f"Dashboard<{self.id or self.slug}>"
Review comment:
shouldn't this be the other way round? Is this one of those lines you didn't touch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11325: [WIP] fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507538247
##########
File path: superset/charts/schemas.py
##########
@@ -705,6 +705,11 @@ class ChartDataExtrasSchema(Schema):
class ChartDataQueryObjectSchema(Schema):
+ applied_time_extras = fields.Dict(
+ description="A mapping of temporal extras that have been applied to the query",
+ required=False,
+ example={"__time_range": "1 year ago : now"},
+ )
Review comment:
I tried creating a dedicated schema with named properties (`__time_range` etc) and then adding a nested reference here, but that didn't work, probably due to the double underscores. Leaving these as a `fields.Dict` for now to get around the double underscore problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **decrease** coverage by `0.37%`.
> The diff coverage is `80.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
- Coverage 60.78% 60.40% -0.38%
=====================================================
Files 393 393
Lines 24848 24900 +52
=====================================================
- Hits 15105 15042 -63
- Misses 9743 9858 +115
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.40% <80.70%> (-0.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.80% <100.00%> (+0.46%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.90% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <100.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.74% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.42% <0.00%> (-0.65%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1d63d1c](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **decrease** coverage by `0.67%`.
> The diff coverage is `80.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
- Coverage 60.78% 60.11% -0.68%
=====================================================
Files 393 393
Lines 24848 24900 +52
=====================================================
- Hits 15105 14968 -137
- Misses 9743 9932 +189
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.11% <80.70%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.80% <100.00%> (+0.46%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.90% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <100.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.74% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1d63d1c](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **decrease** coverage by `0.20%`.
> The diff coverage is `80.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
- Coverage 60.78% 60.58% -0.21%
=====================================================
Files 393 393
Lines 24848 24900 +52
=====================================================
- Hits 15105 15086 -19
- Misses 9743 9814 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.58% <80.70%> (-0.21%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.80% <100.00%> (+0.46%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.90% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <100.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.74% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1d63d1c](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507612918
##########
File path: superset-frontend/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx
##########
@@ -50,7 +50,7 @@ describe('QueryAndSaveButtons', () => {
it('renders buttons with correct text', () => {
expect(wrapper.find(Button).contains('Run')).toBe(true);
- expect(wrapper.find(Button).contains(' Save')).toBe(true);
+ expect(wrapper.find(Button).contains('Save')).toBe(true);
Review comment:
I'm unsure why GH is showing this line (and other similar ones) as changed, as I haven't touched them (the branch is based on `apache:feature/filter-p0` and is up-to-date)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507901223
##########
File path: superset/models/dashboard.py
##########
@@ -156,7 +156,7 @@ class Dashboard( # pylint: disable=too-many-instance-attributes
]
def __repr__(self) -> str:
- return f"Dashboard<{self.slug or self.id}>"
+ return f"Dashboard<{self.id or self.slug}>"
Review comment:
I haven't changed these lines, I think this is GH acting up showing some changes that have come in after the branch was cut.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507897475
##########
File path: superset/models/dashboard.py
##########
@@ -156,7 +156,7 @@ class Dashboard( # pylint: disable=too-many-instance-attributes
]
def __repr__(self) -> str:
- return f"Dashboard<{self.slug or self.id}>"
+ return f"Dashboard<{self.id or self.slug}>"
Review comment:
I guess if it's for the `__repr__` function it makes more sense to use the id
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `80.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
+ Coverage 60.78% 60.81% +0.02%
=====================================================
Files 393 393
Lines 24848 24900 +52
=====================================================
+ Hits 15105 15144 +39
- Misses 9743 9756 +13
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.81% <80.70%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.80% <100.00%> (+0.46%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.90% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <100.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.74% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.42% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `89.78% <0.00%> (+0.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1d63d1c](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11325: [WIP] fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507612918
##########
File path: superset-frontend/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx
##########
@@ -50,7 +50,7 @@ describe('QueryAndSaveButtons', () => {
it('renders buttons with correct text', () => {
expect(wrapper.find(Button).contains('Run')).toBe(true);
- expect(wrapper.find(Button).contains(' Save')).toBe(true);
+ expect(wrapper.find(Button).contains('Save')).toBe(true);
Review comment:
I'm unsure why GH is showing these lines as changed, as I haven't touched them (the branch is based on `apache:feature/filter-p0` and is up-to-date)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11325: fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#issuecomment-711823648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=h1) Report
> Merging [#11325](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/a123b241e3f74efb0e945f73b082215d2cebf9d2?el=desc) will **decrease** coverage by `0.74%`.
> The diff coverage is `80.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11325 +/- ##
=====================================================
- Coverage 60.78% 60.04% -0.75%
=====================================================
Files 393 393
Lines 24848 24900 +52
=====================================================
- Hits 15105 14951 -154
- Misses 9743 9949 +206
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.04% <80.70%> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | `95.00% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <73.17%> (-0.97%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `87.80% <100.00%> (+0.46%)` | :arrow_up: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.90% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <100.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.74% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/11325/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=footer). Last update [a123b24...1d63d1c](https://codecov.io/gh/apache/incubator-superset/pull/11325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11325: [WIP] fix(extra-filters): add logic for identifying applied extra filters
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507612918
##########
File path: superset-frontend/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx
##########
@@ -50,7 +50,7 @@ describe('QueryAndSaveButtons', () => {
it('renders buttons with correct text', () => {
expect(wrapper.find(Button).contains('Run')).toBe(true);
- expect(wrapper.find(Button).contains(' Save')).toBe(true);
+ expect(wrapper.find(Button).contains('Save')).toBe(true);
Review comment:
I'm unsure why GH is showing this lines (and other similar ones) as changed, as I haven't touched them (the branch is based on `apache:feature/filter-p0` and is up-to-date)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org