[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #426: avoids starting tracer for Accumulo 2.1.0

[GitBox <gi...@apache.org>]

arvindshmicrosoft commented on a change in pull request #426:
URL: https://github.com/apache/fluo-muchos/pull/426#discussion_r779248113



##########
File path: ansible/accumulo.yml
##########
@@ -53,16 +53,18 @@
       when: accumulo_major_version == '2' and not use_systemd
 - hosts: accumulomaster
   tasks:
-    - name: "start accumulo 2.0 master, monitor, gc & tracer"
+    - name: "start accumulo 2.0 master, monitor, & gc"
       command: "nohup {{ accumulo_home }}/bin/accumulo-service {{ item }} start"
       register: start_result
       changed_when: "'Starting' in start_result.stdout"
       with_items:
         - master
         - monitor
         - gc
-        - tracer
       when: accumulo_major_version == '2' and not use_systemd
+    - name: "start accumulo 2.0 tracer"
+      command: "nohup {{ accumulo_home }}/bin/accumulo-service tracer start"
+      when: accumulo_version is version('2.0.0','>=') and accumulo_version is version('2.1.0','<') and not use_systemd
 - hosts: accumulomaster
   tasks:
     - name: "install and start all the accumulo services using systemd"

Review comment:
       There will be similar set of `when` conditions needed for the systemd unit for tracer. It would be good to address that as well in this PR, or maybe log an Issue to track the future change needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org