You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Jagadeesan A S (JIRA)" <ji...@apache.org> on 2016/08/31 08:28:21 UTC
[jira] [Commented] (SPARK-10717) remove the with Loging in the
NioBlockTransferService
[ https://issues.apache.org/jira/browse/SPARK-10717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451576#comment-15451576 ]
Jagadeesan A S commented on SPARK-10717:
----------------------------------------
Thanks [~DjvuLee]. Deprecate {{NIO ConnectionManager}} in Spark 1.5.0. from Spark 1.6.0. onwards {{Netty ConnectionManager}} is off by default. cc [~rxin]
> remove the with Loging in the NioBlockTransferService
> -----------------------------------------------------
>
> Key: SPARK-10717
> URL: https://issues.apache.org/jira/browse/SPARK-10717
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Affects Versions: 1.5.0
> Reporter: DjvuLee
> Priority: Minor
>
> Since BlockTransferService implement the Logging interface, we can remove the with Logging in the NioBlockTransferService, keep the same as NettyBlockTransferService
> abstract class BlockTransferService extends ShuffleClient with Closeable with Logging {}
> final class NioBlockTransferService(conf: SparkConf, securityManager: SecurityManager)
> extends BlockTransferService with Logging {}
> class NettyBlockTransferService(conf: SparkConf, securityManager: SecurityManager, numCores: Int) extends BlockTransferService {}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org