[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5101: Miscellaneous fixes

[GitBox <gi...@apache.org>]

zrhoffman commented on a change in pull request #5101:
URL: https://github.com/apache/trafficcontrol/pull/5101#discussion_r506751934



##########
File path: test/router/dnssec/dnssec_suite_test.go
##########
@@ -20,14 +20,14 @@ package dnssec_test
  */
 
 import (
-	. "github.com/onsi/ginkgo"
-	. "github.com/onsi/gomega"
+	// _ "github.com/onsi/ginkgo"
+	// _ "github.com/onsi/gomega"

Review comment:
       These can just be removed, right?

##########
File path: test/router/dnssec/dnssec_suite_test.go
##########
@@ -39,17 +39,32 @@ func init() {
 	flag.StringVar(&deliveryService, "ds", "changeit", "ds is used to target some dns DS and DNS queries made by traffic router")
 }
 
-var _ = BeforeSuite(func() {
+// var _ = BeforeSuite(func() {
+// 	d = &dnssec.DnssecClient{new(dns.Client)}
+// 	d.Net = "udp"
+
+// 	Expect(nameserver).ToNot(Equal("changeit"), "Pass in a ns flag with the hostname of the traffic router")
+// 	Expect(deliveryService).ToNot(Equal("changeit"), "Pass in a ds flag with the dns label for a DNS delivery service")
+// 	log.Println("Nameserver", nameserver)
+// 	log.Println("DeliveryService", deliveryService)
+// })
+
+// func TestDnssec(t *testing.T) {
+// 	RegisterFailHandler(Fail)
+// 	RunSpecs(t, "Dnssec Suite")
+// }

Review comment:
       Can these commented lines be removed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org