You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by GitBox <gi...@apache.org> on 2021/07/21 16:36:23 UTC
[GitHub] [ant] basil opened a new pull request #152: Call correct method to get parent from getRootLoader()
basil opened a new pull request #152:
URL: https://github.com/apache/ant/pull/152
See [#149 (comment)](https://github.com/apache/ant/pull/149#issuecomment-884318912). Similar to what #151 did for `findResources(String, boolean)`, this PR amends `getRootLoader()` to invoke the correct method to get the parent. The `getParent()` method returns the immutable `parent` field from the parent `ClassLoader` class, which is not used by `AntClassLoader`. The correct method is `getConfiguredParent()` (introduced in commit 26f846b83), which returns the mutable `parent` field from the `AntClassLoader` class.
**Untested.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] basil commented on pull request #152: Call correct method to get parent from getRootLoader()
Posted by GitBox <gi...@apache.org>.
basil commented on pull request #152:
URL: https://github.com/apache/ant/pull/152#issuecomment-886236175
Closing this PR, as I don't think it makes sense anymore. The `getRootLoader()` method is only invoked when this class is running in "isolated" mode, which is documented as follows:
```java
/**
* Whether or not this classloader will ignore the base
* classloader if it can't find a class.
*
* @see #setIsolated(boolean)
*/
private boolean ignoreBase = false;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] basil closed pull request #152: Call correct method to get parent from getRootLoader()
Posted by GitBox <gi...@apache.org>.
basil closed pull request #152:
URL: https://github.com/apache/ant/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org