You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "hboutemy (via GitHub)" <gi...@apache.org> on 2024/04/13 09:38:42 UTC
[PR] rework documentation for new JDK-specific goals [maven-toolchains-plugin]
hboutemy opened a new pull request, #32:
URL: https://github.com/apache/maven-toolchains-plugin/pull/32
publishing result to https://maven.apache.org/plugins-archives/maven-toolchains-plugin-LATEST/index.html
`mvn -Preporting site-deploy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rework documentation for new JDK-specific goals [maven-toolchains-plugin]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #32:
URL: https://github.com/apache/maven-toolchains-plugin/pull/32#discussion_r1564612763
##########
src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java:
##########
@@ -62,9 +62,9 @@ public class ToolchainMojo extends AbstractMojo {
/**
* Toolchains requirements, specified by one
* <pre> <toolchain-type>
- * <param>expected value</param>
- * ...
- * </toolchain-type></pre>
+ * <param>expected value</param>
+ * ...
+ * </toolchain-type></pre>
Review Comment:
if it works, I take: I'll try and report
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rework documentation for new JDK-specific goals [maven-toolchains-plugin]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #32:
URL: https://github.com/apache/maven-toolchains-plugin/pull/32#discussion_r1564609182
##########
src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java:
##########
@@ -62,9 +62,9 @@ public class ToolchainMojo extends AbstractMojo {
/**
* Toolchains requirements, specified by one
* <pre> <toolchain-type>
- * <param>expected value</param>
- * ...
- * </toolchain-type></pre>
+ * <param>expected value</param>
+ * ...
+ * </toolchain-type></pre>
Review Comment:
what about something such
```
* <pre>{@code <toolchain-type>
* <param>expected value</param>
* ...
* </toolchain-type>
* }</pre>
*
```
I find more human readable compared to the escaped values. Should work for the goal page generation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rework documentation for new JDK-specific goals [maven-toolchains-plugin]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #32:
URL: https://github.com/apache/maven-toolchains-plugin/pull/32#discussion_r1564629300
##########
src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java:
##########
@@ -62,9 +62,9 @@ public class ToolchainMojo extends AbstractMojo {
/**
* Toolchains requirements, specified by one
* <pre> <toolchain-type>
- * <param>expected value</param>
- * ...
- * </toolchain-type></pre>
+ * <param>expected value</param>
+ * ...
+ * </toolchain-type></pre>
Review Comment:
it works, good idea integrated, thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rework documentation for new JDK-specific goals [maven-toolchains-plugin]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy merged PR #32:
URL: https://github.com/apache/maven-toolchains-plugin/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org