[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2775: [STREAMSTORAGE] support an optional time to live (TTL) on a per table basis

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #2775:
URL: https://github.com/apache/bookkeeper/pull/2775#discussion_r695548506



##########
File path: stream/statelib/src/main/java/org/apache/bookkeeper/statelib/impl/kv/RocksdbKVStore.java
##########
@@ -367,11 +376,35 @@ protected void openRocksdb(StateStoreSpec spec) throws StateStoreException {
             }
 
             List<ColumnFamilyHandle> cfHandles = Lists.newArrayListWithExpectedSize(2);
-            RocksDB db = RocksDB.open(
-                options,
-                dbDir.getAbsolutePath(),
-                Lists.newArrayList(metaDesc, dataDesc),
-                cfHandles);
+
+            RocksDB db = TtlDB.open(

Review comment:
       if ttlSeconds is not set, can we simply open the Database in the old way ?
   
   every existing BK cluster does not have this option
   IIUC with this change we are going to open/close/open the DB
   we can go with `RocksDB.open` without even trying to do `TtlDB.open`
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org