You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Cheolsoo Park <ch...@cloudera.com> on 2012/03/27 01:47:39 UTC
Review Request: SQOOP-465 BLOB support for Avro import
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4496/
-----------------------------------------------------------
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Summary
-------
BLOB is supported for text and sequence import only.
Provide further support for Avro import.
This addresses bug SQOOP-465.
https://issues.apache.org/jira/browse/SQOOP-465
Diffs
-----
./src/java/org/apache/sqoop/manager/ConnManager.java 1303136
./src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 1303098
Diff: https://reviews.apache.org/r/4496/diff
Testing
-------
Manually tested: verified that Avro byte files were generated.
New JUnit test will be added by SQOOP-470.
Thanks,
Cheolsoo
Re: Review Request: SQOOP-465 BLOB support for Avro import
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4496/#review6547
-----------------------------------------------------------
Ship it!
Thanks for the patch, Cheolsoo!
- Bilung
On 2012-03-28 02:46:54, Cheolsoo Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4496/
> -----------------------------------------------------------
>
> (Updated 2012-03-28 02:46:54)
>
>
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
>
>
> Summary
> -------
>
> BLOB is supported for text and sequence import only.
> Provide further support for Avro import.
>
>
> This addresses bug SQOOP-465.
> https://issues.apache.org/jira/browse/SQOOP-465
>
>
> Diffs
> -----
>
> ./src/java/org/apache/sqoop/manager/ConnManager.java 1303136
> ./src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 1303098
>
> Diff: https://reviews.apache.org/r/4496/diff
>
>
> Testing
> -------
>
> Tested with Oracle XE 10g and MySQL 5.1 using newly added LobAvroImportTest by SQOOP-470: https://reviews.apache.org/r/4527/
>
> Ran ant test
> Ran ant test -Dthirdparty=true
> Ran ant checkstyle
>
>
> Thanks,
>
> Cheolsoo
>
>
Re: Review Request: SQOOP-465 BLOB support for Avro import
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4496/
-----------------------------------------------------------
(Updated 2012-03-28 02:46:54.876527)
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Summary
-------
BLOB is supported for text and sequence import only.
Provide further support for Avro import.
This addresses bug SQOOP-465.
https://issues.apache.org/jira/browse/SQOOP-465
Diffs
-----
./src/java/org/apache/sqoop/manager/ConnManager.java 1303136
./src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 1303098
Diff: https://reviews.apache.org/r/4496/diff
Testing (updated)
-------
Tested with Oracle XE 10g and MySQL 5.1 using newly added LobAvroImportTest by SQOOP-470: https://reviews.apache.org/r/4527/
Ran ant test
Ran ant test -Dthirdparty=true
Ran ant checkstyle
Thanks,
Cheolsoo
Re: Review Request: SQOOP-465 BLOB support for Avro import
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4496/
-----------------------------------------------------------
(Updated 2012-03-28 02:43:22.864342)
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Changes
-------
Map java.sql.Types.LONGVARBINARY to Avro Bytes.
MySQL driver maps BLOB to LONGVARBINARY, so it has to be mapped to Avro bytes to support Avro blob import in MySQL.
Summary
-------
BLOB is supported for text and sequence import only.
Provide further support for Avro import.
This addresses bug SQOOP-465.
https://issues.apache.org/jira/browse/SQOOP-465
Diffs (updated)
-----
./src/java/org/apache/sqoop/manager/ConnManager.java 1303136
./src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 1303098
Diff: https://reviews.apache.org/r/4496/diff
Testing
-------
Manually tested: verified that Avro byte files were generated.
New JUnit test will be added by SQOOP-470.
Thanks,
Cheolsoo
Re: Review Request: SQOOP-465 BLOB support for Avro import
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4496/
-----------------------------------------------------------
(Updated 2012-03-28 01:56:53.483089)
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Changes
-------
Close LargeObjectLoader in the cleanup method of AvroImportMapper. Not closing LargeObjectLoader can cause EOFException when reading a LOB file via LobReader.
Summary
-------
BLOB is supported for text and sequence import only.
Provide further support for Avro import.
This addresses bug SQOOP-465.
https://issues.apache.org/jira/browse/SQOOP-465
Diffs (updated)
-----
./src/java/org/apache/sqoop/manager/ConnManager.java 1303136
./src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 1303098
Diff: https://reviews.apache.org/r/4496/diff
Testing
-------
Manually tested: verified that Avro byte files were generated.
New JUnit test will be added by SQOOP-470.
Thanks,
Cheolsoo