You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Arina Ielchiieva (JIRA)" <ji...@apache.org> on 2018/03/09 10:44:00 UTC
[jira] [Commented] (DRILL-6226) Projection pushdown does not occur
with Calcite upgrade
[ https://issues.apache.org/jira/browse/DRILL-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392695#comment-16392695 ]
Arina Ielchiieva commented on DRILL-6226:
-----------------------------------------
[~gparai] in current master places that you refer use dynamic star.
For example, {{GroupScan.ALL_COLUMNS}}:
{code:java}
List<SchemaPath> ALL_COLUMNS = ImmutableList.of(SchemaPath.STAR_COLUMN);
public static final String DYNAMIC_STAR = "**";
public static final SchemaPath STAR_COLUMN = getSimplePath(DYNAMIC_STAR);
{code}
Please check on current master. In DRILL-6118 all remaining references to '*' where replaced with DYNAMIC_STAR.
Plus could you provide example when project push down fails?
> Projection pushdown does not occur with Calcite upgrade
> -------------------------------------------------------
>
> Key: DRILL-6226
> URL: https://issues.apache.org/jira/browse/DRILL-6226
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.13.0
> Reporter: Gautam Kumar Parai
> Priority: Major
> Fix For: 1.13.0
>
>
> I am seeing plan issues where projection pushdown does not occur due to costing. The root cause is in DrillScanRel we are relying on utility functions to determine STAR columns which fails with the Calcite upgrade - because GroupScan is using GroupScan.ALL_COLUMNS which is different from STAR_COLUMN/DYNAMIC_STAR.
> While looking at references of SchemaPath.STAR_COLUMN, we found comparisons involving hardcoded '*'. These might also need to change to accommodate for DYNAMIC STAR.
> [~arina] [~amansinha100] please let me know your thoughts on this issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)