You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by li...@apache.org on 2022/04/25 17:19:25 UTC

[arrow-cookbook] branch main updated: ARROW-16291: [Java] Support JSE17 for Java Cookbooks (#184)

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-cookbook.git


The following commit(s) were added to refs/heads/main by this push:
     new 6674254  ARROW-16291: [Java] Support JSE17 for Java Cookbooks (#184)
6674254 is described below

commit 6674254808ca2726c7453b12653bbe106eb471dd
Author: david dali susanibar arce <da...@gmail.com>
AuthorDate: Mon Apr 25 12:19:20 2022 -0500

    ARROW-16291: [Java] Support JSE17 for Java Cookbooks (#184)
    
    * Initial commit to test Arrow Java with JSE17/18
    
    * Solving problems with SemVer
    
    * Empty-Commit
    
    * Adding actions/setup-python@v3
---
 .github/workflows/test_java_linux_cookbook.yml | 15 +++++++++++----
 .github/workflows/test_java_osx_cookbook.yml   | 15 ++++++++++-----
 java/ext/javadoctest.py                        |  2 +-
 3 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/test_java_linux_cookbook.yml b/.github/workflows/test_java_linux_cookbook.yml
index da00496..1e3393f 100644
--- a/.github/workflows/test_java_linux_cookbook.yml
+++ b/.github/workflows/test_java_linux_cookbook.yml
@@ -33,16 +33,23 @@ jobs:
   test_java_linux:
     name: "Test Java Cookbook On Linux"
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: [ '3.9' ]
+        java-version: [ '11', '17', '18' ]
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions/setup-java@v2
+      - uses: actions/checkout@v3
+      - uses: actions/setup-python@v3
+        with:
+          python-version: ${{ matrix.python-version }}
+      - uses: actions/setup-java@v3
         with:
           distribution: 'temurin'
-          java-version: '11'
+          java-version: ${{ matrix.java-version }}
       - name: Install dependencies
         run: |
           sudo apt update
-          sudo apt install libcurl4-openssl-dev libssl-dev python3-pip maven
+          sudo apt install libcurl4-openssl-dev libssl-dev
       - name: Run tests
         run: make javatest
       - name: Build cookbook
diff --git a/.github/workflows/test_java_osx_cookbook.yml b/.github/workflows/test_java_osx_cookbook.yml
index a55dd68..b68d9a5 100644
--- a/.github/workflows/test_java_osx_cookbook.yml
+++ b/.github/workflows/test_java_osx_cookbook.yml
@@ -33,14 +33,19 @@ jobs:
   test_java_osx:
     name: "Test Java Cookbook on MacOS"
     runs-on: macos-latest
+    strategy:
+      matrix:
+        python-version: [ '3.9' ]
+        java-version: [ '11', '17', '18' ]
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions/setup-java@v2
+      - uses: actions/checkout@v3
+      - uses: actions/setup-python@v3
+        with:
+          python-version: ${{ matrix.python-version }}
+      - uses: actions/setup-java@v3
         with:
           distribution: 'temurin'
-          java-version: '11'
-      - name: Upgrade pip
-        run: python3 -m pip install --upgrade pip
+          java-version: ${{ matrix.java-version }}
       - name: Run tests
         run: make javatest
       - name: Build cookbook
diff --git a/java/ext/javadoctest.py b/java/ext/javadoctest.py
index 7a1604b..f568b22 100644
--- a/java/ext/javadoctest.py
+++ b/java/ext/javadoctest.py
@@ -59,7 +59,7 @@ class JavaDocTestBuilder(DocTestBuilder):
         # JDK11 support '-' This allows the pipe to work as expected without requiring a shell
         # Migrating to /dev/stdin to also support JDK9+
         proc_jshell_process = subprocess.Popen(
-            ["jshell", "--class-path", stdout_dependency, "-s", "/dev/stdin"],
+            ["jshell", "-R--add-opens=java.base/java.nio=ALL-UNNAMED", "--class-path", stdout_dependency, "-s", "/dev/stdin"],
             stdin=subprocess.PIPE,
             stdout=subprocess.PIPE,
             text=True,