You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/30 10:32:56 UTC
[GitHub] [kafka] dengziming opened a new pull request #9662: Kafka-10130; Rewrite FeatureZNode struct with auto-generated protocol
dengziming opened a new pull request #9662:
URL: https://github.com/apache/kafka/pull/9662
*More detailed description of your change*
1. remove FeatureZNode and replace it with FeatureZNode.json
2. Change code where FeatureZNode is used
3. copy some code of `org.apache.kafka.raft.FileBasedStateStore` to generate json data from and to FeatureZNodeData
*Summary of testing strategy (including rationale)*
Replace FeatureZNode in unit test and integration test
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #9662: KAFKA-10130; Rewrite FeatureZNode struct with auto-generated protocol
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #9662:
URL: https://github.com/apache/kafka/pull/9662#issuecomment-874535090
We no longer need this since KIP-500 are removing all these code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #9662: KAFKA-10130; Rewrite FeatureZNode struct with auto-generated protocol
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #9662:
URL: https://github.com/apache/kafka/pull/9662#issuecomment-874535090
We no longer need this since KIP-500 are removing all these code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #9662: KAFKA-10130; Rewrite FeatureZNode struct with auto-generated protocol
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #9662:
URL: https://github.com/apache/kafka/pull/9662#issuecomment-735765304
@abbccdda @kowshik hi, PTAL.
also ping @cmccabe @hachikuji to have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming closed pull request #9662: KAFKA-10130; Rewrite FeatureZNode struct with auto-generated protocol
Posted by GitBox <gi...@apache.org>.
dengziming closed pull request #9662:
URL: https://github.com/apache/kafka/pull/9662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming closed pull request #9662: KAFKA-10130; Rewrite FeatureZNode struct with auto-generated protocol
Posted by GitBox <gi...@apache.org>.
dengziming closed pull request #9662:
URL: https://github.com/apache/kafka/pull/9662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org