[GitHub] [cloudstack] nvazquez commented on a change in pull request #5103: Extend the Annotations framework

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #5103:
URL: https://github.com/apache/cloudstack/pull/5103#discussion_r678226937



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/annotation/ListAnnotationsCmd.java
##########
@@ -41,11 +41,25 @@
 
     @Parameter(name = ApiConstants.ID, type = CommandType.STRING, description = "the id of the annotation")
     private String uuid;
+
     @Parameter(name = ApiConstants.ENTITY_TYPE, type = CommandType.STRING, description = "the entity type")
     private String entityType;
+
     @Parameter(name = ApiConstants.ENTITY_ID, type = CommandType.STRING, description = "the id of the entity for which to show annotations")
     private String entityUuid;
 
+    @Parameter(name = ApiConstants.USER_ID, type = CommandType.STRING,
+            description = "optional: the id of the user of the annotation", required = false)
+    private String userUuid;
+
+    @Parameter(name = ApiConstants.ANNOTATION_FILTER,
+            type = CommandType.STRING,
+            required = true,
+            description = "possible values are \"self\" and \"all\". "
+                    + "* self : annotations that have been created by the calling user. "
+                    + "* all : all templates (only usable by admins).")

Review comment:
       Done, thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org