You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by jiny2 <gi...@git.apache.org> on 2017/11/07 20:49:51 UTC
[GitHub] incubator-hawq pull request #1308: HAWQ-1530. Illegally killing a JDBC selec...
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1308
HAWQ-1530. Illegally killing a JDBC select query causes locking problems
This bug root cause maybe twice FATAL error throwing, I cannot exactly reproduce it according to this issue's comment, just based on my understanding and previous bug fix experiences. We cannot allow a FATAL throwed again when anohter FATAL causes process into exit phase.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2/incubator-hawq HAWQ-1530
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1308.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1308
----
commit 7a103541d11cebd3872dc1b7108ab636f7f53ddf
Author: Yi <yj...@apache.org>
Date: 2017-11-07T20:47:02Z
HAWQ-1530. Illegally killing a JDBC select query causes locking problems
----
---
[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...
Posted by amyrazz44 <gi...@git.apache.org>.
Github user amyrazz44 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1308
LGTM +1
---
[GitHub] incubator-hawq pull request #1308: HAWQ-1530. Illegally killing a JDBC selec...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1308#discussion_r149832325
--- Diff: src/backend/cdb/dispatcher.c ---
@@ -1414,9 +1415,12 @@ dispatch_cleanup(DispatchData *data)
if (dispatcher_is_state_error(data))
--- End diff --
The same logic, no special performance improvement in my opinion
---
[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1308
+1
---
[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1308
@radarwave @linwen @changleicn please review and comment
---
[GitHub] incubator-hawq pull request #1308: HAWQ-1530. Illegally killing a JDBC selec...
Posted by kuien <gi...@git.apache.org>.
Github user kuien commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1308#discussion_r149592641
--- Diff: src/backend/cdb/dispatcher.c ---
@@ -1414,9 +1415,12 @@ dispatch_cleanup(DispatchData *data)
if (dispatcher_is_state_error(data))
--- End diff --
May we check the status of 'proc_exit_inprogress' earlier and simpler? That is:
```
if (proc_exit_inprogress)
return;
```
---
[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1308
@kuien please check this fix
---
[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1308
+1
---
[GitHub] incubator-hawq pull request #1308: HAWQ-1530. Illegally killing a JDBC selec...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1308
---