[GitHub] [trafficcontrol] rob05c edited a comment on issue #3982: Add Traffic Monitor gbps calculated stat.

[GitBox <gi...@apache.org>]

rob05c edited a comment on issue #3982: Add Traffic Monitor gbps calculated stat.
URL: https://github.com/apache/trafficcontrol/pull/3982#issuecomment-541090806
 
 
   Thanks! This is great, this small change is a big help to CDN operators!
   
   Would you mind adding a `CHANGELOG.md` entry? Since this is a new feature, it should have an entry for the next Release (`## [Unreleased]` header in the file). The `CHANGELOG.md` file is at the root of the project.
   
   I think this is ok without docs, we don't currently document the calculated stats in the Monitor.
   
   But, we've been trying to add tests for every new feature. Would you mind adding a small unit test for this?
   The ComputedStat funcs take a lot of data, but your func doesn't need most of the variables, so for the test, you can pass empty objects for everything but `info.Vitals.KbpsOut`, and then just verify that various Kbps inputs turn into the expected Gbps.
   
   Have you tested already, or run ATC before? If not, there are several ways you can do it. The easiest is probably to run a CDN-in-a-Box, instructions are here: https://traffic-control-cdn.readthedocs.io/en/latest/admin/quick_howto/ciab.html. A CDN is a complex thing though, if you hit issues, we're more than happy to help. We're on Slack, and also have an email list: https://traffic-control-cdn.readthedocs.io/en/latest/faq.html#how-do-i-get-help-with-traffic-control

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services