[GitHub] [arrow] metalmatze commented on a diff in pull request #35956: MINOR: [Go] Add IsNull method to dictionary builder

["metalmatze (via GitHub)" <gi...@apache.org>]

metalmatze commented on code in PR #35956:
URL: https://github.com/apache/arrow/pull/35956#discussion_r1221198689


##########
go/arrow/array/dictionary.go:
##########
@@ -1293,6 +1293,29 @@ func (b *BinaryDictionaryBuilder) InsertStringDictValues(arr *String) (err error
 	return
 }
 
+func (b *BinaryDictionaryBuilder) IsNull(i int) bool {
+	switch b := b.idxBuilder.Builder.(type) {
+	case *Uint8Builder:
+		return b.builder.nullBitmap.Len() != 0 && bitutil.BitIsNotSet(b.builder.nullBitmap.Bytes(), i)
+	case *Int8Builder:
+		return b.builder.nullBitmap.Len() != 0 && bitutil.BitIsNotSet(b.builder.nullBitmap.Bytes(), i)
+	case *Uint16Builder:
+		return b.builder.nullBitmap.Len() != 0 && bitutil.BitIsNotSet(b.builder.nullBitmap.Bytes(), i)
+	case *Int16Builder:
+		return b.builder.nullBitmap.Len() != 0 && bitutil.BitIsNotSet(b.builder.nullBitmap.Bytes(), i)
+	case *Uint32Builder:
+		return b.builder.nullBitmap.Len() != 0 && bitutil.BitIsNotSet(b.builder.nullBitmap.Bytes(), i)
+	case *Int32Builder:
+		return b.builder.nullBitmap.Len() != 0 && bitutil.BitIsNotSet(b.builder.nullBitmap.Bytes(), i)
+	case *Uint64Builder:
+		return b.builder.nullBitmap.Len() != 0 && bitutil.BitIsNotSet(b.builder.nullBitmap.Bytes(), i)
+	case *Int64Builder:
+		return b.builder.nullBitmap.Len() != 0 && bitutil.BitIsNotSet(b.builder.nullBitmap.Bytes(), i)
+	default:
+		return false
+	}
+}

Review Comment:
   That's cool! Let me tackle that!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org